You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/02/16 03:23:51 UTC
[kudu-CR] [test] enable hash partitioning for TestWorkload's table
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17067
Change subject: [test] enable hash partitioning for TestWorkload's table
......................................................................
[test] enable hash partitioning for TestWorkload's table
With this patch, it's now possible to have auto-created TestWorkload's
table use hash partitioning. The newly introduced functionality
will be used in follow-up patches.
Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
---
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
2 files changed, 65 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/17067/1
--
To view, visit http://gerrit.cloudera.org:8080/17067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
Gerrit-Change-Number: 17067
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [test] enable hash partitioning for TestWorkload's table
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17067 )
Change subject: [test] enable hash partitioning for TestWorkload's table
......................................................................
[test] enable hash partitioning for TestWorkload's table
With this patch, it's now possible to have auto-created TestWorkload's
table use hash partitioning. The newly introduced functionality
will be used in follow-up patches.
Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
Reviewed-on: http://gerrit.cloudera.org:8080/17067
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
2 files changed, 65 insertions(+), 23 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
Gerrit-Change-Number: 17067
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] enable hash partitioning for TestWorkload's table
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [test] enable hash partitioning for TestWorkload's table
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
Gerrit-Change-Number: 17067
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] enable hash partitioning for TestWorkload's table
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17067 )
Change subject: [test] enable hash partitioning for TestWorkload's table
......................................................................
Patch Set 2: Verified+1
unrelated failure:
Runtime error: Webserver: could not start on address 127.28.110.196:39007: set_ports_option: cannot bind to 127.28.110.196:39007: 98 (Address already in use)
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/tablet_copy-itest.cc:1321: Failure
Failed
Bad status: Runtime error: /tmp/dist-test-taskU9K7u7/build/asan/bin/kudu: process exited with non-zero status 1
--
To view, visit http://gerrit.cloudera.org:8080/17067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
Gerrit-Change-Number: 17067
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Feb 2021 06:03:42 +0000
Gerrit-HasComments: No
[kudu-CR] [test] enable hash partitioning for TestWorkload's table
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17067 )
Change subject: [test] enable hash partitioning for TestWorkload's table
......................................................................
Patch Set 2: Code-Review+2
Carrying over Andrew's +2 from PS1.
--
To view, visit http://gerrit.cloudera.org:8080/17067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
Gerrit-Change-Number: 17067
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Feb 2021 06:04:08 +0000
Gerrit-HasComments: No
[kudu-CR] [test] enable hash partitioning for TestWorkload's table
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17067 )
Change subject: [test] enable hash partitioning for TestWorkload's table
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17067/1/src/kudu/integration-tests/test_workload.h
File src/kudu/integration-tests/test_workload.h:
http://gerrit.cloudera.org:8080/#/c/17067/1/src/kudu/integration-tests/test_workload.h@66
PS1, Line 66: TestWorkdload
> nit: typo
Done
--
To view, visit http://gerrit.cloudera.org:8080/17067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
Gerrit-Change-Number: 17067
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Feb 2021 05:11:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] enable hash partitioning for TestWorkload's table
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17067
to look at the new patch set (#2).
Change subject: [test] enable hash partitioning for TestWorkload's table
......................................................................
[test] enable hash partitioning for TestWorkload's table
With this patch, it's now possible to have auto-created TestWorkload's
table use hash partitioning. The newly introduced functionality
will be used in follow-up patches.
Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
---
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/test_workload.h
2 files changed, 65 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/17067/2
--
To view, visit http://gerrit.cloudera.org:8080/17067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
Gerrit-Change-Number: 17067
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] enable hash partitioning for TestWorkload's table
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17067 )
Change subject: [test] enable hash partitioning for TestWorkload's table
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17067/1/src/kudu/integration-tests/test_workload.h
File src/kudu/integration-tests/test_workload.h:
http://gerrit.cloudera.org:8080/#/c/17067/1/src/kudu/integration-tests/test_workload.h@66
PS1, Line 66: TestWorkdload
nit: typo
--
To view, visit http://gerrit.cloudera.org:8080/17067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie693431a64ba2c3eb1ed1021faf8da42af03db86
Gerrit-Change-Number: 17067
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 16 Feb 2021 04:32:14 +0000
Gerrit-HasComments: Yes