You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/02/27 01:30:48 UTC

Review Request 18549: Introduced ABORT_MSG as alternative to fatal

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort_msg.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 

Diff: https://reviews.apache.org/r/18549/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Feb. 27, 2014, 6:52 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp, lines 89-90
> > <https://reviews.apache.org/r/18549/diff/1/?file=505247#file505247line89>
> >
> >     I'd prefer to keep the google::LogMessageFatal here to mimic the semantics of CHECK. In particular, the LogMessageFatal will include a stack trace.
> 
> Dominic Hamon wrote:
>     so will abort. This means we have no glog dependency in stout.

I'd like to preserve the CHECK semantics and do a google::LogMessageFatal. It's okay to have a glog dependency here since this can really be seen as an extension to glog, just like the gtest.h and gmock.h (in libprocess) are extensions. Also, as long as we're using google::LogMessageFatal, how about calling it CheckFatal instead of CheckAbort? Thanks!


> On Feb. 27, 2014, 6:52 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp, lines 49-50
> > <https://reviews.apache.org/r/18549/diff/1/?file=505248#file505248line49>
> >
> >     Why not use UNREACHABLE here?
> 
> Dominic Hamon wrote:
>     I was just doing a grep/replace for fatal.

You can just 'return UNREACHABLE();' here and remove the 'return -1;'.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/#review35651
-----------------------------------------------------------


On Feb. 27, 2014, 7:08 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18549/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 7:08 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1041
>     https://issues.apache.org/jira/browse/MESOS-1041
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 
> 
> Diff: https://reviews.apache.org/r/18549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18549: Introduced ABORT as alternative to fatal

Posted by Dominic Hamon <dh...@twopensource.com>.

> On Feb. 27, 2014, 10:52 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/abort_msg.hpp, line 27
> > <https://reviews.apache.org/r/18549/diff/1/?file=505246#file505246line27>
> >
> >     Why ABORT_MSG instead of just ABORT?

I toyed with the idea of having ABORT as a wrapper for abort() for consistency but then dropped that. Also, it was called FATAL_MSG at some point because FATAL clashed with glog.


> On Feb. 27, 2014, 10:52 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp, line 84
> > <https://reviews.apache.org/r/18549/diff/1/?file=505247#file505247line84>
> >
> >     There has always been a bug here: we need to append the error here rather than down in the constructor otherwise any appended strings via '<<' will end up being written in between (and be confusing and hard to read). Just like 'expression', this will let you kill 'error' as an instance member too!

added file and line here too.


> On Feb. 27, 2014, 10:52 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp, lines 89-90
> > <https://reviews.apache.org/r/18549/diff/1/?file=505247#file505247line89>
> >
> >     I'd prefer to keep the google::LogMessageFatal here to mimic the semantics of CHECK. In particular, the LogMessageFatal will include a stack trace.

so will abort. This means we have no glog dependency in stout.


> On Feb. 27, 2014, 10:52 a.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp, lines 49-50
> > <https://reviews.apache.org/r/18549/diff/1/?file=505248#file505248line49>
> >
> >     Why not use UNREACHABLE here?

I was just doing a grep/replace for fatal.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/#review35651
-----------------------------------------------------------


On Feb. 27, 2014, 11:03 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18549/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 11:03 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1041
>     https://issues.apache.org/jira/browse/MESOS-1041
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 
> 
> Diff: https://reviews.apache.org/r/18549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/#review35651
-----------------------------------------------------------

Ship it!


With these abstractions now it seems like the guide will be (at least in libprocess and Mesos):

(1) Use ABORT where you need signal safety and want to abort. No conditional for ABORT is provided and should be done explicitly.
(2) Use LOG(FATAL) and CHECK* where you want to abort otherwise and don't need signal safety (and do or don't want a conditional).

We should kill fatal in subsequent reviews then.


3rdparty/libprocess/3rdparty/stout/include/stout/abort_msg.hpp
<https://reviews.apache.org/r/18549/#comment66283>

    s/signal/Signal/



3rdparty/libprocess/3rdparty/stout/include/stout/abort_msg.hpp
<https://reviews.apache.org/r/18549/#comment66285>

    Why ABORT_MSG instead of just ABORT?



3rdparty/libprocess/3rdparty/stout/include/stout/abort_msg.hpp
<https://reviews.apache.org/r/18549/#comment66282>

    '{' on newline please.



3rdparty/libprocess/3rdparty/stout/include/stout/abort_msg.hpp
<https://reviews.apache.org/r/18549/#comment66284>

    Please kill white spaces.



3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp
<https://reviews.apache.org/r/18549/#comment66302>

    How about s/CheckFailed/CheckFailure/ or s/CheckFailed/CheckFatal/ to differentiate the CHECK_FAILED case in libprocess? I'm happy to see a better name than 'Failure' too (since that's overloaded with libprocess futures) but I'd like to avoid 'Failed' (originally looking at these reviews I thought '_CheckFailed' was just for the CHECK_FAILED case).



3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp
<https://reviews.apache.org/r/18549/#comment66295>

    There has always been a bug here: we need to append the error here rather than down in the constructor otherwise any appended strings via '<<' will end up being written in between (and be confusing and hard to read). Just like 'expression', this will let you kill 'error' as an instance member too!



3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp
<https://reviews.apache.org/r/18549/#comment66286>

    I'd prefer to keep the google::LogMessageFatal here to mimic the semantics of CHECK. In particular, the LogMessageFatal will include a stack trace.



3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp
<https://reviews.apache.org/r/18549/#comment66288>

    Why not use UNREACHABLE here?


- Benjamin Hindman


On Feb. 27, 2014, 12:30 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18549/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 12:30 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1041
>     https://issues.apache.org/jira/browse/MESOS-1041
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort_msg.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 
> 
> Diff: https://reviews.apache.org/r/18549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/#review36287
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp
<https://reviews.apache.org/r/18549/#comment67242>

    s/ABORT_MSG/ABORT/g


- Benjamin Hindman


On Feb. 27, 2014, 7:08 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18549/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 7:08 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1041
>     https://issues.apache.org/jira/browse/MESOS-1041
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 
> 
> Diff: https://reviews.apache.org/r/18549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/#review36312
-----------------------------------------------------------

Ship it!


I'm going to commit this now.

- Benjamin Hindman


On March 6, 2014, 12:56 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18549/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 12:56 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1041
>     https://issues.apache.org/jira/browse/MESOS-1041
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 
> 
> Diff: https://reviews.apache.org/r/18549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------

(Updated March 5, 2014, 4:56 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 

Diff: https://reviews.apache.org/r/18549/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------

(Updated March 5, 2014, 4:36 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 

Diff: https://reviews.apache.org/r/18549/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/#review36301
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp
<https://reviews.apache.org/r/18549/#comment67255>

    I don't think this is doing what you want it to do. I think you need another __STRINGIZE.



3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp
<https://reviews.apache.org/r/18549/#comment67256>

    No need to print the file and line twice, they should get taken care of by google::LogMessageFatal below.


- Benjamin Hindman


On March 6, 2014, 12:28 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18549/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 12:28 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1041
>     https://issues.apache.org/jira/browse/MESOS-1041
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
>   3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 
> 
> Diff: https://reviews.apache.org/r/18549/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------

(Updated March 5, 2014, 4:28 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 

Diff: https://reviews.apache.org/r/18549/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------

(Updated March 5, 2014, 4:13 p.m.)


Review request for mesos and Benjamin Hindman.


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 

Diff: https://reviews.apache.org/r/18549/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------

(Updated March 5, 2014, 4:07 p.m.)


Review request for mesos and Benjamin Hindman.


Summary (updated)
-----------------

Introduced ABORT_MSG as alternative to fatal.


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 

Diff: https://reviews.apache.org/r/18549/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 18549: Introduced ABORT_MSG as alternative to fatal

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------

(Updated Feb. 27, 2014, 11:08 a.m.)


Review request for mesos and Benjamin Hindman.


Summary (updated)
-----------------

Introduced ABORT_MSG as alternative to fatal


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 

Diff: https://reviews.apache.org/r/18549/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 18549: Introduced ABORT as alternative to fatal

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18549/
-----------------------------------------------------------

(Updated Feb. 27, 2014, 11:03 a.m.)


Review request for mesos and Benjamin Hindman.


Summary (updated)
-----------------

Introduced ABORT as alternative to fatal


Bugs: MESOS-1041
    https://issues.apache.org/jira/browse/MESOS-1041


Repository: mesos-git


Description
-------

see summary


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 5d5a76021900bf27113fe5b730cfd2b6a537d132 
  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 695db20cb1acff036d8d493be4ff4b5e002fdd90 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 3350929686e5365225f72f48d7c99b42c57fd1ad 

Diff: https://reviews.apache.org/r/18549/diff/


Testing
-------

make check


Thanks,

Dominic Hamon