[GitHub] [rocketmq-apis] aaron-ai commented on a diff in pull request #21: Refactor client settings

[GitBox <gi...@apache.org>]

aaron-ai commented on code in PR #21:
URL: https://github.com/apache/rocketmq-apis/pull/21#discussion_r852009410


##########
apache/rocketmq/v2/service.proto:
##########
@@ -188,51 +186,102 @@ message RecoverOrphanedTransactionCommand {
   string transaction_id = 2;
 }
 
-message Settings {
-  optional Publishing publishing = 1;
-  optional Subscription subscription = 2;
-  Tracing tracing = 3;
+message ActivePublishingSettings {
+  repeated Resource publishing_topics = 1;
+  RetryPolicy retry_policy = 2;
 }
 
-enum Direction {
-  DIRECTION_UNSPECIFIED = 0;
-  REQUEST = 1;
-  RESPONSE = 2;
+message ActiveSubscriptionSettings {
+  Resource group = 1;
+  repeated SubscriptionEntry subscriptions = 2;
+  // Consume thread count is essential if `ClientType` is `PushConsumer`.
+  optional int32 consume_thread_count = 3;
+  // Consume max batch size is essential if `ClientType` is `PushConsumer`.
+  optional int32 consume_max_batch_size = 4;
+  // Max cache message bytes is essential if `ClientType` is `PushConsumer`.
+  optional int64 max_cache_message_bytes = 5;
+  // Await duration here is essential if `ClientType` is `SimpleConsumer`.
+  optional google.protobuf.Duration simple_consumer_receive_await_duration = 6;
 }
 
-message ClientSettings {
+message ReportActiveSettingsCommand {
   string nonce = 1;
-  Direction direction = 2;
-  ClientType client_type = 3;
-  Endpoints access_point = 4;
-  Settings settings = 5;
+  ClientType client_type = 2;
+  Endpoints access_point = 3;
+  google.protobuf.Duration connection_timeout = 4;
+  bool trace_on = 5;
+  // Settings will be ignored by server if it is not match with the client type.
+  oneof settings {
+    ActivePublishingSettings active_publishing_settings = 6;
+    ActiveSubscriptionSettings active_subscription_settings = 7;
+  }
 }
 
-message ClientOverwrittenSettings {
+message ReportActiveSettingsResult { string nonce = 1; }
+
+message PassivePublishingSettings {
+  // Message is compressed if the body size exceeds the threshold.
+  int32 message_body_compression_bytes_threshold = 2;

Review Comment:
   fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org