You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Ivan Kozlov <ik...@hortonworks.com> on 2015/03/20 18:20:37 UTC
Review Request 32312: Widgets: Add schema tables for PostgreSQL,
MySQL and Oracle
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32312/
-----------------------------------------------------------
Review request for Ambari and Sid Wagle.
Repository: ambari
Description
-------
Apart from adding new widget related table definitions in the DDL script for all the three database types, also update the upgrade catalog for Amabri-2.1.0 to create these tables on ambari upgrade.
Tasks:
Create WidgetEntity and WidgetLayoutEntity.
Add relationship from both entities to cluster. This will not be used to load widgets but only to find what StackVersion to use for lookup of stack widgets when requesting WidgetInfo with layouts.
Create corresponding DAO objects with unit tests
Create findById and findBySectionName and findByCluster
Note: There is no direct relationship between the two.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntityPK.java PRE-CREATION
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a06f1d2
Diff: https://reviews.apache.org/r/32312/diff/
Testing
-------
Thanks,
Ivan Kozlov
Re: Review Request 32312: Widgets: Add schema tables for PostgreSQL,
MySQL and Oracle
Posted by Ivan Kozlov <ik...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32312/
-----------------------------------------------------------
(Updated Березень 24, 2015, 8:51 після полудня)
Review request for Ambari and Sid Wagle.
Repository: ambari
Description
-------
Apart from adding new widget related table definitions in the DDL script for all the three database types, also update the upgrade catalog for Amabri-2.1.0 to create these tables on ambari upgrade.
Tasks:
Create WidgetEntity and WidgetLayoutEntity.
Add relationship from both entities to cluster. This will not be used to load widgets but only to find what StackVersion to use for lookup of stack widgets when requesting WidgetInfo with layouts.
Create corresponding DAO objects with unit tests
Create findById and findBySectionName and findByCluster
Note: There is no direct relationship between the two.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntityPK.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5968b2f
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java PRE-CREATION
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9ff62df
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7d62aee
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 78a263f
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a06f1d2
ambari-server/src/main/resources/META-INF/persistence.xml 8c0d85f
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserWidgetDAOTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAOTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/32312/diff/
Testing
-------
Thanks,
Ivan Kozlov
Re: Review Request 32312: Widgets: Add schema tables for PostgreSQL,
MySQL and Oracle
Posted by Ivan Kozlov <ik...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32312/
-----------------------------------------------------------
(Updated Березень 23, 2015, 11:14 після полудня)
Review request for Ambari and Sid Wagle.
Repository: ambari
Description
-------
Apart from adding new widget related table definitions in the DDL script for all the three database types, also update the upgrade catalog for Amabri-2.1.0 to create these tables on ambari upgrade.
Tasks:
Create WidgetEntity and WidgetLayoutEntity.
Add relationship from both entities to cluster. This will not be used to load widgets but only to find what StackVersion to use for lookup of stack widgets when requesting WidgetInfo with layouts.
Create corresponding DAO objects with unit tests
Create findById and findBySectionName and findByCluster
Note: There is no direct relationship between the two.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntityPK.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 2df3fcf
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java 5968b2f
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java PRE-CREATION
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9ff62df
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7d62aee
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 78a263f
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a06f1d2
ambari-server/src/main/resources/META-INF/persistence.xml 8c0d85f
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UserWidgetDAOTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/WidgetLayoutDAOTest.java PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java PRE-CREATION
Diff: https://reviews.apache.org/r/32312/diff/
Testing
-------
Thanks,
Ivan Kozlov
Re: Review Request 32312: Widgets: Add schema tables for PostgreSQL,
MySQL and Oracle
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32312/#review77246
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java
<https://reviews.apache.org/r/32312/#comment125114>
Is that going to be a csv column, and hence the "%" wildcard search?
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java
<https://reviews.apache.org/r/32312/#comment125115>
Should this be non-nullable?
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
<https://reviews.apache.org/r/32312/#comment125119>
Will need these same changes in all the other DB Create.sql scripts, as well as the UpgradeCatalog.
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
<https://reviews.apache.org/r/32312/#comment125118>
This should be non null.
- Alejandro Fernandez
On March 20, 2015, 5:20 p.m., Ivan Kozlov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32312/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 5:20 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Apart from adding new widget related table definitions in the DDL script for all the three database types, also update the upgrade catalog for Amabri-2.1.0 to create these tables on ambari upgrade.
> Tasks:
> Create WidgetEntity and WidgetLayoutEntity.
> Add relationship from both entities to cluster. This will not be used to load widgets but only to find what StackVersion to use for lookup of stack widgets when requesting WidgetInfo with layouts.
> Create corresponding DAO objects with unit tests
> Create findById and findBySectionName and findByCluster
> Note: There is no direct relationship between the two.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserWidgetDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserWidgetEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutUserWidgetEntityPK.java PRE-CREATION
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql a06f1d2
>
> Diff: https://reviews.apache.org/r/32312/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ivan Kozlov
>
>