You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Duo Zhang (JIRA)" <ji...@apache.org> on 2018/03/10 04:36:00 UTC

[jira] [Commented] (HBASE-20167) Optimize the implementation of ReplicationSourceWALReader

    [ https://issues.apache.org/jira/browse/HBASE-20167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394015#comment-16394015 ] 

Duo Zhang commented on HBASE-20167:
-----------------------------------

Review board link:

https://reviews.apache.org/r/66018/

> Optimize the implementation of ReplicationSourceWALReader
> ---------------------------------------------------------
>
>                 Key: HBASE-20167
>                 URL: https://issues.apache.org/jira/browse/HBASE-20167
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: HBASE-20167.patch
>
>
> After HBASE-20148, serial replication will be an option for peer. Since an instance of ReplicationSourceWALReader can only belongs to one peer, we do not need to add the so many 'if' in the implementation of readWALEntries to check whether we should consider serial replication. We can just make a sub class or something similiar for serial replication to make the code clean.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)