[GitHub] [iceberg] stevenzwu commented on a change in pull request #3986: Flink: Fix manifest location conflict when exist more than one committer on the same taskmanager

[GitBox <gi...@apache.org>]

stevenzwu commented on a change in pull request #3986:
URL: https://github.com/apache/iceberg/pull/3986#discussion_r793238786



##########
File path: flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/sink/ManifestOutputFileFactory.java
##########
@@ -28,6 +28,7 @@
 import org.apache.iceberg.relocated.com.google.common.base.Strings;
 
 class ManifestOutputFileFactory {
+  private static final AtomicInteger fileCount = new AtomicInteger(0);

Review comment:
       I am not sure making it static is the right fix. Instead, we probably should fix the `generatePath` method and include the full table name in the path. 
   ```
     private String generatePath(long checkpointId) {
       return FileFormat.AVRO.addExtension(String.format("%s/%s-%05d-%d-%d-%05d", 
            fullTableName, flinkJobId, subTaskId,
           attemptNumber, checkpointId, fileCount.incrementAndGet()));
     }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org