You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/03/04 12:21:53 UTC
[GitHub] [dubbo-go-hessian2] wenxuwan opened a new pull request #258: draft for debug
wenxuwan opened a new pull request #258:
URL: https://github.com/apache/dubbo-go-hessian2/pull/258
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on a change in pull request #258: add unit test for big decimal in map
Posted by GitBox <gi...@apache.org>.
wongoo commented on a change in pull request #258:
URL: https://github.com/apache/dubbo-go-hessian2/pull/258#discussion_r587948941
##########
File path: map.go
##########
@@ -245,12 +245,12 @@ func (d *Decoder) decMap(flag int32) (interface{}, error) {
case tag == BC_REF:
return d.decRef(int32(tag))
case tag == BC_MAP:
- if t, err = d.decType(); err != nil {
Review comment:
should reset
##########
File path: go.mod
##########
@@ -6,3 +6,4 @@ require (
github.com/stretchr/testify v1.4.0
)
+go 1.13
Review comment:
not add go version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #258: add unit test for big decimal in map
Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #258:
URL: https://github.com/apache/dubbo-go-hessian2/pull/258#issuecomment-791066146
@wenxuwan try add the following code in serialize_test.go
```go
func TestDecimalMapJavaDecode(t *testing.T) {
var d big.Decimal
_ = d.FromString("100.256")
d.Value = d.String()
m := map[interface{}]interface{}{"test_BigDecimal": &d}
out, err := decodeJavaResponse("customReplyTypedFixedDecimalMap", "", false)
if err != nil {
t.Errorf("%#v %v", out, err)
return
}
resp := out.(map[interface{}]interface{})
assert.True(t, reflect.DeepEqual(m, resp))
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wenxuwan commented on pull request #258: add unit test for big decimal in map
Posted by GitBox <gi...@apache.org>.
wenxuwan commented on pull request #258:
URL: https://github.com/apache/dubbo-go-hessian2/pull/258#issuecomment-797177512
> @wenxuwan u can close this issue now for that fixed in #261
ok ,close now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wenxuwan closed pull request #258: add unit test for big decimal in map
Posted by GitBox <gi...@apache.org>.
wenxuwan closed pull request #258:
URL: https://github.com/apache/dubbo-go-hessian2/pull/258
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #258: add unit test for big decimal in map
Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #258:
URL: https://github.com/apache/dubbo-go-hessian2/pull/258#issuecomment-797144218
@wenxuwan u can close this issue now for that fixed in https://github.com/apache/dubbo-go-hessian2/pull/261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org