You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "wenzhenghu (via GitHub)" <gi...@apache.org> on 2026/04/13 08:42:53 UTC
[PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
wenzhenghu opened a new pull request, #62441:
URL: https://github.com/apache/doris/pull/62441
Problem Summary:
There are two critical bugs in the spill-disk feature implementation:
1. **Data Race in SpillDataDir**: In `SpillStreamManager::_get_stores_for_spill`, reading `_disk_capacity_bytes` without a lock concurrently with the GC thread updating it can lead to undefined behavior or torn reads.
2. **Memory Tracking Under-report in SpillWriter**: In `SpillWriter::_write_internal`, the memory counter increment and its paired `Defer` deduction were placed inside a nested inner scope. This caused the memory to be prematurely deducted before the synchronous, time-consuming disk I/O `_file_writer->append(buff)` occurred, leading to significant under-reporting of memory usage.
Solution:
1. Added a thread-safe `get_disk_usage` method guarded by `_mutex` in `SpillDataDir` for the pipeline worker threads to fetch capacity safely.
2. Optimized the memory tracking in `SpillWriter::_write_internal` by moving the `COUNTER_UPDATE` after the disk capacity check, and unified the memory deduction and disk metric updates into a single `Defer` block at the outer scope. This guarantees that memory is accurately tracked during I/O and simplifies the error-handling paths.
3. Added corresponding BE unit tests `SpillDataDirThreadSafety` and `SpillWriterMemoryTracking` to prevent regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4235283058
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4236735319
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4241099357
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4235342767
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4235294148
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4235282751
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4241557626
# BE UT Coverage Report
Increment line coverage `100.00% (30/30)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/aed713fe99f41b054799435676fbb7642ff5f5b2_aed713fe99f41b054799435676fbb7642ff5f5b2/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/aed713fe99f41b054799435676fbb7642ff5f5b2_aed713fe99f41b054799435676fbb7642ff5f5b2/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.04% (20135/37965) |
| Line Coverage | 36.58% (189379/517664) |
| Region Coverage | 32.84% (146994/447646) |
| Branch Coverage | 33.98% (64360/189421) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4241570224
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (30/30)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62441_aed713fe99f41b054799435676fbb7642ff5f5b2_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62441_aed713fe99f41b054799435676fbb7642ff5f5b2_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.88% (26723/37179) |
| Line Coverage | 54.89% (283273/516080) |
| Region Coverage | 51.91% (234509/451778) |
| Branch Coverage | 53.33% (101336/190003) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-6115575623
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62441:
URL: https://github.com/apache/doris/pull/62441#discussion_r3076967158
##########
be/test/exec/operator/spill_sort_source_operator_test.cpp:
##########
@@ -1196,4 +1200,71 @@ TEST_F(SpillSortSourceOperatorTest, EndToEndSinkAndSource) {
ASSERT_TRUE(st.ok());
}
+TEST_F(SpillSortSourceOperatorTest, SpillDataDirThreadSafety) {
+ // Test the thread safety of get_disk_usage and update_capacity (Bug 1)
+ std::atomic<bool> stop {false};
+
+ // Thread 1: Keep calling update_capacity
+ std::thread t1([&]() {
+ while (!stop) {
+ auto st = _helper.spill_data_dir_ptr->update_capacity();
+ EXPECT_TRUE(st.ok());
+ std::this_thread::yield();
+ }
+ });
+
+ // Thread 2: Keep calling get_disk_usage
+ std::thread t2([&]() {
+ while (!stop) {
+ double usage = _helper.spill_data_dir_ptr->get_disk_usage(1024);
+ EXPECT_GE(usage, 0.0);
+ EXPECT_LE(usage, 1.0);
+ std::this_thread::yield();
+ }
+ });
+
+ // Let them run concurrently for a short while
+ std::this_thread::sleep_for(std::chrono::milliseconds(50));
+ stop = true;
+ t1.join();
+ t2.join();
+}
+
+TEST_F(SpillSortSourceOperatorTest, SpillWriterMemoryTracking) {
+ // Test the accuracy of memory tracking in SpillFileWriter (Bug 2)
+ SpillFileSPtr spill_file;
+ auto st = ExecEnv::GetInstance()->spill_file_mgr()->create_spill_file("SpillWriterTest",
+ spill_file);
+ ASSERT_TRUE(st.ok()) << "create_spill_file failed: " << st.to_string();
+
+ SpillFileWriterSPtr writer;
+ st = spill_file->create_writer(_helper.runtime_state.get(), _helper.operator_profile.get(),
+ writer);
+ ASSERT_TRUE(st.ok());
+
+ auto* memory_used_counter = _helper.common_profile->get_counter("MemoryUsage");
+ ASSERT_TRUE(memory_used_counter != nullptr);
+
+ // We use value() directly as it is safe for all Counter types.
+ // Downcasting to HighWaterMarkCounter caused ASAN heap-buffer-overflow
+ // because MemoryUsage might be a normal Counter in the latest Profile structure.
+ int64_t initial_memory = memory_used_counter->value();
+
+ std::vector<int32_t> data(1000);
+ std::iota(data.begin(), data.end(), 0);
+ auto block = ColumnHelper::create_block<DataTypeInt32>(data);
+
Review Comment:
This does not actually prove the bug fixed in `spill_file_writer.cpp`. In the old implementation, `MemoryUsage` was decremented too early, but it was still back to `initial_memory` by the time `write_block()` returned, so this assertion would pass on both the buggy and fixed code. To make this a regression test, the test needs to observe the counter while `_file_writer->append(buff)` is still blocked/in flight (for example via a debug point or a controllable slow writer).
##########
be/src/exec/spill/spill_file_manager.h:
##########
@@ -79,8 +79,15 @@ class SpillDataDir {
std::string debug_string();
+ // get current disk usage percent in a thread-safe way
Review Comment:
This new accessor fixes one unlocked read, but the same `SpillDataDir` fields are still read without `_mutex` in `debug_string()` (called from the GC thread in `SpillFileManager::gc()`). That means the PR still leaves a data race between GC logging / `update_capacity()` and worker-thread updates like `update_spill_data_usage()` / `reach_capacity_limit()`. Please lock inside `debug_string()` or snapshot the protected fields under `_mutex` before formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4241680758
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4235038200
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4236758916
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4241680347
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4242032102
# BE UT Coverage Report
Increment line coverage `100.00% (33/33)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/933eb19eb2926d58f924df5ec6581a9216502e2c_933eb19eb2926d58f924df5ec6581a9216502e2c/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/933eb19eb2926d58f924df5ec6581a9216502e2c_933eb19eb2926d58f924df5ec6581a9216502e2c/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.03% (20135/37969) |
| Line Coverage | 36.58% (189379/517683) |
| Region Coverage | 32.83% (146974/447721) |
| Branch Coverage | 33.97% (64345/189425) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #62441: [fix](spill) fix data race in spill dir selection and memory tracking under-report
URL: https://github.com/apache/doris/pull/62441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4241001671
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4240514650
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4236730893
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4235040517
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4242559463
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (33/33)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62441_933eb19eb2926d58f924df5ec6581a9216502e2c_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62441_933eb19eb2926d58f924df5ec6581a9216502e2c_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.67% (27393/37183) |
| Line Coverage | 57.27% (295592/516099) |
| Region Coverage | 54.39% (245781/451853) |
| Branch Coverage | 56.09% (106582/190007) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4240512966
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](spill) fix data race in spill dir selection and memory tracking under-report [doris]
Posted by "wenzhenghu (via GitHub)" <gi...@apache.org>.
wenzhenghu commented on PR #62441:
URL: https://github.com/apache/doris/pull/62441#issuecomment-4240960759
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org