You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/10/24 11:14:46 UTC
[GitHub] clintropolis opened a new pull request #6512: Fix NPE in
`TaskLockbox` that prevents overlord leadership
clintropolis opened a new pull request #6512: Fix NPE in `TaskLockbox` that prevents overlord leadership
URL: https://github.com/apache/incubator-druid/pull/6512
This error prevents the overlord from assuming leadership if extension that provides indexing task related jackson modules is not loaded, causing errors such as
```
2018-10-24T00:56:46,415 ERROR [LeaderSelector[/demo/overlord/_OVERLORD]] org.apache.druid.curator.discovery.CuratorDruidLeaderSelector - listener becomeLeader() failed. Unable to become leader: {class=org.apache.druid.curator.discovery.CuratorDruidLeaderSelector, exceptionType=class java.lang.NullPointerException, exceptionMessage=null}
java.lang.NullPointerException
at org.apache.druid.indexing.overlord.TaskLockbox.syncFromStorage(TaskLockbox.java:105) ~[druid-indexing-service-0.13.0-incubating.jar:0.13.0-incubating]
at org.apache.druid.indexing.overlord.TaskMaster$1.becomeLeader(TaskMaster.java:109) ~[druid-indexing-service-0.13.0-incubating.jar:0.13.0-incubating]
at org.apache.druid.curator.discovery.CuratorDruidLeaderSelector$1.isLeader(CuratorDruidLeaderSelector.java:98) [druid-server-0.13.0-incubating.jar:0.13.0-incubating]
..
```
accompanied by:
```
2018-10-24T00:56:46,407 ERROR [LeaderSelector[/demo/overlord/_OVERLORD]] org.apache.druid.metadata.SQLMetadataStorageActionHandler - Encountered exception while deserializing task payload, setting task to null
com.fasterxml.jackson.databind.JsonMappingException: Could not resolve type id 'missingTaskType' into a subtype of [simple type, class org.apache.druid.data.input.impl.ParseSpec]: known type ids = [ParseSpec, csv, javascript, json, jsonLowercase, regex, timeAndDims, tsv]
at [Source: N/A; line: -1, column: -1] (through reference chain: org.apache.druid.data.input.impl.StringInputRowParser["parseSpec"])
at com.fasterxml.jackson.databind.JsonMappingException.from(JsonMappingException.java:148) ~[jackson-databind-2.6.7.jar:2.6.7]
at com.fasterxml.jackson.databind.DeserializationContext.unknownTypeException(DeserializationContext.java:967) ~[jackson-databind-2.6.7.jar:2.6.7]
```
This is done by filtering out `null` results from the list returned by implementations of `TaskStorage.getActiveTasks`, which are now treated as _not_ active I guess since there is nothing we can do with them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org