You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/01/21 08:03:25 UTC

[kudu-CR] docs: fix circular dependency

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/1856

to review the following change.

Change subject: docs: fix circular dependency
......................................................................

docs: fix circular dependency

After commit 3e8d29f, 'make docs' began emitting circular dependency
warnings when invoked:

  Scanning dependencies of target docs
  make[3]: Circular CMakeFiles/docs <- docs dependency dropped.
  make[3]: Circular docs <- docs dependency dropped.

The offending change was the removal of 'build' from DOCS_BUILD_DIRECTORY,
though I don't understand why. In any case, we don't need both a custom
target and command, and removing the latter fixes the circular dependency.

Change-Id: I3b2f2d874926e00b7a838977572b3288bd6156e4
---
M CMakeLists.txt
1 file changed, 3 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/1856/1
-- 
To view, visit http://gerrit.cloudera.org:8080/1856
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b2f2d874926e00b7a838977572b3288bd6156e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>