svnserve --version --foo crash / r24385

[Malcolm Rowe <ma...@farside.org.uk>]

Hi Hyrum,

In r24385, you fixed the 'svnserve --version -x' crash, and I see that
it's nominated for backport to 1.4.x.

Unfortunately, I can't seem to reproduce the original problem on 1.4.x -
it all seems to work fine.  I see the problem was originally reported
against trunk - does it even exist in 1.4.x?  (and if not, it might be
interesting to find out what caused it).

I'm also a bit confused as to why you didn't just remove the entire
os argument from the version() function rather than pass it always as
NULL?

Regards,
Malcolm

Re: svnserve --version --foo crash / r24385

["Hyrum K. Wright" <hy...@mail.utexas.edu>]

Malcolm Rowe wrote:
> On Wed, Apr 04, 2007 at 11:18:08AM +0200, Lieven Govaerts wrote:
>> The issue was reported against trunk (on IRC at least, don't know how it ended
>> up in the issue tracker). It doesn't exist on 1.4.x.
>>
> 
> Well, ah, I guess we don't need to backport it, then :-)

Quite true.  Removed from STATUS in r24416.

/me needs to check for the bug in 1.4.x before proposing backport.

-Hyrum

Re: svnserve --version --foo crash / r24385

[Malcolm Rowe <ma...@farside.org.uk>]

On Wed, Apr 04, 2007 at 11:18:08AM +0200, Lieven Govaerts wrote:
> The issue was reported against trunk (on IRC at least, don't know how it ended
> up in the issue tracker). It doesn't exist on 1.4.x.
> 

Well, ah, I guess we don't need to backport it, then :-)

Regards,
Malcolm

Re: svnserve --version --foo crash / r24385

[Lieven Govaerts <sv...@mobsol.be>]

Quoting Malcolm Rowe <ma...@farside.org.uk>:

> Hi Hyrum,
>
> In r24385, you fixed the 'svnserve --version -x' crash, and I see that
> it's nominated for backport to 1.4.x.
>
> Unfortunately, I can't seem to reproduce the original problem on 1.4.x -
> it all seems to work fine.  I see the problem was originally reported
> against trunk - does it even exist in 1.4.x?  (and if not, it might be
> interesting to find out what caused it).

The issue was reported against trunk (on IRC at least, don't know how it ended
up in the issue tracker). It doesn't exist on 1.4.x.

Lieven

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svnserve --version --foo crash / r24385

["Hyrum K. Wright" <hy...@mail.utexas.edu>]

Malcolm Rowe wrote:
...
> I'm also a bit confused as to why you didn't just remove the entire
> os argument from the version() function rather than pass it always as
> NULL?

Ah, thanks.  Arguably, the compiler will do this for us anyway, but I've
gone ahead and removed the unneeded argument in r24418.

-Hyrum