[GitHub] [maven] rfscholte commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #386:
URL: https://github.com/apache/maven/pull/386#discussion_r510301491



##########
File path: maven-xml/src/test/java/org/apache/maven/xml/sax/filter/ConsumerPomXMLFilterTest.java
##########
@@ -231,5 +234,22 @@ public void licenseHeader() throws Exception {
         String actual = transform( input );
         assertThat( actual ).and( expected ).areIdentical();
     }
+    
+    @Test
+//    @Ignore
+    public void lexicalHandler() throws Exception

Review comment:
       It tests that the lexical handler is used in both SaxSource and StreamResult. If one of both doesn't provide the lexical handler, all comments will be ignored. By default the SaxSource has no LexicalHandler, so the XMLParser will simply get elements, attributes, etc.
   
   But yes, this is now testing 2 different things. I will add a test with a minimal pom + license, that should be enough to verify if the lexicalHander is properly chained.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org