You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/12/14 14:17:53 UTC
[GitHub] [fluo-uno] DomGarguilo commented on a change in pull request #263: Fixes #262 - 'uno status' shows shell as "secret(pid)" instead of "shell(pid)"
DomGarguilo commented on a change in pull request #263:
URL: https://github.com/apache/fluo-uno/pull/263#discussion_r542417735
##########
File path: bin/impl/commands.sh
##########
@@ -300,7 +299,7 @@ function uno_fetch_main() {
function uno_wipe_main() {
local yn
uno_kill_main
- read -r -p "Are you sure you want to wipe '$INSTALL'? " yn
+ read -r -p "Are you sure you want to wipe '$INSTALL'? [Y/n] " yn
Review comment:
From personal experience it wasn't too clear to me how to proceed when first prompted. I wasn't aware that the capital letter implied the default. Do you think this should be removed entirely or is there a more appropriate "y/n/yes/no" variation that this could be changed to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org