Re: CForms in a coplet, PATCH

[Christian Mayrhuber <cm...@iicm.edu>]

On Thursday 25 March 2004 12:31, Carsten Ziegeler wrote:
> Jon Evans wrote:
> > I had another thought, the bogus links have href="#".  Is it
> > worth also coding a specific workaround to prevent it from
> > touching links with href="#"?
>
> Hmm, don't know. If the browser does not send a new request to
> resolve the anchor, yes those links should not be encoded.
>
> Carsten

See BUG: 27904
I've a fix for it.


-- 
lg, Chris

Re: CForms in a coplet, PATCH

[Christian Mayrhuber <cm...@iicm.edu>]

On Thursday 25 March 2004 15:23, Jon Evans wrote:
> Hi Christian,
>
> On 25 Mar 2004, at 12:05, Christian Mayrhuber wrote:
> > See BUG: 27904
> >  I've a fix for it.
>
> It should be easy to combine my patch with yours.
>
> I'm could rename
>
> +    /** Remembers if the current element is a remote anchor */
> +    protected Stack areRemoteAnchors;
>
> to something like
>
> +    /** Remembers if the current element is being transformed */
> +    protected Stack beingTransformed;
>
> so it can work with both anchors and "anchor classes to ignore".
>
> But, having said that, your patch on its own fixes my problem, because
> all of the problematic links produced by cforms have href="#".
>
> Carsten?

Great.
I haven't noticed your patch, because the list didn't work
for me until I tried again today.

Please do as you desire.

-- 
lg, Chris

RE: CForms in a coplet, PATCH

[Carsten Ziegeler <cz...@s-und-n.de>]

Jon Evans wrote: 
> 
> Hi Christian,
> 
> On 25 Mar 2004, at 12:05, Christian Mayrhuber wrote:
> 
> > See BUG: 27904
> >  I've a fix for it.
> 
> It should be easy to combine my patch with yours.
> 
> I'm could rename
> 
> +    /** Remembers if the current element is a remote anchor */
> +    protected Stack areRemoteAnchors;
> 
> to something like
> 
> +    /** Remembers if the current element is being transformed */
> +    protected Stack beingTransformed;
> 
> so it can work with both anchors and "anchor classes to ignore".
> 
> But, having said that, your patch on its own fixes my 
> problem, because all of the problematic links produced by 
> cforms have href="#".
> 
I will apply Christians patch. If someone/you need more functionality
(like filtering against classes etc) we can integrate it when needed.

Thanks
Carsten

Re: CForms in a coplet, PATCH

[Jon Evans <jo...@misgl.com>]

Hi Christian,

On 25 Mar 2004, at 12:05, Christian Mayrhuber wrote:

> See BUG: 27904
>  I've a fix for it.

It should be easy to combine my patch with yours.

I'm could rename

+    /** Remembers if the current element is a remote anchor */
+    protected Stack areRemoteAnchors;

to something like

+    /** Remembers if the current element is being transformed */
+    protected Stack beingTransformed;

so it can work with both anchors and "anchor classes to ignore".

But, having said that, your patch on its own fixes my problem, because 
all of the problematic links produced by cforms have href="#".

Carsten?

Jon