You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2020/02/28 12:24:09 UTC

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #327: updated dependency to 2.9.8 for jackson-core.

stevedlawrence commented on a change in pull request #327: updated dependency to 2.9.8 for jackson-core.
URL: https://github.com/apache/incubator-daffodil/pull/327#discussion_r385666824
 
 

 ##########
 File path: project/Dependencies.scala
 ##########
 @@ -34,7 +34,7 @@ object Dependencies {
   lazy val infoset = Seq(
     "org.jdom" % "jdom2" % "2.0.6",
     "com.fasterxml.woodstox" % "woodstox-core" % "5.1.0",
 
 Review comment:
   Anytime we update a dependency, we also need to update the LICENSE and NOTICE files (and also validate that the dependencies license didn't change). In this case I think just ``daffodil-cli/bin.NOTICE`` needs to be updated since we only distribute jackson code with the CLI, and it's Apache licensed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services