[jira] Commented: (AVRO-98) Make C++ parsing comply to spec

["Scott Banachowski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750083#action_12750083 ] 

Scott Banachowski commented on AVRO-98:
---------------------------------------

I've made some changes to the parser.  This allows the order of attributes in a JSON schema declaration to appear in any order, and allows for metadata attributes to appear in records and field definitions.

There was one source file added, and a couple of test schemas, so I added a script that applies the patch and does svn add commands on the new files.

After running, svn status -q reports:

M      src/c++/test/testparser.cc
M      src/c++/test/precompile.cc
M      src/c++/impl/ValidSchema.cc
M      src/c++/impl/NodeImpl.cc
M      src/c++/impl/Compiler.cc
M      src/c++/api/NodeConcepts.hh
M      src/c++/api/NodeImpl.hh
M      src/c++/api/Compiler.hh
A      src/c++/api/CompilerNode.hh
M      src/c++/parser/avro.l
M      src/c++/parser/avro.y
M      src/c++/jsonschemas/record2
A      src/c++/jsonschemas/verboseint
M      src/c++/jsonschemas/enum
A      src/c++/jsonschemas/int
A      src/c++/jsonschemas/map
M      src/c++/jsonschemas/array
M      src/c++/jsonschemas/record


> Make C++ parsing comply to spec
> -------------------------------
>
>                 Key: AVRO-98
>                 URL: https://issues.apache.org/jira/browse/AVRO-98
>             Project: Avro
>          Issue Type: Improvement
>          Components: c++
>            Reporter: Scott Banachowski
>         Attachments: applypatch98.sh, AVRO-98.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Currently the C++ parser has built in assumptions about the order of attributes, and does not allow for extra meta-data attributes.
> I have a fix for this in progress, so I'm opening the issue now (just so people know it's coming).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.