You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2023/01/13 03:28:48 UTC
[GitHub] [incubator-celeborn] FMX opened a new pull request, #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
FMX opened a new pull request, #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1072200106
##########
licenses-binary/LICENSE-protobuf.txt:
##########
@@ -1,42 +0,0 @@
-This license applies to all parts of Protocol Buffers except the following:
Review Comment:
Got it, we will add it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] WillemJiang commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1072168918
##########
.rat-excludes:
##########
@@ -19,10 +19,9 @@
**/*.json
**/*.prefs
**/*.log
-**/*.md
Review Comment:
It looks good to me now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] WillemJiang commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1072172282
##########
LICENSE-binary:
##########
@@ -269,16 +269,19 @@ org.scala-lang:scala-reflect
org.slf4j:jcl-over-slf4j
org.yaml:snakeyaml
-COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
+This project bundles the following dependencies under the CDDL 1.0 license.
+See license/LICENSE-CDDL.txt files for details.
------------
javax.servlet:javax.servlet-api
-MIT License
+The MIT License (MIT)
+See license/LICENSE-MIT.txt files for details.
Review Comment:
As the slf4j license has the copyright , we cannot replace it with the MIT License template.
##########
LICENSE-binary:
##########
@@ -269,16 +269,19 @@ org.scala-lang:scala-reflect
org.slf4j:jcl-over-slf4j
org.yaml:snakeyaml
-COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
+This project bundles the following dependencies under the CDDL 1.0 license.
+See license/LICENSE-CDDL.txt files for details.
------------
javax.servlet:javax.servlet-api
-MIT License
+The MIT License (MIT)
+See license/LICENSE-MIT.txt files for details.
------------
org.slf4j:jul-to-slf4j
org.slf4j:slf4j-api
BSD 3-clause
+See license/LICENSE-BSD-3.txt files for details.
Review Comment:
We still need to keep the leveldbjni license here, because of the copyright information.
##########
licenses-binary/LICENSE-protobuf.txt:
##########
@@ -1,42 +0,0 @@
-This license applies to all parts of Protocol Buffers except the following:
Review Comment:
If the binary artifact has the protobuf artifacts, we need to keep this license file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#issuecomment-1382683279
Are all files requires license header covered by RAT check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] WillemJiang commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1071085476
##########
.rat-excludes:
##########
@@ -19,10 +19,9 @@
**/*.json
**/*.prefs
**/*.log
-**/*.md
Review Comment:
We don't need to add the license header on the markdown file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
FMX commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1069109832
##########
NOTICE-binary:
##########
@@ -5,411 +5,88 @@ Copyright 2022-2023 The Apache Software Foundation.
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
-Apache Commons IO
-Copyright 2002-2020 The Apache Software Foundation
-
-Apache Commons Lang
-Copyright 2001-2020 The Apache Software Foundation
-
-Apache Commons Logging
-Copyright 2003-2013 The Apache Software Foundation
-
-The binary distribution of this product bundles binaries of
-org.iq80.leveldb:leveldb-api (https://github.com/dain/leveldb), which has the
-following notices:
-* Copyright 2011 Dain Sundstrom <da...@iq80.com>
-* Copyright 2011 FuseSource Corp. http://fusesource.com
-
-The binary distribution of this product bundles binaries of
-AWS SDK for Java - Bundle 1.11.375,
-AWS Java SDK for AWS KMS 1.11.375,
-AWS Java SDK for Amazon S3 1.11.375,
-AWS Java SDK for AWS STS 1.11.375,
-JMES Path Query library 1.0,
-which has the following notices:
- * This software includes third party software subject to the following
- copyrights: - XML parsing and utility functions from JetS3t - Copyright
- 2006-2009 James Murty. - JSON parsing and utility functions from JSON.org -
- Copyright 2002 JSON.org. - PKCS#1 PEM encoded private key parsing and utility
- functions from oauth.googlecode.com - Copyright 1998-2010 AOL Inc.
-
-
- The Netty Project
- =================
-
-Please visit the Netty web site for more information:
-
- * http://netty.io/
-
-Copyright 2014 The Netty Project
-
-The Netty Project licenses this file to you under the Apache License,
-version 2.0 (the "License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at:
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-License for the specific language governing permissions and limitations
-under the License.
-
-Also, please refer to each LICENSE.<component>.txt file, which is located in
-the 'license' directory of the distribution file, for the license terms of the
-components that this product depends on.
-
--------------------------------------------------------------------------------
-This product contains the extensions to Java Collections Framework which has
-been derived from the works by JSR-166 EG, Doug Lea, and Jason T. Greene:
-
- * LICENSE:
- * license/LICENSE.jsr166y.txt (Public Domain)
- * HOMEPAGE:
- * http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/
- * http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbosscache/experimental/jsr166/
-
-This product contains a modified version of Robert Harder's Public Domain
-Base64 Encoder and Decoder, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.base64.txt (Public Domain)
- * HOMEPAGE:
- * http://iharder.sourceforge.net/current/java/base64/
-
-This product contains a modified portion of 'Webbit', an event based
-WebSocket and HTTP server, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.webbit.txt (BSD License)
- * HOMEPAGE:
- * https://github.com/joewalnes/webbit
-
-This product contains a modified portion of 'SLF4J', a simple logging
-facade for Java, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.slf4j.txt (MIT License)
- * HOMEPAGE:
- * http://www.slf4j.org/
-
-This product contains a modified portion of 'ArrayDeque', written by Josh
-Bloch of Google, Inc:
-
- * LICENSE:
- * license/LICENSE.deque.txt (Public Domain)
-
-This product contains a modified portion of 'Apache Harmony', an open source
-Java SE, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.harmony.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://archive.apache.org/dist/harmony/
-
-This product contains a modified version of Roland Kuhn's ASL2
-AbstractNodeQueue, which is based on Dmitriy Vyukov's non-intrusive MPSC queue.
-It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.abstractnodequeue.txt (Public Domain)
- * HOMEPAGE:
- * https://github.com/akka/akka/blob/wip-2.2.3-for-scala-2.11/akka-actor/src/main/java/akka/dispatch/AbstractNodeQueue.java
-
-This product contains a modified portion of 'jbzip2', a Java bzip2 compression
-and decompression library written by Matthew J. Francis. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jbzip2.txt (MIT License)
- * HOMEPAGE:
- * https://code.google.com/p/jbzip2/
-
-This product contains a modified portion of 'libdivsufsort', a C API library to construct
-the suffix array and the Burrows-Wheeler transformed string for any input string of
-a constant-size alphabet written by Yuta Mori. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.libdivsufsort.txt (MIT License)
- * HOMEPAGE:
- * https://code.google.com/p/libdivsufsort/
-
-This product contains a modified portion of Nitsan Wakart's 'JCTools', Java Concurrency Tools for the JVM,
- which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jctools.txt (ASL2 License)
- * HOMEPAGE:
- * https://github.com/JCTools/JCTools
-
-This product optionally depends on 'JZlib', a re-implementation of zlib in
-pure Java, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jzlib.txt (BSD style License)
- * HOMEPAGE:
- * http://www.jcraft.com/jzlib/
-
-This product optionally depends on 'Compress-LZF', a Java library for encoding and
-decoding data in LZF format, written by Tatu Saloranta. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.compress-lzf.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/ning/compress
-
-This product optionally depends on 'lz4', a LZ4 Java compression
-and decompression library written by Adrien Grand. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.lz4.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/jpountz/lz4-java
-
-This product optionally depends on 'lzma-java', a LZMA Java compression
-and decompression library, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.lzma-java.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/jponge/lzma-java
-
-This product contains a modified portion of 'jfastlz', a Java port of FastLZ compression
-and decompression library written by William Kinney. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jfastlz.txt (MIT License)
- * HOMEPAGE:
- * https://code.google.com/p/jfastlz/
-
-This product contains a modified portion of and optionally depends on 'Protocol Buffers', Google's data
-interchange format, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.protobuf.txt (New BSD License)
- * HOMEPAGE:
- * http://code.google.com/p/protobuf/
-
-This product optionally depends on 'Bouncy Castle Crypto APIs' to generate
-a temporary self-signed X.509 certificate when the JVM does not provide the
-equivalent functionality. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.bouncycastle.txt (MIT License)
- * HOMEPAGE:
- * http://www.bouncycastle.org/
-
-This product optionally depends on 'Snappy', a compression library produced
-by Google Inc, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.snappy.txt (New BSD License)
- * HOMEPAGE:
- * http://code.google.com/p/snappy/
-
-This product contains a modified portion of UnsignedBytes LexicographicalComparator
-from Guava v21 project by Google Inc, which can be obtained at:
-
- * LICENSE:
- * license/COPYING (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/google/guava
-
-This product optionally depends on 'JBoss Marshalling', an alternative Java
-serialization API, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jboss-marshalling.txt (GNU LGPL 2.1)
- * HOMEPAGE:
- * http://www.jboss.org/jbossmarshalling
-
-This product optionally depends on 'Caliper', Google's micro-
-benchmarking framework, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.caliper.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://code.google.com/p/caliper/
-
-This product optionally depends on 'Apache Commons Logging', a logging
-framework, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.commons-logging.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://commons.apache.org/logging/
-
-This product optionally depends on 'Apache Log4J', a logging framework, which
-can be obtained at:
-
- * LICENSE:
- * license/LICENSE.log4j.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://logging.apache.org/log4j/
-
-This product optionally depends on 'Aalto XML', an ultra-high performance
-non-blocking XML processor, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.aalto-xml.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://wiki.fasterxml.com/AaltoHome
-
-This product contains a modified version of 'HPACK', a Java implementation of
-the HTTP/2 HPACK algorithm written by Twitter. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.hpack.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/twitter/hpack
-
-This product contains a modified portion of 'Apache Commons Lang', a Java library
-provides utilities for the java.lang API, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.commons-lang.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://commons.apache.org/proper/commons-lang/
-
-This product contains a modified portion of 'JDOM 1.1', which can be obtained at:
-
- * LICENSE:
- * https://github.com/hunterhacker/jdom/blob/jdom-1.1/core/LICENSE.txt
- * HOMEPAGE:
- * http://www.jdom.org/
-
-The binary distribution of this product bundles binaries of
-Commons Codec 1.4,
-which has the following notices:
- * src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.javacontains test data from http://aspell.net/test/orig/batch0.tab.Copyright (C) 2002 Kevin Atkinson (kevina@gnu.org)
- ===============================================================================
- The content of package org.apache.commons.codec.language.bm has been translated
- from the original php source code available at http://stevemorse.org/phoneticinfo.htm
- with permission from the original authors.
- Original source copyright:Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
-
-The binary distribution of this product bundles binaries of
-Commons Lang 2.6,
-which has the following notices:
- * This product includes software from the Spring Framework,under the Apache License 2.0 (see: StringUtils.containsWhitespace())
-
-The binary distribution of this product bundles binaries of
-Apache Log4j 1.2.17,
-which has the following notices:
- * ResolverUtil.java
- Copyright 2005-2006 Tim Fennell
- Dumbster SMTP test server
- Copyright 2004 Jason Paul Kitchen
- TypeUtil.java
- Copyright 2002-2012 Ramnivas Laddad, Juergen Hoeller, Chris Beams
-
-The binary distribution of this product bundles binaries of
-"Java Concurrency in Practice" book annotations 1.0,
-which has the following notices:
- * Copyright (c) 2005 Brian Goetz and Tim Peierls Released under the Creative
- Commons Attribution License (http://creativecommons.org/licenses/by/2.5)
- Official home: http://www.jcip.net Any republication or derived work
- distributed in source code form must include this copyright and license
- notice.
-
-The binary distribution of this product bundles binaries of
-Logback Classic Module 1.1.2,
-Logback Core Module 1.1.2,
-which has the following notices:
- * Logback: the reliable, generic, fast and flexible logging framework.
- Copyright (C) 1999-2012, QOS.ch. All rights reserved.
-
-The binary distribution of this product bundles binaries of
-Plexus Cipher: encryption/decryption Component 1.4,
-which has the following notices:
- * The code in this component contains a class - Base64 taken from http://juliusdavies.ca/svn/not-yet-commons-ssl/tags/commons-ssl-0.3.10/src/java/org/apache/commons/ssl/Base64.java
- which is Apache license: http://www.apache.org/licenses/LICENSE-2.0
-
- The PBE key processing routine PBECipher.createCipher() is adopted from http://juliusdavies.ca/svn/not-yet-commons-ssl/tags/commons-ssl-0.3.10/src/java/org/apache/commons/ssl/OpenSSL.java
- which is also Apache APL-2.0 license: http://www.apache.org/licenses/LICENSE-2.0
-
-The binary distribution of this product bundles binaries of
-snakeyaml (https://bitbucket.org/asomov/snakeyaml),
-which has the following notices:
- * Copyright (c) 2008, http://www.snakeyaml.org
-
-The binary distribution of this product bundles binaries of
-metrics-core 3.2.4
-which has the following notices:
- * Copyright 2010-2013 Coda Hale and Yammer, Inc.
-
- This product includes software developed by Coda Hale and Yammer, Inc.
-
- This product includes code derived from the JSR-166 project (ThreadLocalRandom, Striped64,
- LongAdder), which was released with the following comments:
-
- Written by Doug Lea with assistance from members of JCP JSR-166
- Expert Group and released to the public domain, as explained at
- http://creativecommons.org/publicdomain/zero/1.0/
-
-htrace-core4
-Copyright 2016 The Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j 1.x Compatibility API
-Copyright 1999-2022 The Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j API
-Copyright 1999-2022 The Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j Core
-Copyright 1999-2012 Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j SLF4J Binding
-Copyright 1999-2022 The Apache Software Foundation
-
-Apache Ratis Client
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Common
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis gRPC Support
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Metrics
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Netty Support
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Protocols
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Server
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Server API
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Thirdparty Miscellaneous
-Copyright 2017-2020 The Apache Software Foundation
-
----
-
-This product bundles protobuf-java which includes the following:
-
-Copyright 2008 Google Inc.
-
----
-
-This product bundles gRPC which includes the following text:
-
-Copyright 2014 The gRPC Authors
-
----
+------------------------------------------------------------------------------------
Review Comment:
Updated. How about now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
waitinfuture merged PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1072977912
##########
licenses-binary/LICENSE-protobuf.txt:
##########
@@ -1,42 +0,0 @@
-This license applies to all parts of Protocol Buffers except the following:
Review Comment:
Hi @WillemJiang ,we have addressed the issues in https://github.com/apache/incubator-celeborn/pull/1171/files, please have a check, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1072201419
##########
LICENSE-binary:
##########
@@ -269,16 +269,19 @@ org.scala-lang:scala-reflect
org.slf4j:jcl-over-slf4j
org.yaml:snakeyaml
-COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
+This project bundles the following dependencies under the CDDL 1.0 license.
+See license/LICENSE-CDDL.txt files for details.
------------
javax.servlet:javax.servlet-api
-MIT License
+The MIT License (MIT)
+See license/LICENSE-MIT.txt files for details.
Review Comment:
Got it, we will add it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX commented on pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
FMX commented on PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#issuecomment-1382684413
> Are all files requires license header covered by RAT check?
OK, I'll change rat configs to cover patch and markdown files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1072170920
##########
.rat-excludes:
##########
@@ -19,10 +19,9 @@
**/*.json
**/*.prefs
**/*.log
-**/*.md
Review Comment:
>
Thanks! We will restart the release process soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX commented on pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
FMX commented on PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#issuecomment-1382682749
> The changes LGTM, while I think we should remove the `LICENSE-leveldbjni.txt`, `LICENSE-protobuf.txt` and `LICENSE-slf4j.txt` files in the `licenses-binary` directory because the first two are BSD-3-clause license and the last is MIT license, so the files are actually duplicates.
All required changes have been done. Please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#issuecomment-1382690702
Hi @WillemJiang , could you please check if there are any further issues? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] WillemJiang commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1069106078
##########
NOTICE-binary:
##########
@@ -5,411 +5,88 @@ Copyright 2022-2023 The Apache Software Foundation.
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
-Apache Commons IO
-Copyright 2002-2020 The Apache Software Foundation
-
-Apache Commons Lang
-Copyright 2001-2020 The Apache Software Foundation
-
-Apache Commons Logging
-Copyright 2003-2013 The Apache Software Foundation
-
-The binary distribution of this product bundles binaries of
-org.iq80.leveldb:leveldb-api (https://github.com/dain/leveldb), which has the
-following notices:
-* Copyright 2011 Dain Sundstrom <da...@iq80.com>
-* Copyright 2011 FuseSource Corp. http://fusesource.com
-
-The binary distribution of this product bundles binaries of
-AWS SDK for Java - Bundle 1.11.375,
-AWS Java SDK for AWS KMS 1.11.375,
-AWS Java SDK for Amazon S3 1.11.375,
-AWS Java SDK for AWS STS 1.11.375,
-JMES Path Query library 1.0,
-which has the following notices:
- * This software includes third party software subject to the following
- copyrights: - XML parsing and utility functions from JetS3t - Copyright
- 2006-2009 James Murty. - JSON parsing and utility functions from JSON.org -
- Copyright 2002 JSON.org. - PKCS#1 PEM encoded private key parsing and utility
- functions from oauth.googlecode.com - Copyright 1998-2010 AOL Inc.
-
-
- The Netty Project
- =================
-
-Please visit the Netty web site for more information:
-
- * http://netty.io/
-
-Copyright 2014 The Netty Project
-
-The Netty Project licenses this file to you under the Apache License,
-version 2.0 (the "License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at:
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-License for the specific language governing permissions and limitations
-under the License.
-
-Also, please refer to each LICENSE.<component>.txt file, which is located in
-the 'license' directory of the distribution file, for the license terms of the
-components that this product depends on.
-
--------------------------------------------------------------------------------
-This product contains the extensions to Java Collections Framework which has
-been derived from the works by JSR-166 EG, Doug Lea, and Jason T. Greene:
-
- * LICENSE:
- * license/LICENSE.jsr166y.txt (Public Domain)
- * HOMEPAGE:
- * http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/
- * http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbosscache/experimental/jsr166/
-
-This product contains a modified version of Robert Harder's Public Domain
-Base64 Encoder and Decoder, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.base64.txt (Public Domain)
- * HOMEPAGE:
- * http://iharder.sourceforge.net/current/java/base64/
-
-This product contains a modified portion of 'Webbit', an event based
-WebSocket and HTTP server, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.webbit.txt (BSD License)
- * HOMEPAGE:
- * https://github.com/joewalnes/webbit
-
-This product contains a modified portion of 'SLF4J', a simple logging
-facade for Java, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.slf4j.txt (MIT License)
- * HOMEPAGE:
- * http://www.slf4j.org/
-
-This product contains a modified portion of 'ArrayDeque', written by Josh
-Bloch of Google, Inc:
-
- * LICENSE:
- * license/LICENSE.deque.txt (Public Domain)
-
-This product contains a modified portion of 'Apache Harmony', an open source
-Java SE, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.harmony.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://archive.apache.org/dist/harmony/
-
-This product contains a modified version of Roland Kuhn's ASL2
-AbstractNodeQueue, which is based on Dmitriy Vyukov's non-intrusive MPSC queue.
-It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.abstractnodequeue.txt (Public Domain)
- * HOMEPAGE:
- * https://github.com/akka/akka/blob/wip-2.2.3-for-scala-2.11/akka-actor/src/main/java/akka/dispatch/AbstractNodeQueue.java
-
-This product contains a modified portion of 'jbzip2', a Java bzip2 compression
-and decompression library written by Matthew J. Francis. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jbzip2.txt (MIT License)
- * HOMEPAGE:
- * https://code.google.com/p/jbzip2/
-
-This product contains a modified portion of 'libdivsufsort', a C API library to construct
-the suffix array and the Burrows-Wheeler transformed string for any input string of
-a constant-size alphabet written by Yuta Mori. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.libdivsufsort.txt (MIT License)
- * HOMEPAGE:
- * https://code.google.com/p/libdivsufsort/
-
-This product contains a modified portion of Nitsan Wakart's 'JCTools', Java Concurrency Tools for the JVM,
- which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jctools.txt (ASL2 License)
- * HOMEPAGE:
- * https://github.com/JCTools/JCTools
-
-This product optionally depends on 'JZlib', a re-implementation of zlib in
-pure Java, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jzlib.txt (BSD style License)
- * HOMEPAGE:
- * http://www.jcraft.com/jzlib/
-
-This product optionally depends on 'Compress-LZF', a Java library for encoding and
-decoding data in LZF format, written by Tatu Saloranta. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.compress-lzf.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/ning/compress
-
-This product optionally depends on 'lz4', a LZ4 Java compression
-and decompression library written by Adrien Grand. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.lz4.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/jpountz/lz4-java
-
-This product optionally depends on 'lzma-java', a LZMA Java compression
-and decompression library, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.lzma-java.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/jponge/lzma-java
-
-This product contains a modified portion of 'jfastlz', a Java port of FastLZ compression
-and decompression library written by William Kinney. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jfastlz.txt (MIT License)
- * HOMEPAGE:
- * https://code.google.com/p/jfastlz/
-
-This product contains a modified portion of and optionally depends on 'Protocol Buffers', Google's data
-interchange format, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.protobuf.txt (New BSD License)
- * HOMEPAGE:
- * http://code.google.com/p/protobuf/
-
-This product optionally depends on 'Bouncy Castle Crypto APIs' to generate
-a temporary self-signed X.509 certificate when the JVM does not provide the
-equivalent functionality. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.bouncycastle.txt (MIT License)
- * HOMEPAGE:
- * http://www.bouncycastle.org/
-
-This product optionally depends on 'Snappy', a compression library produced
-by Google Inc, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.snappy.txt (New BSD License)
- * HOMEPAGE:
- * http://code.google.com/p/snappy/
-
-This product contains a modified portion of UnsignedBytes LexicographicalComparator
-from Guava v21 project by Google Inc, which can be obtained at:
-
- * LICENSE:
- * license/COPYING (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/google/guava
-
-This product optionally depends on 'JBoss Marshalling', an alternative Java
-serialization API, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jboss-marshalling.txt (GNU LGPL 2.1)
- * HOMEPAGE:
- * http://www.jboss.org/jbossmarshalling
-
-This product optionally depends on 'Caliper', Google's micro-
-benchmarking framework, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.caliper.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://code.google.com/p/caliper/
-
-This product optionally depends on 'Apache Commons Logging', a logging
-framework, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.commons-logging.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://commons.apache.org/logging/
-
-This product optionally depends on 'Apache Log4J', a logging framework, which
-can be obtained at:
-
- * LICENSE:
- * license/LICENSE.log4j.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://logging.apache.org/log4j/
-
-This product optionally depends on 'Aalto XML', an ultra-high performance
-non-blocking XML processor, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.aalto-xml.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://wiki.fasterxml.com/AaltoHome
-
-This product contains a modified version of 'HPACK', a Java implementation of
-the HTTP/2 HPACK algorithm written by Twitter. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.hpack.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/twitter/hpack
-
-This product contains a modified portion of 'Apache Commons Lang', a Java library
-provides utilities for the java.lang API, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.commons-lang.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://commons.apache.org/proper/commons-lang/
-
-This product contains a modified portion of 'JDOM 1.1', which can be obtained at:
-
- * LICENSE:
- * https://github.com/hunterhacker/jdom/blob/jdom-1.1/core/LICENSE.txt
- * HOMEPAGE:
- * http://www.jdom.org/
-
-The binary distribution of this product bundles binaries of
-Commons Codec 1.4,
-which has the following notices:
- * src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.javacontains test data from http://aspell.net/test/orig/batch0.tab.Copyright (C) 2002 Kevin Atkinson (kevina@gnu.org)
- ===============================================================================
- The content of package org.apache.commons.codec.language.bm has been translated
- from the original php source code available at http://stevemorse.org/phoneticinfo.htm
- with permission from the original authors.
- Original source copyright:Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
-
-The binary distribution of this product bundles binaries of
-Commons Lang 2.6,
-which has the following notices:
- * This product includes software from the Spring Framework,under the Apache License 2.0 (see: StringUtils.containsWhitespace())
-
-The binary distribution of this product bundles binaries of
-Apache Log4j 1.2.17,
-which has the following notices:
- * ResolverUtil.java
- Copyright 2005-2006 Tim Fennell
- Dumbster SMTP test server
- Copyright 2004 Jason Paul Kitchen
- TypeUtil.java
- Copyright 2002-2012 Ramnivas Laddad, Juergen Hoeller, Chris Beams
-
-The binary distribution of this product bundles binaries of
-"Java Concurrency in Practice" book annotations 1.0,
-which has the following notices:
- * Copyright (c) 2005 Brian Goetz and Tim Peierls Released under the Creative
- Commons Attribution License (http://creativecommons.org/licenses/by/2.5)
- Official home: http://www.jcip.net Any republication or derived work
- distributed in source code form must include this copyright and license
- notice.
-
-The binary distribution of this product bundles binaries of
-Logback Classic Module 1.1.2,
-Logback Core Module 1.1.2,
-which has the following notices:
- * Logback: the reliable, generic, fast and flexible logging framework.
- Copyright (C) 1999-2012, QOS.ch. All rights reserved.
-
-The binary distribution of this product bundles binaries of
-Plexus Cipher: encryption/decryption Component 1.4,
-which has the following notices:
- * The code in this component contains a class - Base64 taken from http://juliusdavies.ca/svn/not-yet-commons-ssl/tags/commons-ssl-0.3.10/src/java/org/apache/commons/ssl/Base64.java
- which is Apache license: http://www.apache.org/licenses/LICENSE-2.0
-
- The PBE key processing routine PBECipher.createCipher() is adopted from http://juliusdavies.ca/svn/not-yet-commons-ssl/tags/commons-ssl-0.3.10/src/java/org/apache/commons/ssl/OpenSSL.java
- which is also Apache APL-2.0 license: http://www.apache.org/licenses/LICENSE-2.0
-
-The binary distribution of this product bundles binaries of
-snakeyaml (https://bitbucket.org/asomov/snakeyaml),
-which has the following notices:
- * Copyright (c) 2008, http://www.snakeyaml.org
-
-The binary distribution of this product bundles binaries of
-metrics-core 3.2.4
-which has the following notices:
- * Copyright 2010-2013 Coda Hale and Yammer, Inc.
-
- This product includes software developed by Coda Hale and Yammer, Inc.
-
- This product includes code derived from the JSR-166 project (ThreadLocalRandom, Striped64,
- LongAdder), which was released with the following comments:
-
- Written by Doug Lea with assistance from members of JCP JSR-166
- Expert Group and released to the public domain, as explained at
- http://creativecommons.org/publicdomain/zero/1.0/
-
-htrace-core4
-Copyright 2016 The Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j 1.x Compatibility API
-Copyright 1999-2022 The Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j API
-Copyright 1999-2022 The Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j Core
-Copyright 1999-2012 Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j SLF4J Binding
-Copyright 1999-2022 The Apache Software Foundation
-
-Apache Ratis Client
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Common
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis gRPC Support
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Metrics
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Netty Support
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Protocols
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Server
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Server API
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Thirdparty Miscellaneous
-Copyright 2017-2020 The Apache Software Foundation
-
----
-
-This product bundles protobuf-java which includes the following:
-
-Copyright 2008 Google Inc.
-
----
-
-This product bundles gRPC which includes the following text:
-
-Copyright 2014 The gRPC Authors
-
----
+------------------------------------------------------------------------------------
Review Comment:
9 to 92 lines need to be put into the License file, as they are license related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1071176306
##########
.rat-excludes:
##########
@@ -19,10 +19,9 @@
**/*.json
**/*.prefs
**/*.log
-**/*.md
Review Comment:
> We don't need to add the license header on the markdown file.
Got it, in fact the reason we add the headers is from the feedback of the original VOTE mail (https://lists.apache.org/thread/k76sopyhwrfp32mcgczfqf0086g86nro). We have deleted the headers, please have a check, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1068953633
##########
NOTICE-binary:
##########
@@ -14,6 +14,9 @@ Copyright 2001-2020 The Apache Software Foundation
Apache Commons Logging
Copyright 2003-2013 The Apache Software Foundation
+This product includes software developed by The Apache Software
+Foundation (http://www.apache.org/).
Review Comment:
it's duplicated w/ line 5-6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1068999298
##########
NOTICE-binary:
##########
@@ -5,411 +5,88 @@ Copyright 2022-2023 The Apache Software Foundation.
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
-Apache Commons IO
-Copyright 2002-2020 The Apache Software Foundation
-
-Apache Commons Lang
-Copyright 2001-2020 The Apache Software Foundation
-
-Apache Commons Logging
-Copyright 2003-2013 The Apache Software Foundation
-
-The binary distribution of this product bundles binaries of
-org.iq80.leveldb:leveldb-api (https://github.com/dain/leveldb), which has the
-following notices:
-* Copyright 2011 Dain Sundstrom <da...@iq80.com>
-* Copyright 2011 FuseSource Corp. http://fusesource.com
-
-The binary distribution of this product bundles binaries of
-AWS SDK for Java - Bundle 1.11.375,
-AWS Java SDK for AWS KMS 1.11.375,
-AWS Java SDK for Amazon S3 1.11.375,
-AWS Java SDK for AWS STS 1.11.375,
-JMES Path Query library 1.0,
-which has the following notices:
- * This software includes third party software subject to the following
- copyrights: - XML parsing and utility functions from JetS3t - Copyright
- 2006-2009 James Murty. - JSON parsing and utility functions from JSON.org -
- Copyright 2002 JSON.org. - PKCS#1 PEM encoded private key parsing and utility
- functions from oauth.googlecode.com - Copyright 1998-2010 AOL Inc.
-
-
- The Netty Project
- =================
-
-Please visit the Netty web site for more information:
-
- * http://netty.io/
-
-Copyright 2014 The Netty Project
-
-The Netty Project licenses this file to you under the Apache License,
-version 2.0 (the "License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at:
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-License for the specific language governing permissions and limitations
-under the License.
-
-Also, please refer to each LICENSE.<component>.txt file, which is located in
-the 'license' directory of the distribution file, for the license terms of the
-components that this product depends on.
-
--------------------------------------------------------------------------------
-This product contains the extensions to Java Collections Framework which has
-been derived from the works by JSR-166 EG, Doug Lea, and Jason T. Greene:
-
- * LICENSE:
- * license/LICENSE.jsr166y.txt (Public Domain)
- * HOMEPAGE:
- * http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/
- * http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbosscache/experimental/jsr166/
-
-This product contains a modified version of Robert Harder's Public Domain
-Base64 Encoder and Decoder, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.base64.txt (Public Domain)
- * HOMEPAGE:
- * http://iharder.sourceforge.net/current/java/base64/
-
-This product contains a modified portion of 'Webbit', an event based
-WebSocket and HTTP server, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.webbit.txt (BSD License)
- * HOMEPAGE:
- * https://github.com/joewalnes/webbit
-
-This product contains a modified portion of 'SLF4J', a simple logging
-facade for Java, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.slf4j.txt (MIT License)
- * HOMEPAGE:
- * http://www.slf4j.org/
-
-This product contains a modified portion of 'ArrayDeque', written by Josh
-Bloch of Google, Inc:
-
- * LICENSE:
- * license/LICENSE.deque.txt (Public Domain)
-
-This product contains a modified portion of 'Apache Harmony', an open source
-Java SE, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.harmony.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://archive.apache.org/dist/harmony/
-
-This product contains a modified version of Roland Kuhn's ASL2
-AbstractNodeQueue, which is based on Dmitriy Vyukov's non-intrusive MPSC queue.
-It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.abstractnodequeue.txt (Public Domain)
- * HOMEPAGE:
- * https://github.com/akka/akka/blob/wip-2.2.3-for-scala-2.11/akka-actor/src/main/java/akka/dispatch/AbstractNodeQueue.java
-
-This product contains a modified portion of 'jbzip2', a Java bzip2 compression
-and decompression library written by Matthew J. Francis. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jbzip2.txt (MIT License)
- * HOMEPAGE:
- * https://code.google.com/p/jbzip2/
-
-This product contains a modified portion of 'libdivsufsort', a C API library to construct
-the suffix array and the Burrows-Wheeler transformed string for any input string of
-a constant-size alphabet written by Yuta Mori. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.libdivsufsort.txt (MIT License)
- * HOMEPAGE:
- * https://code.google.com/p/libdivsufsort/
-
-This product contains a modified portion of Nitsan Wakart's 'JCTools', Java Concurrency Tools for the JVM,
- which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jctools.txt (ASL2 License)
- * HOMEPAGE:
- * https://github.com/JCTools/JCTools
-
-This product optionally depends on 'JZlib', a re-implementation of zlib in
-pure Java, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jzlib.txt (BSD style License)
- * HOMEPAGE:
- * http://www.jcraft.com/jzlib/
-
-This product optionally depends on 'Compress-LZF', a Java library for encoding and
-decoding data in LZF format, written by Tatu Saloranta. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.compress-lzf.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/ning/compress
-
-This product optionally depends on 'lz4', a LZ4 Java compression
-and decompression library written by Adrien Grand. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.lz4.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/jpountz/lz4-java
-
-This product optionally depends on 'lzma-java', a LZMA Java compression
-and decompression library, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.lzma-java.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/jponge/lzma-java
-
-This product contains a modified portion of 'jfastlz', a Java port of FastLZ compression
-and decompression library written by William Kinney. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jfastlz.txt (MIT License)
- * HOMEPAGE:
- * https://code.google.com/p/jfastlz/
-
-This product contains a modified portion of and optionally depends on 'Protocol Buffers', Google's data
-interchange format, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.protobuf.txt (New BSD License)
- * HOMEPAGE:
- * http://code.google.com/p/protobuf/
-
-This product optionally depends on 'Bouncy Castle Crypto APIs' to generate
-a temporary self-signed X.509 certificate when the JVM does not provide the
-equivalent functionality. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.bouncycastle.txt (MIT License)
- * HOMEPAGE:
- * http://www.bouncycastle.org/
-
-This product optionally depends on 'Snappy', a compression library produced
-by Google Inc, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.snappy.txt (New BSD License)
- * HOMEPAGE:
- * http://code.google.com/p/snappy/
-
-This product contains a modified portion of UnsignedBytes LexicographicalComparator
-from Guava v21 project by Google Inc, which can be obtained at:
-
- * LICENSE:
- * license/COPYING (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/google/guava
-
-This product optionally depends on 'JBoss Marshalling', an alternative Java
-serialization API, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.jboss-marshalling.txt (GNU LGPL 2.1)
- * HOMEPAGE:
- * http://www.jboss.org/jbossmarshalling
-
-This product optionally depends on 'Caliper', Google's micro-
-benchmarking framework, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.caliper.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://code.google.com/p/caliper/
-
-This product optionally depends on 'Apache Commons Logging', a logging
-framework, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.commons-logging.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://commons.apache.org/logging/
-
-This product optionally depends on 'Apache Log4J', a logging framework, which
-can be obtained at:
-
- * LICENSE:
- * license/LICENSE.log4j.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://logging.apache.org/log4j/
-
-This product optionally depends on 'Aalto XML', an ultra-high performance
-non-blocking XML processor, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.aalto-xml.txt (Apache License 2.0)
- * HOMEPAGE:
- * http://wiki.fasterxml.com/AaltoHome
-
-This product contains a modified version of 'HPACK', a Java implementation of
-the HTTP/2 HPACK algorithm written by Twitter. It can be obtained at:
-
- * LICENSE:
- * license/LICENSE.hpack.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://github.com/twitter/hpack
-
-This product contains a modified portion of 'Apache Commons Lang', a Java library
-provides utilities for the java.lang API, which can be obtained at:
-
- * LICENSE:
- * license/LICENSE.commons-lang.txt (Apache License 2.0)
- * HOMEPAGE:
- * https://commons.apache.org/proper/commons-lang/
-
-This product contains a modified portion of 'JDOM 1.1', which can be obtained at:
-
- * LICENSE:
- * https://github.com/hunterhacker/jdom/blob/jdom-1.1/core/LICENSE.txt
- * HOMEPAGE:
- * http://www.jdom.org/
-
-The binary distribution of this product bundles binaries of
-Commons Codec 1.4,
-which has the following notices:
- * src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.javacontains test data from http://aspell.net/test/orig/batch0.tab.Copyright (C) 2002 Kevin Atkinson (kevina@gnu.org)
- ===============================================================================
- The content of package org.apache.commons.codec.language.bm has been translated
- from the original php source code available at http://stevemorse.org/phoneticinfo.htm
- with permission from the original authors.
- Original source copyright:Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
-
-The binary distribution of this product bundles binaries of
-Commons Lang 2.6,
-which has the following notices:
- * This product includes software from the Spring Framework,under the Apache License 2.0 (see: StringUtils.containsWhitespace())
-
-The binary distribution of this product bundles binaries of
-Apache Log4j 1.2.17,
-which has the following notices:
- * ResolverUtil.java
- Copyright 2005-2006 Tim Fennell
- Dumbster SMTP test server
- Copyright 2004 Jason Paul Kitchen
- TypeUtil.java
- Copyright 2002-2012 Ramnivas Laddad, Juergen Hoeller, Chris Beams
-
-The binary distribution of this product bundles binaries of
-"Java Concurrency in Practice" book annotations 1.0,
-which has the following notices:
- * Copyright (c) 2005 Brian Goetz and Tim Peierls Released under the Creative
- Commons Attribution License (http://creativecommons.org/licenses/by/2.5)
- Official home: http://www.jcip.net Any republication or derived work
- distributed in source code form must include this copyright and license
- notice.
-
-The binary distribution of this product bundles binaries of
-Logback Classic Module 1.1.2,
-Logback Core Module 1.1.2,
-which has the following notices:
- * Logback: the reliable, generic, fast and flexible logging framework.
- Copyright (C) 1999-2012, QOS.ch. All rights reserved.
-
-The binary distribution of this product bundles binaries of
-Plexus Cipher: encryption/decryption Component 1.4,
-which has the following notices:
- * The code in this component contains a class - Base64 taken from http://juliusdavies.ca/svn/not-yet-commons-ssl/tags/commons-ssl-0.3.10/src/java/org/apache/commons/ssl/Base64.java
- which is Apache license: http://www.apache.org/licenses/LICENSE-2.0
-
- The PBE key processing routine PBECipher.createCipher() is adopted from http://juliusdavies.ca/svn/not-yet-commons-ssl/tags/commons-ssl-0.3.10/src/java/org/apache/commons/ssl/OpenSSL.java
- which is also Apache APL-2.0 license: http://www.apache.org/licenses/LICENSE-2.0
-
-The binary distribution of this product bundles binaries of
-snakeyaml (https://bitbucket.org/asomov/snakeyaml),
-which has the following notices:
- * Copyright (c) 2008, http://www.snakeyaml.org
-
-The binary distribution of this product bundles binaries of
-metrics-core 3.2.4
-which has the following notices:
- * Copyright 2010-2013 Coda Hale and Yammer, Inc.
-
- This product includes software developed by Coda Hale and Yammer, Inc.
-
- This product includes code derived from the JSR-166 project (ThreadLocalRandom, Striped64,
- LongAdder), which was released with the following comments:
-
- Written by Doug Lea with assistance from members of JCP JSR-166
- Expert Group and released to the public domain, as explained at
- http://creativecommons.org/publicdomain/zero/1.0/
-
-htrace-core4
-Copyright 2016 The Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j 1.x Compatibility API
-Copyright 1999-2022 The Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j API
-Copyright 1999-2022 The Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j Core
-Copyright 1999-2012 Apache Software Foundation
-
-This product includes software developed at
-The Apache Software Foundation (http://www.apache.org/).
-
-Apache Log4j SLF4J Binding
-Copyright 1999-2022 The Apache Software Foundation
-
-Apache Ratis Client
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Common
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis gRPC Support
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Metrics
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Netty Support
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Protocols
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Server
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Server API
-Copyright 2017-2020 The Apache Software Foundation
-
-Apache Ratis Thirdparty Miscellaneous
-Copyright 2017-2020 The Apache Software Foundation
-
----
-
-This product bundles protobuf-java which includes the following:
-
-Copyright 2008 Google Inc.
-
----
-
-This product bundles gRPC which includes the following text:
-
-Copyright 2014 The gRPC Authors
-
----
+------------------------------------------------------------------------------------
Review Comment:
Not sure if it's the proper way, but I think it's OK if we respect what Apache Flink does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1164: [CELEBORN-224] Correct LICENSE and NOTICE.
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on code in PR #1164:
URL: https://github.com/apache/incubator-celeborn/pull/1164#discussion_r1072199837
##########
LICENSE-binary:
##########
@@ -269,16 +269,19 @@ org.scala-lang:scala-reflect
org.slf4j:jcl-over-slf4j
org.yaml:snakeyaml
-COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0
+This project bundles the following dependencies under the CDDL 1.0 license.
+See license/LICENSE-CDDL.txt files for details.
------------
javax.servlet:javax.servlet-api
-MIT License
+The MIT License (MIT)
+See license/LICENSE-MIT.txt files for details.
------------
org.slf4j:jul-to-slf4j
org.slf4j:slf4j-api
BSD 3-clause
+See license/LICENSE-BSD-3.txt files for details.
Review Comment:
Got it, we will add it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org