You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/16 20:50:56 UTC
[GitHub] [incubator-nuttx] Mayerch1 opened a new pull request #2551: fix: arch/.../stm32h7x3xx_memorymap.h invalid address map for fdcan
Mayerch1 opened a new pull request #2551:
URL: https://github.com/apache/incubator-nuttx/pull/2551
## Summary
The used register layout defined in arch/arm/src/stm32h7/hardware/stm32h7x3xx_memorymap.h is not matching the documentation.
The reference manual [RM0433](https://www.st.com/resource/en/reference_manual/dm00314099-stm32h742-stm32h743-753-and-stm32h750-value-line-advanced-arm-based-32-bit-mcus-stmicroelectronics.pdf) on page 134/3319 states following addresses
* MDIOS 0x40009400
* FDCAN1 0x4000A000
The source code does not match this specification, however the comment next to it is stating the correct addresses.
I corrected both addresses, aswell as an invalid comment for `CRS_BASE` (where the define is valid, but not the comment).
(I'm not sure if I should have created an issue first/in parallel, but making the changes myself was just as fast, as I needed them anyway)
## Impact
The `MDIOS_BASE` is not used throughout NuttX (checked by full-text search) and the CAN-FD driver is not implemented yet.
Therefore this change has no effect to the current software, but prevents hidden errors on an eventual implementation of a CAN-FD driver caused by an invalid address map.
## Testing
Using the newly assigned address (`FDCAN1_BASE`) in a minimal CAN-FD driver functions as desired.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2551: fix: arch/.../stm32h7x3xx_memorymap.h invalid address map for fdcan
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2551:
URL: https://github.com/apache/incubator-nuttx/pull/2551
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org