You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jcesarmobile <gi...@git.apache.org> on 2016/07/30 20:50:52 UTC
[GitHub] cordova-ios pull request #239: CB-11648: Make CDVViewController send notific...
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-ios/pull/239
CB-11648: Make CDVViewController send notifications
Make CDVViewController to send notifications when UIViewController methods are called
Added notifications for
viewWillAppear
viewDidAppear
viewWillDisappear
viewDidDisappear
viewWillLayoutSubviews
viewDidLayoutSubviews
viewWillTransitionToSize
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-ios CB-11648
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/239.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #239
----
commit b1ed8b0869f1ae1c169ec688e0ca5390d60dc0cd
Author: Julio C�sar <jc...@gmail.com>
Date: 2016-07-30T20:48:57Z
CB-11648: Make CDVViewController send notifications when UIViewController methods are called
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #239: CB-11648: Make CDVViewController send notific...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/239
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #239: CB-11648: Make CDVViewController send notifications
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/239
LGTM. Passes all local tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #239: CB-11648: Make CDVViewController send notifications
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/239
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/239?src=pr) is 51.81% (diff: 100%)
> Merging [#239](https://codecov.io/gh/apache/cordova-ios/pull/239?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage
```diff
@@ master #239 diff @@
==========================================
Files 11 11
Lines 882 882
Methods 132 132
Messages 0 0
Branches 143 143
==========================================
Hits 457 457
Misses 425 425
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [debd4c6...b1ed8b0](https://codecov.io/gh/apache/cordova-ios/compare/debd4c69e7c08f418a02ee5671f7a87ea0511004...b1ed8b0869f1ae1c169ec688e0ca5390d60dc0cd?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org