You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@airflow.apache.org by Sid Anand <sa...@apache.org> on 2018/03/04 00:59:47 UTC
Re: Merging PRs, closing Jira tickets (a.k.a New Committer) guide?
Hi Ash,
Welcome aboard.
Firstly, I'm moving this conversation over to the dev list -- the first
lesson we all learned at the insistence of the incubator mentors was to use
the private list for voting and discussion on PMC matters. They require
that all information-oriented discussions be routed to the dev-list.
*Merging PRs:*
To merge a PR, you can use a very handy tool written by @jlowin
<https://github.com/jlowin> : https://github.com/apache/
incubator-airflow/blob/master/dev/airflow-pr
It's pretty self-explanatory. Essentially, you follow the instructions in
the tool -- the result is that the PR will be merged to Apache
<https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and then
synced (mirrored) to https://github.com/apache/incubator-airflow. The
Apache mirror runs on apache infrastructure and is the source of truth
(rules of apache). The mirror <https://github.com/apache/incubator-airflow>
is what we all see.. there can sometimes be a delay of a minute before the
PR you merged shows up in the commit history on git hub, but it's usually
under 10 seconds.
We document the tool on the Committer Guide
<https://cwiki.apache.org/confluence/display/AIRFLOW/Committers%27+Guide>.
*Releases:*
As I haven't done a release yet, I'll defer to Bolke and Chris who most
recently did releases to point you to documentation.
*Jira Role:*
I've added you to the Admin, PMC, Committers, and ASF Members roles. I
believe you don't need them to edit or close and JIRAs. I had requested
anyone be able to open, edit, or close JIRAs, so if that's not the case, it
would be good to know.
*GitHub:*
Can you try merging a PR? That would be an indication that you have the
necc perms.
*Other Questions*:
Q1:"I understand that the process for making changes now I'm a committer is
the same as before: I should open a PR+Jira and get it approved by another
committer. Is this correct?"
A1: You are correct!
Hope this helps!
-s
P.S.
BTW, I'll be in London from tomorrow (landing at noon) till the following
Friday -- I co-chair QCon London and usually find myself there around this
time every year. Feel free to drop me a line if you happen to be in the
area.
On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org> wrote:
> Hi Everyone!
>
> Thanks for inviting me to join the Airflow PPMC!
>
> An introduction: I live and work in London, I'm currently working for the
> data group of a large advertising company, though I will be going on
> paternity leave for 3 months any day now as my wife is pregnant with our
> first child. (Eeee!)
>
> I have some questions :)
>
> How to I merge PRs? From the outside it appears that the merge happens in
> an apache repo and is somehow automatically replicated into github. Is
> there a guide on the workflow to do this? What credentials do I use for
> apache git?
>
> Is the branching process for releases or it is it a loose convention up to
> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test etc.) If
> we wanted to release a 1.9.1 with some fixes what might the process be?
>
> Can someone grant my Jira user (ashb) permission to edit/close tickets?
>
> Ditto for github (ashb)?
>
> I understand that the process for making changes now I'm a committer is
> the same as before: I should open a PR+Jira and get it approved by another
> committer. Is this correct?
>
> Is there anything else I should know but don't know about to ask? :)
>
> Thanks,
> Ash
Re: Merging PRs, closing Jira tickets (a.k.a New Committer) guide?
Posted by Maxime Beauchemin <ma...@gmail.com>.
Hi Ash,
Welcome on board and congrats on the baby!
About releasing, 1.9.1 would be a great initiative as we need to show good
release cadence to graduate out of incubation (this may be the last item on
the checklist isn't it @committers?). You can find some information here:
https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Release+Planning+and+Supported+Release+Lifetime
. One of the first step is probably to identify some of the JIRAs that
should target 1.9.1, and perhaps starting a release thread to the mailing
list. There's a field in JIRA ticket to set the target release that you can
use and tooling to help syncing branches (thanks Bolke!). 3 of us have gone
through the process already and a "dot-release" (1.9.1) shouldn't be as
involved as a a mid-number release (1.10.0).
If you're familiar with release-type workflows (cutting branches, picking
cherries, packaging&signing bins) the process is pretty straightforward, if
you're not very familiar with that kind of process then it's a great
opportunity to learn.
Max
On Sat, Mar 3, 2018 at 4:59 PM, Sid Anand <sa...@apache.org> wrote:
> Hi Ash,
> Welcome aboard.
>
> Firstly, I'm moving this conversation over to the dev list -- the first
> lesson we all learned at the insistence of the incubator mentors was to use
> the private list for voting and discussion on PMC matters. They require
> that all information-oriented discussions be routed to the dev-list.
>
> *Merging PRs:*
> To merge a PR, you can use a very handy tool written by @jlowin
> <https://github.com/jlowin> : https://github.com/apache/
> incubator-airflow/blob/master/dev/airflow-pr
>
> It's pretty self-explanatory. Essentially, you follow the instructions in
> the tool -- the result is that the PR will be merged to Apache
> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and then
> synced (mirrored) to https://github.com/apache/incubator-airflow. The
> Apache mirror runs on apache infrastructure and is the source of truth
> (rules of apache). The mirror <https://github.com/apache/incubator-airflow
> >
> is what we all see.. there can sometimes be a delay of a minute before the
> PR you merged shows up in the commit history on git hub, but it's usually
> under 10 seconds.
>
> We document the tool on the Committer Guide
> <https://cwiki.apache.org/confluence/display/AIRFLOW/Committers%27+Guide>.
>
> *Releases:*
> As I haven't done a release yet, I'll defer to Bolke and Chris who most
> recently did releases to point you to documentation.
>
> *Jira Role:*
> I've added you to the Admin, PMC, Committers, and ASF Members roles. I
> believe you don't need them to edit or close and JIRAs. I had requested
> anyone be able to open, edit, or close JIRAs, so if that's not the case, it
> would be good to know.
>
> *GitHub:*
> Can you try merging a PR? That would be an indication that you have the
> necc perms.
>
> *Other Questions*:
> Q1:"I understand that the process for making changes now I'm a committer is
> the same as before: I should open a PR+Jira and get it approved by another
> committer. Is this correct?"
> A1: You are correct!
>
> Hope this helps!
> -s
>
> P.S.
> BTW, I'll be in London from tomorrow (landing at noon) till the following
> Friday -- I co-chair QCon London and usually find myself there around this
> time every year. Feel free to drop me a line if you happen to be in the
> area.
>
> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org> wrote:
>
> > Hi Everyone!
> >
> > Thanks for inviting me to join the Airflow PPMC!
> >
> > An introduction: I live and work in London, I'm currently working for the
> > data group of a large advertising company, though I will be going on
> > paternity leave for 3 months any day now as my wife is pregnant with our
> > first child. (Eeee!)
> >
> > I have some questions :)
> >
> > How to I merge PRs? From the outside it appears that the merge happens in
> > an apache repo and is somehow automatically replicated into github. Is
> > there a guide on the workflow to do this? What credentials do I use for
> > apache git?
> >
> > Is the branching process for releases or it is it a loose convention up
> to
> > the Release Manager for that release? (i.e. v1-9-stable, v1-9-test etc.)
> If
> > we wanted to release a 1.9.1 with some fixes what might the process be?
> >
> > Can someone grant my Jira user (ashb) permission to edit/close tickets?
> >
> > Ditto for github (ashb)?
> >
> > I understand that the process for making changes now I'm a committer is
> > the same as before: I should open a PR+Jira and get it approved by
> another
> > committer. Is this correct?
> >
> > Is there anything else I should know but don't know about to ask? :)
> >
> > Thanks,
> > Ash
>
Re: Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a
New Committer) guide?
Posted by Ash Berlin-Taylor <as...@firemirror.com>.
An update on this: I opened the ticket with the Apache Infra team but have had no response or movement on it yet, so I don't know how long it might take
https://issues.apache.org/jira/browse/INFRA-16602 <https://issues.apache.org/jira/browse/INFRA-16602>
The status is "waiting on infra"
¯\_(ツ)_/¯
-ash
> On 24 May 2018, at 16:30, Ash Berlin-Taylor <as...@firemirror.com> wrote:
>
> Found some time, opened a PR: https://github.com/apache/incubator-airflow/pull/3413 <https://github.com/apache/incubator-airflow/pull/3413>
>
> Commiters:
>
> - Go to https://id.apache.org/ <https://id.apache.org/> and check that you have a GitHub username listed. Once you add it you'll get an invite on Github you need to accept.
> - Then go to https://gitbox.apache.org/setup/ <https://gitbox.apache.org/setup/> and follow through the steps on that page.
>
> Once we've done this you should be able to commit to the github repo, once we get the Apache Infra team to migrate the repo for us. I'll open a ticket for this early next week.
>
> -ash
>
>> On 23 May 2018, at 19:04, Sid Anand <sa...@apache.org> wrote:
>>
>> Welcome back Ash! Firstly, it was great meeting you in person in London in
>> March, right before you went on Paternity Leave. Hope you are getting some
>> sleep :-)
>>
>>
>> -s
>>
>> On Wed, May 23, 2018 at 1:44 AM, Ash Berlin-Taylor <as...@firemirror.com>
>> wrote:
>>
>>> Clearing :)
>>>
>>> I've gotten as far as having the tab with this Jira issue open again.
>>> Which is progress :)
>>>
>>> I've been back at work for a week, so things are getting less hectic both
>>> at home and at work, so I should be able to find time for this this week or
>>> next. If someone picks it up before I get to it I won't be upset :)
>>>
>>> -ash
>>>
>>>> On 22 May 2018, at 23:20, Driesprong, Fokko <fo...@driesprong.frl>
>>> wrote:
>>>>
>>>> Are we moving to Gitbox? I would really like that. I see a lot of other
>>>> project moving to Gitbox at the moment (Flink, Parquet). How's your
>>>> schedule Ash? ;)
>>>>
>>>> Cheers, Fokko
>>>>
>>>> 2018-03-09 18:53 GMT+01:00 Bolke de Bruin <bd...@gmail.com>:
>>>>
>>>>> I would love to be able to close PRs on GitHub, but personally I’m quite
>>>>> ok with JIRA. GitHub issues tend to get messy imho. I also like that it
>>> is
>>>>> clear from the subject of Pr what the associated issues was, since we
>>> moved
>>>>> history became a lot cleaner and changelogs are now easy to generate.
>>>>>
>>>>> My 2cents
>>>>>
>>>>> B.
>>>>>
>>>>> Verstuurd vanaf mijn iPad
>>>>>
>>>>>> Op 9 mrt. 2018 om 18:01 heeft Ash Berlin-Taylor <as...@firemirror.com>
>>>>> het volgende geschreven:
>>>>>>
>>>>>> That sounds like it is at worth me at least coming up a proposal for us
>>>>> to vote on then..
>>>>>>
>>>>>> One thing that might help with the "target version" is multiple Github
>>>>> Projects[1]: -- that, or labels, are the only way for a github issue to
>>> be
>>>>> in "two" groups at the same time.
>>>>>>
>>>>>> I'll see what I can do, but make zero promises due to imminent
>>>>> baby-driven "sleep" schedule ;)
>>>>>>
>>>>>> [1]: https://help.github.com/articles/about-project-boards/
>>>>>>
>>>>>>
>>>>>>> On 9 Mar 2018, at 16:10, Maxime Beauchemin <
>>> maximebeauchemin@gmail.com>
>>>>> wrote:
>>>>>>>
>>>>>>> We use Gitbox and no Jira for Apache Superset and are happy with it.
>>>>>>>
>>>>>>> One downside is around the current release management tooling for
>>>>> Airflow
>>>>>>> has bindings with Jira and the "target version" field.
>>>>>>>
>>>>>>> Max
>>>>>>>
>>>>>>> On Thu, Mar 8, 2018 at 6:31 AM, Ash Berlin-Taylor <
>>>>>>> ash_airflowlist@firemirror.com> wrote:
>>>>>>>
>>>>>>>> I've done a bit of digging and there's an Apache "project" called
>>>>>>>> gitbox[1] that, if we choose to go that way lets us use Github more
>>>>>>>> "natively".
>>>>>>>>
>>>>>>>> The BookKeeper project migrated to using Github exclusively lsat
>>> Jun[2]
>>>>>>>> and from the looks of their Github repo are still using this
>>> approach,
>>>>> and
>>>>>>>> their Jira is read only. Their proposal on the migration was
>>>>>>>> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
>>>>>>>> BP-9+-+Github+issues+for+Issue+Tracking
>>>>>>>>
>>>>>>>> I think there are three ways we could go:
>>>>>>>>
>>>>>>>> 1. Nothing changes, we stay as we are and commit to the ASF git repo.
>>>>>>>> 2. Move to Gitbox and commit directly to githb, keep issues in Jira.
>>>>>>>> 3. Do as BookKeeper did and move to using Github Issues as well as
>>>>> Gitub
>>>>>>>> for the repo.
>>>>>>>>
>>>>>>>> Is there interest from anyone else in 2 or 3, if so I will attempt to
>>>>> draw
>>>>>>>> up a more detailed proposal.
>>>>>>>>
>>>>>>>> [1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv
>>>>>>>> [2]: http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/
>>>>> 201706.mbox/%
>>>>>>>> 3CCAO2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%4
>>> 0mail.gmail.com
>>>>> %3E
>>>>>>>>
>>>>>>>>
>>>>>>>>> On 6 Mar 2018, at 09:57, Ash Berlin-Taylor
>>>>> <ash_airflowlist@firemirror.
>>>>>>>> com> wrote:
>>>>>>>>>
>>>>>>>>> Ah that would explain why I don't have a button :)
>>>>>>>>>
>>>>>>>>> Is this Apache policy, or is it possible for committers to be
>>> granted
>>>>>>>> permission to do this? Having this permission would also let us click
>>>>> the
>>>>>>>> "rerun tests" button in Travis which would be nice.
>>>>>>>>>
>>>>>>>>> Is it worth opening an INFRA ticket asking for this, or is it not
>>>>>>>> possible?
>>>>>>>>>
>>>>>>>>> -ash
>>>>>>>>>
>>>>>>>>>> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl>
>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi Ash,
>>>>>>>>>>
>>>>>>>>>> As a committer we don't have any rights on the Github itself. The
>>>>> Github
>>>>>>>>>> repo is just a sync of the apache repo. Unfortunately, therefore we
>>>>>>>> don't
>>>>>>>>>> have the right to close any PR.
>>>>>>>>>>
>>>>>>>>>> Cheers, Fokko
>>>>>>>>>>
>>>>>>>>>> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <
>>>>>>>> ash_airflowlist@firemirror.com>
>>>>>>>>>> :
>>>>>>>>>>
>>>>>>>>>>> I've merged two PRs now, and the second one seemed to be better
>>>>>>>> (though I
>>>>>>>>>>> did have some trouble with the tool not merging properly and I
>>>>> needed
>>>>>>>> to
>>>>>>>>>>> manually coax git. Hmm)
>>>>>>>>>>>
>>>>>>>>>>> Jira: I _think_ that previously I could only comment on Jira
>>> issues.
>>>>>>>> With
>>>>>>>>>>> the new permissions I can now do more (as those of you subscribed
>>> to
>>>>>>>> the
>>>>>>>>>>> commit list will see) -- I started going through old Jira tickets
>>>>> and
>>>>>>>>>>> closing ones that are no longer an issue or that were fixed+merged
>>>>> but
>>>>>>>> not
>>>>>>>>>>> closed.
>>>>>>>>>>>
>>>>>>>>>>> Github: I don't have a button to close PRs in Github - Is that
>>>>>>>> expected?
>>>>>>>>>>>
>>>>>>>>>>> -ash
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> Hi Ash,
>>>>>>>>>>>> Welcome aboard.
>>>>>>>>>>>>
>>>>>>>>>>>> Firstly, I'm moving this conversation over to the dev list -- the
>>>>>>>> first
>>>>>>>>>>>> lesson we all learned at the insistence of the incubator mentors
>>>>> was
>>>>>>>> to
>>>>>>>>>>> use
>>>>>>>>>>>> the private list for voting and discussion on PMC matters. They
>>>>>>>> require
>>>>>>>>>>>> that all information-oriented discussions be routed to the
>>>>> dev-list.
>>>>>>>>>>>>
>>>>>>>>>>>> *Merging PRs:*
>>>>>>>>>>>> To merge a PR, you can use a very handy tool written by @jlowin
>>>>>>>>>>>> <https://github.com/jlowin> : https://github.com/apache/
>>>>>>>>>>>> incubator-airflow/blob/master/dev/airflow-pr
>>>>>>>>>>>>
>>>>>>>>>>>> It's pretty self-explanatory. Essentially, you follow the
>>>>>>>> instructions in
>>>>>>>>>>>> the tool -- the result is that the PR will be merged to Apache
>>>>>>>>>>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git>
>>>>> and
>>>>>>>> then
>>>>>>>>>>>> synced (mirrored) to https://github.com/apache/incubator-airflow
>>> .
>>>>> The
>>>>>>>>>>>> Apache mirror runs on apache infrastructure and is the source of
>>>>> truth
>>>>>>>>>>>> (rules of apache). The mirror <https://github.com/apache/
>>>>>>>>>>> incubator-airflow>
>>>>>>>>>>>> is what we all see.. there can sometimes be a delay of a minute
>>>>> before
>>>>>>>>>>> the
>>>>>>>>>>>> PR you merged shows up in the commit history on git hub, but it's
>>>>>>>> usually
>>>>>>>>>>>> under 10 seconds.
>>>>>>>>>>>>
>>>>>>>>>>>> We document the tool on the Committer Guide
>>>>>>>>>>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/
>>>>>>>> Committers%27+Guide
>>>>>>>>>>>> .
>>>>>>>>>>>>
>>>>>>>>>>>> *Releases:*
>>>>>>>>>>>> As I haven't done a release yet, I'll defer to Bolke and Chris
>>> who
>>>>>>>> most
>>>>>>>>>>>> recently did releases to point you to documentation.
>>>>>>>>>>>>
>>>>>>>>>>>> *Jira Role:*
>>>>>>>>>>>> I've added you to the Admin, PMC, Committers, and ASF Members
>>>>> roles. I
>>>>>>>>>>>> believe you don't need them to edit or close and JIRAs. I had
>>>>>>>> requested
>>>>>>>>>>>> anyone be able to open, edit, or close JIRAs, so if that's not
>>> the
>>>>>>>> case,
>>>>>>>>>>> it
>>>>>>>>>>>> would be good to know.
>>>>>>>>>>>>
>>>>>>>>>>>> *GitHub:*
>>>>>>>>>>>> Can you try merging a PR? That would be an indication that you
>>> have
>>>>>>>> the
>>>>>>>>>>>> necc perms.
>>>>>>>>>>>>
>>>>>>>>>>>> *Other Questions*:
>>>>>>>>>>>> Q1:"I understand that the process for making changes now I'm a
>>>>>>>> committer
>>>>>>>>>>> is
>>>>>>>>>>>> the same as before: I should open a PR+Jira and get it approved
>>> by
>>>>>>>>>>> another
>>>>>>>>>>>> committer. Is this correct?"
>>>>>>>>>>>> A1: You are correct!
>>>>>>>>>>>>
>>>>>>>>>>>> Hope this helps!
>>>>>>>>>>>> -s
>>>>>>>>>>>>
>>>>>>>>>>>> P.S.
>>>>>>>>>>>> BTW, I'll be in London from tomorrow (landing at noon) till the
>>>>>>>> following
>>>>>>>>>>>> Friday -- I co-chair QCon London and usually find myself there
>>>>> around
>>>>>>>>>>> this
>>>>>>>>>>>> time every year. Feel free to drop me a line if you happen to be
>>> in
>>>>>>>> the
>>>>>>>>>>>> area.
>>>>>>>>>>>>
>>>>>>>>>>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <
>>> ash@apache.org>
>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi Everyone!
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks for inviting me to join the Airflow PPMC!
>>>>>>>>>>>>>
>>>>>>>>>>>>> An introduction: I live and work in London, I'm currently
>>> working
>>>>> for
>>>>>>>>>>> the
>>>>>>>>>>>>> data group of a large advertising company, though I will be
>>> going
>>>>> on
>>>>>>>>>>>>> paternity leave for 3 months any day now as my wife is pregnant
>>>>> with
>>>>>>>> our
>>>>>>>>>>>>> first child. (Eeee!)
>>>>>>>>>>>>>
>>>>>>>>>>>>> I have some questions :)
>>>>>>>>>>>>>
>>>>>>>>>>>>> How to I merge PRs? From the outside it appears that the merge
>>>>>>>> happens
>>>>>>>>>>> in
>>>>>>>>>>>>> an apache repo and is somehow automatically replicated into
>>>>> github.
>>>>>>>> Is
>>>>>>>>>>>>> there a guide on the workflow to do this? What credentials do I
>>>>> use
>>>>>>>> for
>>>>>>>>>>>>> apache git?
>>>>>>>>>>>>>
>>>>>>>>>>>>> Is the branching process for releases or it is it a loose
>>>>> convention
>>>>>>>> up
>>>>>>>>>>> to
>>>>>>>>>>>>> the Release Manager for that release? (i.e. v1-9-stable,
>>> v1-9-test
>>>>>>>>>>> etc.) If
>>>>>>>>>>>>> we wanted to release a 1.9.1 with some fixes what might the
>>>>> process
>>>>>>>> be?
>>>>>>>>>>>>>
>>>>>>>>>>>>> Can someone grant my Jira user (ashb) permission to edit/close
>>>>>>>> tickets?
>>>>>>>>>>>>>
>>>>>>>>>>>>> Ditto for github (ashb)?
>>>>>>>>>>>>>
>>>>>>>>>>>>> I understand that the process for making changes now I'm a
>>>>> committer
>>>>>>>> is
>>>>>>>>>>>>> the same as before: I should open a PR+Jira and get it approved
>>> by
>>>>>>>>>>> another
>>>>>>>>>>>>> committer. Is this correct?
>>>>>>>>>>>>>
>>>>>>>>>>>>> Is there anything else I should know but don't know about to
>>> ask?
>>>>> :)
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>> Ash
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>
>>>
>>>
>
Re: Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a
New Committer) guide?
Posted by Ash Berlin-Taylor <as...@firemirror.com>.
Found some time, opened a PR: https://github.com/apache/incubator-airflow/pull/3413 <https://github.com/apache/incubator-airflow/pull/3413>
Commiters:
- Go to https://id.apache.org/ <https://id.apache.org/> and check that you have a GitHub username listed. Once you add it you'll get an invite on Github you need to accept.
- Then go to https://gitbox.apache.org/setup/ <https://gitbox.apache.org/setup/> and follow through the steps on that page.
Once we've done this you should be able to commit to the github repo, once we get the Apache Infra team to migrate the repo for us. I'll open a ticket for this early next week.
-ash
> On 23 May 2018, at 19:04, Sid Anand <sa...@apache.org> wrote:
>
> Welcome back Ash! Firstly, it was great meeting you in person in London in
> March, right before you went on Paternity Leave. Hope you are getting some
> sleep :-)
>
>
> -s
>
> On Wed, May 23, 2018 at 1:44 AM, Ash Berlin-Taylor <as...@firemirror.com>
> wrote:
>
>> Clearing :)
>>
>> I've gotten as far as having the tab with this Jira issue open again.
>> Which is progress :)
>>
>> I've been back at work for a week, so things are getting less hectic both
>> at home and at work, so I should be able to find time for this this week or
>> next. If someone picks it up before I get to it I won't be upset :)
>>
>> -ash
>>
>>> On 22 May 2018, at 23:20, Driesprong, Fokko <fo...@driesprong.frl>
>> wrote:
>>>
>>> Are we moving to Gitbox? I would really like that. I see a lot of other
>>> project moving to Gitbox at the moment (Flink, Parquet). How's your
>>> schedule Ash? ;)
>>>
>>> Cheers, Fokko
>>>
>>> 2018-03-09 18:53 GMT+01:00 Bolke de Bruin <bd...@gmail.com>:
>>>
>>>> I would love to be able to close PRs on GitHub, but personally I’m quite
>>>> ok with JIRA. GitHub issues tend to get messy imho. I also like that it
>> is
>>>> clear from the subject of Pr what the associated issues was, since we
>> moved
>>>> history became a lot cleaner and changelogs are now easy to generate.
>>>>
>>>> My 2cents
>>>>
>>>> B.
>>>>
>>>> Verstuurd vanaf mijn iPad
>>>>
>>>>> Op 9 mrt. 2018 om 18:01 heeft Ash Berlin-Taylor <as...@firemirror.com>
>>>> het volgende geschreven:
>>>>>
>>>>> That sounds like it is at worth me at least coming up a proposal for us
>>>> to vote on then..
>>>>>
>>>>> One thing that might help with the "target version" is multiple Github
>>>> Projects[1]: -- that, or labels, are the only way for a github issue to
>> be
>>>> in "two" groups at the same time.
>>>>>
>>>>> I'll see what I can do, but make zero promises due to imminent
>>>> baby-driven "sleep" schedule ;)
>>>>>
>>>>> [1]: https://help.github.com/articles/about-project-boards/
>>>>>
>>>>>
>>>>>> On 9 Mar 2018, at 16:10, Maxime Beauchemin <
>> maximebeauchemin@gmail.com>
>>>> wrote:
>>>>>>
>>>>>> We use Gitbox and no Jira for Apache Superset and are happy with it.
>>>>>>
>>>>>> One downside is around the current release management tooling for
>>>> Airflow
>>>>>> has bindings with Jira and the "target version" field.
>>>>>>
>>>>>> Max
>>>>>>
>>>>>> On Thu, Mar 8, 2018 at 6:31 AM, Ash Berlin-Taylor <
>>>>>> ash_airflowlist@firemirror.com> wrote:
>>>>>>
>>>>>>> I've done a bit of digging and there's an Apache "project" called
>>>>>>> gitbox[1] that, if we choose to go that way lets us use Github more
>>>>>>> "natively".
>>>>>>>
>>>>>>> The BookKeeper project migrated to using Github exclusively lsat
>> Jun[2]
>>>>>>> and from the looks of their Github repo are still using this
>> approach,
>>>> and
>>>>>>> their Jira is read only. Their proposal on the migration was
>>>>>>> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
>>>>>>> BP-9+-+Github+issues+for+Issue+Tracking
>>>>>>>
>>>>>>> I think there are three ways we could go:
>>>>>>>
>>>>>>> 1. Nothing changes, we stay as we are and commit to the ASF git repo.
>>>>>>> 2. Move to Gitbox and commit directly to githb, keep issues in Jira.
>>>>>>> 3. Do as BookKeeper did and move to using Github Issues as well as
>>>> Gitub
>>>>>>> for the repo.
>>>>>>>
>>>>>>> Is there interest from anyone else in 2 or 3, if so I will attempt to
>>>> draw
>>>>>>> up a more detailed proposal.
>>>>>>>
>>>>>>> [1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv
>>>>>>> [2]: http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/
>>>> 201706.mbox/%
>>>>>>> 3CCAO2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%4
>> 0mail.gmail.com
>>>> %3E
>>>>>>>
>>>>>>>
>>>>>>>> On 6 Mar 2018, at 09:57, Ash Berlin-Taylor
>>>> <ash_airflowlist@firemirror.
>>>>>>> com> wrote:
>>>>>>>>
>>>>>>>> Ah that would explain why I don't have a button :)
>>>>>>>>
>>>>>>>> Is this Apache policy, or is it possible for committers to be
>> granted
>>>>>>> permission to do this? Having this permission would also let us click
>>>> the
>>>>>>> "rerun tests" button in Travis which would be nice.
>>>>>>>>
>>>>>>>> Is it worth opening an INFRA ticket asking for this, or is it not
>>>>>>> possible?
>>>>>>>>
>>>>>>>> -ash
>>>>>>>>
>>>>>>>>> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl>
>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> Hi Ash,
>>>>>>>>>
>>>>>>>>> As a committer we don't have any rights on the Github itself. The
>>>> Github
>>>>>>>>> repo is just a sync of the apache repo. Unfortunately, therefore we
>>>>>>> don't
>>>>>>>>> have the right to close any PR.
>>>>>>>>>
>>>>>>>>> Cheers, Fokko
>>>>>>>>>
>>>>>>>>> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <
>>>>>>> ash_airflowlist@firemirror.com>
>>>>>>>>> :
>>>>>>>>>
>>>>>>>>>> I've merged two PRs now, and the second one seemed to be better
>>>>>>> (though I
>>>>>>>>>> did have some trouble with the tool not merging properly and I
>>>> needed
>>>>>>> to
>>>>>>>>>> manually coax git. Hmm)
>>>>>>>>>>
>>>>>>>>>> Jira: I _think_ that previously I could only comment on Jira
>> issues.
>>>>>>> With
>>>>>>>>>> the new permissions I can now do more (as those of you subscribed
>> to
>>>>>>> the
>>>>>>>>>> commit list will see) -- I started going through old Jira tickets
>>>> and
>>>>>>>>>> closing ones that are no longer an issue or that were fixed+merged
>>>> but
>>>>>>> not
>>>>>>>>>> closed.
>>>>>>>>>>
>>>>>>>>>> Github: I don't have a button to close PRs in Github - Is that
>>>>>>> expected?
>>>>>>>>>>
>>>>>>>>>> -ash
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Hi Ash,
>>>>>>>>>>> Welcome aboard.
>>>>>>>>>>>
>>>>>>>>>>> Firstly, I'm moving this conversation over to the dev list -- the
>>>>>>> first
>>>>>>>>>>> lesson we all learned at the insistence of the incubator mentors
>>>> was
>>>>>>> to
>>>>>>>>>> use
>>>>>>>>>>> the private list for voting and discussion on PMC matters. They
>>>>>>> require
>>>>>>>>>>> that all information-oriented discussions be routed to the
>>>> dev-list.
>>>>>>>>>>>
>>>>>>>>>>> *Merging PRs:*
>>>>>>>>>>> To merge a PR, you can use a very handy tool written by @jlowin
>>>>>>>>>>> <https://github.com/jlowin> : https://github.com/apache/
>>>>>>>>>>> incubator-airflow/blob/master/dev/airflow-pr
>>>>>>>>>>>
>>>>>>>>>>> It's pretty self-explanatory. Essentially, you follow the
>>>>>>> instructions in
>>>>>>>>>>> the tool -- the result is that the PR will be merged to Apache
>>>>>>>>>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git>
>>>> and
>>>>>>> then
>>>>>>>>>>> synced (mirrored) to https://github.com/apache/incubator-airflow
>> .
>>>> The
>>>>>>>>>>> Apache mirror runs on apache infrastructure and is the source of
>>>> truth
>>>>>>>>>>> (rules of apache). The mirror <https://github.com/apache/
>>>>>>>>>> incubator-airflow>
>>>>>>>>>>> is what we all see.. there can sometimes be a delay of a minute
>>>> before
>>>>>>>>>> the
>>>>>>>>>>> PR you merged shows up in the commit history on git hub, but it's
>>>>>>> usually
>>>>>>>>>>> under 10 seconds.
>>>>>>>>>>>
>>>>>>>>>>> We document the tool on the Committer Guide
>>>>>>>>>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/
>>>>>>> Committers%27+Guide
>>>>>>>>>>> .
>>>>>>>>>>>
>>>>>>>>>>> *Releases:*
>>>>>>>>>>> As I haven't done a release yet, I'll defer to Bolke and Chris
>> who
>>>>>>> most
>>>>>>>>>>> recently did releases to point you to documentation.
>>>>>>>>>>>
>>>>>>>>>>> *Jira Role:*
>>>>>>>>>>> I've added you to the Admin, PMC, Committers, and ASF Members
>>>> roles. I
>>>>>>>>>>> believe you don't need them to edit or close and JIRAs. I had
>>>>>>> requested
>>>>>>>>>>> anyone be able to open, edit, or close JIRAs, so if that's not
>> the
>>>>>>> case,
>>>>>>>>>> it
>>>>>>>>>>> would be good to know.
>>>>>>>>>>>
>>>>>>>>>>> *GitHub:*
>>>>>>>>>>> Can you try merging a PR? That would be an indication that you
>> have
>>>>>>> the
>>>>>>>>>>> necc perms.
>>>>>>>>>>>
>>>>>>>>>>> *Other Questions*:
>>>>>>>>>>> Q1:"I understand that the process for making changes now I'm a
>>>>>>> committer
>>>>>>>>>> is
>>>>>>>>>>> the same as before: I should open a PR+Jira and get it approved
>> by
>>>>>>>>>> another
>>>>>>>>>>> committer. Is this correct?"
>>>>>>>>>>> A1: You are correct!
>>>>>>>>>>>
>>>>>>>>>>> Hope this helps!
>>>>>>>>>>> -s
>>>>>>>>>>>
>>>>>>>>>>> P.S.
>>>>>>>>>>> BTW, I'll be in London from tomorrow (landing at noon) till the
>>>>>>> following
>>>>>>>>>>> Friday -- I co-chair QCon London and usually find myself there
>>>> around
>>>>>>>>>> this
>>>>>>>>>>> time every year. Feel free to drop me a line if you happen to be
>> in
>>>>>>> the
>>>>>>>>>>> area.
>>>>>>>>>>>
>>>>>>>>>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <
>> ash@apache.org>
>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi Everyone!
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks for inviting me to join the Airflow PPMC!
>>>>>>>>>>>>
>>>>>>>>>>>> An introduction: I live and work in London, I'm currently
>> working
>>>> for
>>>>>>>>>> the
>>>>>>>>>>>> data group of a large advertising company, though I will be
>> going
>>>> on
>>>>>>>>>>>> paternity leave for 3 months any day now as my wife is pregnant
>>>> with
>>>>>>> our
>>>>>>>>>>>> first child. (Eeee!)
>>>>>>>>>>>>
>>>>>>>>>>>> I have some questions :)
>>>>>>>>>>>>
>>>>>>>>>>>> How to I merge PRs? From the outside it appears that the merge
>>>>>>> happens
>>>>>>>>>> in
>>>>>>>>>>>> an apache repo and is somehow automatically replicated into
>>>> github.
>>>>>>> Is
>>>>>>>>>>>> there a guide on the workflow to do this? What credentials do I
>>>> use
>>>>>>> for
>>>>>>>>>>>> apache git?
>>>>>>>>>>>>
>>>>>>>>>>>> Is the branching process for releases or it is it a loose
>>>> convention
>>>>>>> up
>>>>>>>>>> to
>>>>>>>>>>>> the Release Manager for that release? (i.e. v1-9-stable,
>> v1-9-test
>>>>>>>>>> etc.) If
>>>>>>>>>>>> we wanted to release a 1.9.1 with some fixes what might the
>>>> process
>>>>>>> be?
>>>>>>>>>>>>
>>>>>>>>>>>> Can someone grant my Jira user (ashb) permission to edit/close
>>>>>>> tickets?
>>>>>>>>>>>>
>>>>>>>>>>>> Ditto for github (ashb)?
>>>>>>>>>>>>
>>>>>>>>>>>> I understand that the process for making changes now I'm a
>>>> committer
>>>>>>> is
>>>>>>>>>>>> the same as before: I should open a PR+Jira and get it approved
>> by
>>>>>>>>>> another
>>>>>>>>>>>> committer. Is this correct?
>>>>>>>>>>>>
>>>>>>>>>>>> Is there anything else I should know but don't know about to
>> ask?
>>>> :)
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks,
>>>>>>>>>>>> Ash
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>>
>>
>>
Re: Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a
New Committer) guide?
Posted by Sid Anand <sa...@apache.org>.
Welcome back Ash! Firstly, it was great meeting you in person in London in
March, right before you went on Paternity Leave. Hope you are getting some
sleep :-)
-s
On Wed, May 23, 2018 at 1:44 AM, Ash Berlin-Taylor <as...@firemirror.com>
wrote:
> Clearing :)
>
> I've gotten as far as having the tab with this Jira issue open again.
> Which is progress :)
>
> I've been back at work for a week, so things are getting less hectic both
> at home and at work, so I should be able to find time for this this week or
> next. If someone picks it up before I get to it I won't be upset :)
>
> -ash
>
> > On 22 May 2018, at 23:20, Driesprong, Fokko <fo...@driesprong.frl>
> wrote:
> >
> > Are we moving to Gitbox? I would really like that. I see a lot of other
> > project moving to Gitbox at the moment (Flink, Parquet). How's your
> > schedule Ash? ;)
> >
> > Cheers, Fokko
> >
> > 2018-03-09 18:53 GMT+01:00 Bolke de Bruin <bd...@gmail.com>:
> >
> >> I would love to be able to close PRs on GitHub, but personally I’m quite
> >> ok with JIRA. GitHub issues tend to get messy imho. I also like that it
> is
> >> clear from the subject of Pr what the associated issues was, since we
> moved
> >> history became a lot cleaner and changelogs are now easy to generate.
> >>
> >> My 2cents
> >>
> >> B.
> >>
> >> Verstuurd vanaf mijn iPad
> >>
> >>> Op 9 mrt. 2018 om 18:01 heeft Ash Berlin-Taylor <as...@firemirror.com>
> >> het volgende geschreven:
> >>>
> >>> That sounds like it is at worth me at least coming up a proposal for us
> >> to vote on then..
> >>>
> >>> One thing that might help with the "target version" is multiple Github
> >> Projects[1]: -- that, or labels, are the only way for a github issue to
> be
> >> in "two" groups at the same time.
> >>>
> >>> I'll see what I can do, but make zero promises due to imminent
> >> baby-driven "sleep" schedule ;)
> >>>
> >>> [1]: https://help.github.com/articles/about-project-boards/
> >>>
> >>>
> >>>> On 9 Mar 2018, at 16:10, Maxime Beauchemin <
> maximebeauchemin@gmail.com>
> >> wrote:
> >>>>
> >>>> We use Gitbox and no Jira for Apache Superset and are happy with it.
> >>>>
> >>>> One downside is around the current release management tooling for
> >> Airflow
> >>>> has bindings with Jira and the "target version" field.
> >>>>
> >>>> Max
> >>>>
> >>>> On Thu, Mar 8, 2018 at 6:31 AM, Ash Berlin-Taylor <
> >>>> ash_airflowlist@firemirror.com> wrote:
> >>>>
> >>>>> I've done a bit of digging and there's an Apache "project" called
> >>>>> gitbox[1] that, if we choose to go that way lets us use Github more
> >>>>> "natively".
> >>>>>
> >>>>> The BookKeeper project migrated to using Github exclusively lsat
> Jun[2]
> >>>>> and from the looks of their Github repo are still using this
> approach,
> >> and
> >>>>> their Jira is read only. Their proposal on the migration was
> >>>>> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> >>>>> BP-9+-+Github+issues+for+Issue+Tracking
> >>>>>
> >>>>> I think there are three ways we could go:
> >>>>>
> >>>>> 1. Nothing changes, we stay as we are and commit to the ASF git repo.
> >>>>> 2. Move to Gitbox and commit directly to githb, keep issues in Jira.
> >>>>> 3. Do as BookKeeper did and move to using Github Issues as well as
> >> Gitub
> >>>>> for the repo.
> >>>>>
> >>>>> Is there interest from anyone else in 2 or 3, if so I will attempt to
> >> draw
> >>>>> up a more detailed proposal.
> >>>>>
> >>>>> [1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv
> >>>>> [2]: http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/
> >> 201706.mbox/%
> >>>>> 3CCAO2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%4
> 0mail.gmail.com
> >> %3E
> >>>>>
> >>>>>
> >>>>>> On 6 Mar 2018, at 09:57, Ash Berlin-Taylor
> >> <ash_airflowlist@firemirror.
> >>>>> com> wrote:
> >>>>>>
> >>>>>> Ah that would explain why I don't have a button :)
> >>>>>>
> >>>>>> Is this Apache policy, or is it possible for committers to be
> granted
> >>>>> permission to do this? Having this permission would also let us click
> >> the
> >>>>> "rerun tests" button in Travis which would be nice.
> >>>>>>
> >>>>>> Is it worth opening an INFRA ticket asking for this, or is it not
> >>>>> possible?
> >>>>>>
> >>>>>> -ash
> >>>>>>
> >>>>>>> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl>
> >>>>> wrote:
> >>>>>>>
> >>>>>>> Hi Ash,
> >>>>>>>
> >>>>>>> As a committer we don't have any rights on the Github itself. The
> >> Github
> >>>>>>> repo is just a sync of the apache repo. Unfortunately, therefore we
> >>>>> don't
> >>>>>>> have the right to close any PR.
> >>>>>>>
> >>>>>>> Cheers, Fokko
> >>>>>>>
> >>>>>>> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <
> >>>>> ash_airflowlist@firemirror.com>
> >>>>>>> :
> >>>>>>>
> >>>>>>>> I've merged two PRs now, and the second one seemed to be better
> >>>>> (though I
> >>>>>>>> did have some trouble with the tool not merging properly and I
> >> needed
> >>>>> to
> >>>>>>>> manually coax git. Hmm)
> >>>>>>>>
> >>>>>>>> Jira: I _think_ that previously I could only comment on Jira
> issues.
> >>>>> With
> >>>>>>>> the new permissions I can now do more (as those of you subscribed
> to
> >>>>> the
> >>>>>>>> commit list will see) -- I started going through old Jira tickets
> >> and
> >>>>>>>> closing ones that are no longer an issue or that were fixed+merged
> >> but
> >>>>> not
> >>>>>>>> closed.
> >>>>>>>>
> >>>>>>>> Github: I don't have a button to close PRs in Github - Is that
> >>>>> expected?
> >>>>>>>>
> >>>>>>>> -ash
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
> >>>>>>>>>
> >>>>>>>>> Hi Ash,
> >>>>>>>>> Welcome aboard.
> >>>>>>>>>
> >>>>>>>>> Firstly, I'm moving this conversation over to the dev list -- the
> >>>>> first
> >>>>>>>>> lesson we all learned at the insistence of the incubator mentors
> >> was
> >>>>> to
> >>>>>>>> use
> >>>>>>>>> the private list for voting and discussion on PMC matters. They
> >>>>> require
> >>>>>>>>> that all information-oriented discussions be routed to the
> >> dev-list.
> >>>>>>>>>
> >>>>>>>>> *Merging PRs:*
> >>>>>>>>> To merge a PR, you can use a very handy tool written by @jlowin
> >>>>>>>>> <https://github.com/jlowin> : https://github.com/apache/
> >>>>>>>>> incubator-airflow/blob/master/dev/airflow-pr
> >>>>>>>>>
> >>>>>>>>> It's pretty self-explanatory. Essentially, you follow the
> >>>>> instructions in
> >>>>>>>>> the tool -- the result is that the PR will be merged to Apache
> >>>>>>>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git>
> >> and
> >>>>> then
> >>>>>>>>> synced (mirrored) to https://github.com/apache/incubator-airflow
> .
> >> The
> >>>>>>>>> Apache mirror runs on apache infrastructure and is the source of
> >> truth
> >>>>>>>>> (rules of apache). The mirror <https://github.com/apache/
> >>>>>>>> incubator-airflow>
> >>>>>>>>> is what we all see.. there can sometimes be a delay of a minute
> >> before
> >>>>>>>> the
> >>>>>>>>> PR you merged shows up in the commit history on git hub, but it's
> >>>>> usually
> >>>>>>>>> under 10 seconds.
> >>>>>>>>>
> >>>>>>>>> We document the tool on the Committer Guide
> >>>>>>>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/
> >>>>> Committers%27+Guide
> >>>>>>>>> .
> >>>>>>>>>
> >>>>>>>>> *Releases:*
> >>>>>>>>> As I haven't done a release yet, I'll defer to Bolke and Chris
> who
> >>>>> most
> >>>>>>>>> recently did releases to point you to documentation.
> >>>>>>>>>
> >>>>>>>>> *Jira Role:*
> >>>>>>>>> I've added you to the Admin, PMC, Committers, and ASF Members
> >> roles. I
> >>>>>>>>> believe you don't need them to edit or close and JIRAs. I had
> >>>>> requested
> >>>>>>>>> anyone be able to open, edit, or close JIRAs, so if that's not
> the
> >>>>> case,
> >>>>>>>> it
> >>>>>>>>> would be good to know.
> >>>>>>>>>
> >>>>>>>>> *GitHub:*
> >>>>>>>>> Can you try merging a PR? That would be an indication that you
> have
> >>>>> the
> >>>>>>>>> necc perms.
> >>>>>>>>>
> >>>>>>>>> *Other Questions*:
> >>>>>>>>> Q1:"I understand that the process for making changes now I'm a
> >>>>> committer
> >>>>>>>> is
> >>>>>>>>> the same as before: I should open a PR+Jira and get it approved
> by
> >>>>>>>> another
> >>>>>>>>> committer. Is this correct?"
> >>>>>>>>> A1: You are correct!
> >>>>>>>>>
> >>>>>>>>> Hope this helps!
> >>>>>>>>> -s
> >>>>>>>>>
> >>>>>>>>> P.S.
> >>>>>>>>> BTW, I'll be in London from tomorrow (landing at noon) till the
> >>>>> following
> >>>>>>>>> Friday -- I co-chair QCon London and usually find myself there
> >> around
> >>>>>>>> this
> >>>>>>>>> time every year. Feel free to drop me a line if you happen to be
> in
> >>>>> the
> >>>>>>>>> area.
> >>>>>>>>>
> >>>>>>>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <
> ash@apache.org>
> >>>>>>>> wrote:
> >>>>>>>>>
> >>>>>>>>>> Hi Everyone!
> >>>>>>>>>>
> >>>>>>>>>> Thanks for inviting me to join the Airflow PPMC!
> >>>>>>>>>>
> >>>>>>>>>> An introduction: I live and work in London, I'm currently
> working
> >> for
> >>>>>>>> the
> >>>>>>>>>> data group of a large advertising company, though I will be
> going
> >> on
> >>>>>>>>>> paternity leave for 3 months any day now as my wife is pregnant
> >> with
> >>>>> our
> >>>>>>>>>> first child. (Eeee!)
> >>>>>>>>>>
> >>>>>>>>>> I have some questions :)
> >>>>>>>>>>
> >>>>>>>>>> How to I merge PRs? From the outside it appears that the merge
> >>>>> happens
> >>>>>>>> in
> >>>>>>>>>> an apache repo and is somehow automatically replicated into
> >> github.
> >>>>> Is
> >>>>>>>>>> there a guide on the workflow to do this? What credentials do I
> >> use
> >>>>> for
> >>>>>>>>>> apache git?
> >>>>>>>>>>
> >>>>>>>>>> Is the branching process for releases or it is it a loose
> >> convention
> >>>>> up
> >>>>>>>> to
> >>>>>>>>>> the Release Manager for that release? (i.e. v1-9-stable,
> v1-9-test
> >>>>>>>> etc.) If
> >>>>>>>>>> we wanted to release a 1.9.1 with some fixes what might the
> >> process
> >>>>> be?
> >>>>>>>>>>
> >>>>>>>>>> Can someone grant my Jira user (ashb) permission to edit/close
> >>>>> tickets?
> >>>>>>>>>>
> >>>>>>>>>> Ditto for github (ashb)?
> >>>>>>>>>>
> >>>>>>>>>> I understand that the process for making changes now I'm a
> >> committer
> >>>>> is
> >>>>>>>>>> the same as before: I should open a PR+Jira and get it approved
> by
> >>>>>>>> another
> >>>>>>>>>> committer. Is this correct?
> >>>>>>>>>>
> >>>>>>>>>> Is there anything else I should know but don't know about to
> ask?
> >> :)
> >>>>>>>>>>
> >>>>>>>>>> Thanks,
> >>>>>>>>>> Ash
> >>>>>>>>
> >>>>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>
> >>
>
>
Re: Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a
New Committer) guide?
Posted by Ash Berlin-Taylor <as...@firemirror.com>.
Clearing :)
I've gotten as far as having the tab with this Jira issue open again. Which is progress :)
I've been back at work for a week, so things are getting less hectic both at home and at work, so I should be able to find time for this this week or next. If someone picks it up before I get to it I won't be upset :)
-ash
> On 22 May 2018, at 23:20, Driesprong, Fokko <fo...@driesprong.frl> wrote:
>
> Are we moving to Gitbox? I would really like that. I see a lot of other
> project moving to Gitbox at the moment (Flink, Parquet). How's your
> schedule Ash? ;)
>
> Cheers, Fokko
>
> 2018-03-09 18:53 GMT+01:00 Bolke de Bruin <bd...@gmail.com>:
>
>> I would love to be able to close PRs on GitHub, but personally I’m quite
>> ok with JIRA. GitHub issues tend to get messy imho. I also like that it is
>> clear from the subject of Pr what the associated issues was, since we moved
>> history became a lot cleaner and changelogs are now easy to generate.
>>
>> My 2cents
>>
>> B.
>>
>> Verstuurd vanaf mijn iPad
>>
>>> Op 9 mrt. 2018 om 18:01 heeft Ash Berlin-Taylor <as...@firemirror.com>
>> het volgende geschreven:
>>>
>>> That sounds like it is at worth me at least coming up a proposal for us
>> to vote on then..
>>>
>>> One thing that might help with the "target version" is multiple Github
>> Projects[1]: -- that, or labels, are the only way for a github issue to be
>> in "two" groups at the same time.
>>>
>>> I'll see what I can do, but make zero promises due to imminent
>> baby-driven "sleep" schedule ;)
>>>
>>> [1]: https://help.github.com/articles/about-project-boards/
>>>
>>>
>>>> On 9 Mar 2018, at 16:10, Maxime Beauchemin <ma...@gmail.com>
>> wrote:
>>>>
>>>> We use Gitbox and no Jira for Apache Superset and are happy with it.
>>>>
>>>> One downside is around the current release management tooling for
>> Airflow
>>>> has bindings with Jira and the "target version" field.
>>>>
>>>> Max
>>>>
>>>> On Thu, Mar 8, 2018 at 6:31 AM, Ash Berlin-Taylor <
>>>> ash_airflowlist@firemirror.com> wrote:
>>>>
>>>>> I've done a bit of digging and there's an Apache "project" called
>>>>> gitbox[1] that, if we choose to go that way lets us use Github more
>>>>> "natively".
>>>>>
>>>>> The BookKeeper project migrated to using Github exclusively lsat Jun[2]
>>>>> and from the looks of their Github repo are still using this approach,
>> and
>>>>> their Jira is read only. Their proposal on the migration was
>>>>> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
>>>>> BP-9+-+Github+issues+for+Issue+Tracking
>>>>>
>>>>> I think there are three ways we could go:
>>>>>
>>>>> 1. Nothing changes, we stay as we are and commit to the ASF git repo.
>>>>> 2. Move to Gitbox and commit directly to githb, keep issues in Jira.
>>>>> 3. Do as BookKeeper did and move to using Github Issues as well as
>> Gitub
>>>>> for the repo.
>>>>>
>>>>> Is there interest from anyone else in 2 or 3, if so I will attempt to
>> draw
>>>>> up a more detailed proposal.
>>>>>
>>>>> [1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv
>>>>> [2]: http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/
>> 201706.mbox/%
>>>>> 3CCAO2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%40mail.gmail.com
>> %3E
>>>>>
>>>>>
>>>>>> On 6 Mar 2018, at 09:57, Ash Berlin-Taylor
>> <ash_airflowlist@firemirror.
>>>>> com> wrote:
>>>>>>
>>>>>> Ah that would explain why I don't have a button :)
>>>>>>
>>>>>> Is this Apache policy, or is it possible for committers to be granted
>>>>> permission to do this? Having this permission would also let us click
>> the
>>>>> "rerun tests" button in Travis which would be nice.
>>>>>>
>>>>>> Is it worth opening an INFRA ticket asking for this, or is it not
>>>>> possible?
>>>>>>
>>>>>> -ash
>>>>>>
>>>>>>> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl>
>>>>> wrote:
>>>>>>>
>>>>>>> Hi Ash,
>>>>>>>
>>>>>>> As a committer we don't have any rights on the Github itself. The
>> Github
>>>>>>> repo is just a sync of the apache repo. Unfortunately, therefore we
>>>>> don't
>>>>>>> have the right to close any PR.
>>>>>>>
>>>>>>> Cheers, Fokko
>>>>>>>
>>>>>>> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <
>>>>> ash_airflowlist@firemirror.com>
>>>>>>> :
>>>>>>>
>>>>>>>> I've merged two PRs now, and the second one seemed to be better
>>>>> (though I
>>>>>>>> did have some trouble with the tool not merging properly and I
>> needed
>>>>> to
>>>>>>>> manually coax git. Hmm)
>>>>>>>>
>>>>>>>> Jira: I _think_ that previously I could only comment on Jira issues.
>>>>> With
>>>>>>>> the new permissions I can now do more (as those of you subscribed to
>>>>> the
>>>>>>>> commit list will see) -- I started going through old Jira tickets
>> and
>>>>>>>> closing ones that are no longer an issue or that were fixed+merged
>> but
>>>>> not
>>>>>>>> closed.
>>>>>>>>
>>>>>>>> Github: I don't have a button to close PRs in Github - Is that
>>>>> expected?
>>>>>>>>
>>>>>>>> -ash
>>>>>>>>
>>>>>>>>
>>>>>>>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
>>>>>>>>>
>>>>>>>>> Hi Ash,
>>>>>>>>> Welcome aboard.
>>>>>>>>>
>>>>>>>>> Firstly, I'm moving this conversation over to the dev list -- the
>>>>> first
>>>>>>>>> lesson we all learned at the insistence of the incubator mentors
>> was
>>>>> to
>>>>>>>> use
>>>>>>>>> the private list for voting and discussion on PMC matters. They
>>>>> require
>>>>>>>>> that all information-oriented discussions be routed to the
>> dev-list.
>>>>>>>>>
>>>>>>>>> *Merging PRs:*
>>>>>>>>> To merge a PR, you can use a very handy tool written by @jlowin
>>>>>>>>> <https://github.com/jlowin> : https://github.com/apache/
>>>>>>>>> incubator-airflow/blob/master/dev/airflow-pr
>>>>>>>>>
>>>>>>>>> It's pretty self-explanatory. Essentially, you follow the
>>>>> instructions in
>>>>>>>>> the tool -- the result is that the PR will be merged to Apache
>>>>>>>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git>
>> and
>>>>> then
>>>>>>>>> synced (mirrored) to https://github.com/apache/incubator-airflow.
>> The
>>>>>>>>> Apache mirror runs on apache infrastructure and is the source of
>> truth
>>>>>>>>> (rules of apache). The mirror <https://github.com/apache/
>>>>>>>> incubator-airflow>
>>>>>>>>> is what we all see.. there can sometimes be a delay of a minute
>> before
>>>>>>>> the
>>>>>>>>> PR you merged shows up in the commit history on git hub, but it's
>>>>> usually
>>>>>>>>> under 10 seconds.
>>>>>>>>>
>>>>>>>>> We document the tool on the Committer Guide
>>>>>>>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/
>>>>> Committers%27+Guide
>>>>>>>>> .
>>>>>>>>>
>>>>>>>>> *Releases:*
>>>>>>>>> As I haven't done a release yet, I'll defer to Bolke and Chris who
>>>>> most
>>>>>>>>> recently did releases to point you to documentation.
>>>>>>>>>
>>>>>>>>> *Jira Role:*
>>>>>>>>> I've added you to the Admin, PMC, Committers, and ASF Members
>> roles. I
>>>>>>>>> believe you don't need them to edit or close and JIRAs. I had
>>>>> requested
>>>>>>>>> anyone be able to open, edit, or close JIRAs, so if that's not the
>>>>> case,
>>>>>>>> it
>>>>>>>>> would be good to know.
>>>>>>>>>
>>>>>>>>> *GitHub:*
>>>>>>>>> Can you try merging a PR? That would be an indication that you have
>>>>> the
>>>>>>>>> necc perms.
>>>>>>>>>
>>>>>>>>> *Other Questions*:
>>>>>>>>> Q1:"I understand that the process for making changes now I'm a
>>>>> committer
>>>>>>>> is
>>>>>>>>> the same as before: I should open a PR+Jira and get it approved by
>>>>>>>> another
>>>>>>>>> committer. Is this correct?"
>>>>>>>>> A1: You are correct!
>>>>>>>>>
>>>>>>>>> Hope this helps!
>>>>>>>>> -s
>>>>>>>>>
>>>>>>>>> P.S.
>>>>>>>>> BTW, I'll be in London from tomorrow (landing at noon) till the
>>>>> following
>>>>>>>>> Friday -- I co-chair QCon London and usually find myself there
>> around
>>>>>>>> this
>>>>>>>>> time every year. Feel free to drop me a line if you happen to be in
>>>>> the
>>>>>>>>> area.
>>>>>>>>>
>>>>>>>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Everyone!
>>>>>>>>>>
>>>>>>>>>> Thanks for inviting me to join the Airflow PPMC!
>>>>>>>>>>
>>>>>>>>>> An introduction: I live and work in London, I'm currently working
>> for
>>>>>>>> the
>>>>>>>>>> data group of a large advertising company, though I will be going
>> on
>>>>>>>>>> paternity leave for 3 months any day now as my wife is pregnant
>> with
>>>>> our
>>>>>>>>>> first child. (Eeee!)
>>>>>>>>>>
>>>>>>>>>> I have some questions :)
>>>>>>>>>>
>>>>>>>>>> How to I merge PRs? From the outside it appears that the merge
>>>>> happens
>>>>>>>> in
>>>>>>>>>> an apache repo and is somehow automatically replicated into
>> github.
>>>>> Is
>>>>>>>>>> there a guide on the workflow to do this? What credentials do I
>> use
>>>>> for
>>>>>>>>>> apache git?
>>>>>>>>>>
>>>>>>>>>> Is the branching process for releases or it is it a loose
>> convention
>>>>> up
>>>>>>>> to
>>>>>>>>>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test
>>>>>>>> etc.) If
>>>>>>>>>> we wanted to release a 1.9.1 with some fixes what might the
>> process
>>>>> be?
>>>>>>>>>>
>>>>>>>>>> Can someone grant my Jira user (ashb) permission to edit/close
>>>>> tickets?
>>>>>>>>>>
>>>>>>>>>> Ditto for github (ashb)?
>>>>>>>>>>
>>>>>>>>>> I understand that the process for making changes now I'm a
>> committer
>>>>> is
>>>>>>>>>> the same as before: I should open a PR+Jira and get it approved by
>>>>>>>> another
>>>>>>>>>> committer. Is this correct?
>>>>>>>>>>
>>>>>>>>>> Is there anything else I should know but don't know about to ask?
>> :)
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Ash
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>
>>
Re: Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a
New Committer) guide?
Posted by Ash Berlin-Taylor <as...@firemirror.com>.
Clearing :)
I've gotten as far as having the tab with this Jira issue open again. Which is progress :)
I've been back at work for a week, so things are getting less hectic both at home and at work, so I should be able to find time for this this week or next. If someone picks it up before I get to it I won't be upset :)
-ash
> On 22 May 2018, at 23:20, Driesprong, Fokko <fo...@driesprong.frl> wrote:
>
> Are we moving to Gitbox? I would really like that. I see a lot of other
> project moving to Gitbox at the moment (Flink, Parquet). How's your
> schedule Ash? ;)
>
> Cheers, Fokko
>
> 2018-03-09 18:53 GMT+01:00 Bolke de Bruin <bd...@gmail.com>:
>
>> I would love to be able to close PRs on GitHub, but personally I’m quite
>> ok with JIRA. GitHub issues tend to get messy imho. I also like that it is
>> clear from the subject of Pr what the associated issues was, since we moved
>> history became a lot cleaner and changelogs are now easy to generate.
>>
>> My 2cents
>>
>> B.
>>
>> Verstuurd vanaf mijn iPad
>>
>>> Op 9 mrt. 2018 om 18:01 heeft Ash Berlin-Taylor <as...@firemirror.com>
>> het volgende geschreven:
>>>
>>> That sounds like it is at worth me at least coming up a proposal for us
>> to vote on then..
>>>
>>> One thing that might help with the "target version" is multiple Github
>> Projects[1]: -- that, or labels, are the only way for a github issue to be
>> in "two" groups at the same time.
>>>
>>> I'll see what I can do, but make zero promises due to imminent
>> baby-driven "sleep" schedule ;)
>>>
>>> [1]: https://help.github.com/articles/about-project-boards/
>>>
>>>
>>>> On 9 Mar 2018, at 16:10, Maxime Beauchemin <ma...@gmail.com>
>> wrote:
>>>>
>>>> We use Gitbox and no Jira for Apache Superset and are happy with it.
>>>>
>>>> One downside is around the current release management tooling for
>> Airflow
>>>> has bindings with Jira and the "target version" field.
>>>>
>>>> Max
>>>>
>>>> On Thu, Mar 8, 2018 at 6:31 AM, Ash Berlin-Taylor <
>>>> ash_airflowlist@firemirror.com> wrote:
>>>>
>>>>> I've done a bit of digging and there's an Apache "project" called
>>>>> gitbox[1] that, if we choose to go that way lets us use Github more
>>>>> "natively".
>>>>>
>>>>> The BookKeeper project migrated to using Github exclusively lsat Jun[2]
>>>>> and from the looks of their Github repo are still using this approach,
>> and
>>>>> their Jira is read only. Their proposal on the migration was
>>>>> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
>>>>> BP-9+-+Github+issues+for+Issue+Tracking
>>>>>
>>>>> I think there are three ways we could go:
>>>>>
>>>>> 1. Nothing changes, we stay as we are and commit to the ASF git repo.
>>>>> 2. Move to Gitbox and commit directly to githb, keep issues in Jira.
>>>>> 3. Do as BookKeeper did and move to using Github Issues as well as
>> Gitub
>>>>> for the repo.
>>>>>
>>>>> Is there interest from anyone else in 2 or 3, if so I will attempt to
>> draw
>>>>> up a more detailed proposal.
>>>>>
>>>>> [1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv
>>>>> [2]: http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/
>> 201706.mbox/%
>>>>> 3CCAO2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%40mail.gmail.com
>> %3E
>>>>>
>>>>>
>>>>>> On 6 Mar 2018, at 09:57, Ash Berlin-Taylor
>> <ash_airflowlist@firemirror.
>>>>> com> wrote:
>>>>>>
>>>>>> Ah that would explain why I don't have a button :)
>>>>>>
>>>>>> Is this Apache policy, or is it possible for committers to be granted
>>>>> permission to do this? Having this permission would also let us click
>> the
>>>>> "rerun tests" button in Travis which would be nice.
>>>>>>
>>>>>> Is it worth opening an INFRA ticket asking for this, or is it not
>>>>> possible?
>>>>>>
>>>>>> -ash
>>>>>>
>>>>>>> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl>
>>>>> wrote:
>>>>>>>
>>>>>>> Hi Ash,
>>>>>>>
>>>>>>> As a committer we don't have any rights on the Github itself. The
>> Github
>>>>>>> repo is just a sync of the apache repo. Unfortunately, therefore we
>>>>> don't
>>>>>>> have the right to close any PR.
>>>>>>>
>>>>>>> Cheers, Fokko
>>>>>>>
>>>>>>> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <
>>>>> ash_airflowlist@firemirror.com>
>>>>>>> :
>>>>>>>
>>>>>>>> I've merged two PRs now, and the second one seemed to be better
>>>>> (though I
>>>>>>>> did have some trouble with the tool not merging properly and I
>> needed
>>>>> to
>>>>>>>> manually coax git. Hmm)
>>>>>>>>
>>>>>>>> Jira: I _think_ that previously I could only comment on Jira issues.
>>>>> With
>>>>>>>> the new permissions I can now do more (as those of you subscribed to
>>>>> the
>>>>>>>> commit list will see) -- I started going through old Jira tickets
>> and
>>>>>>>> closing ones that are no longer an issue or that were fixed+merged
>> but
>>>>> not
>>>>>>>> closed.
>>>>>>>>
>>>>>>>> Github: I don't have a button to close PRs in Github - Is that
>>>>> expected?
>>>>>>>>
>>>>>>>> -ash
>>>>>>>>
>>>>>>>>
>>>>>>>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
>>>>>>>>>
>>>>>>>>> Hi Ash,
>>>>>>>>> Welcome aboard.
>>>>>>>>>
>>>>>>>>> Firstly, I'm moving this conversation over to the dev list -- the
>>>>> first
>>>>>>>>> lesson we all learned at the insistence of the incubator mentors
>> was
>>>>> to
>>>>>>>> use
>>>>>>>>> the private list for voting and discussion on PMC matters. They
>>>>> require
>>>>>>>>> that all information-oriented discussions be routed to the
>> dev-list.
>>>>>>>>>
>>>>>>>>> *Merging PRs:*
>>>>>>>>> To merge a PR, you can use a very handy tool written by @jlowin
>>>>>>>>> <https://github.com/jlowin> : https://github.com/apache/
>>>>>>>>> incubator-airflow/blob/master/dev/airflow-pr
>>>>>>>>>
>>>>>>>>> It's pretty self-explanatory. Essentially, you follow the
>>>>> instructions in
>>>>>>>>> the tool -- the result is that the PR will be merged to Apache
>>>>>>>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git>
>> and
>>>>> then
>>>>>>>>> synced (mirrored) to https://github.com/apache/incubator-airflow.
>> The
>>>>>>>>> Apache mirror runs on apache infrastructure and is the source of
>> truth
>>>>>>>>> (rules of apache). The mirror <https://github.com/apache/
>>>>>>>> incubator-airflow>
>>>>>>>>> is what we all see.. there can sometimes be a delay of a minute
>> before
>>>>>>>> the
>>>>>>>>> PR you merged shows up in the commit history on git hub, but it's
>>>>> usually
>>>>>>>>> under 10 seconds.
>>>>>>>>>
>>>>>>>>> We document the tool on the Committer Guide
>>>>>>>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/
>>>>> Committers%27+Guide
>>>>>>>>> .
>>>>>>>>>
>>>>>>>>> *Releases:*
>>>>>>>>> As I haven't done a release yet, I'll defer to Bolke and Chris who
>>>>> most
>>>>>>>>> recently did releases to point you to documentation.
>>>>>>>>>
>>>>>>>>> *Jira Role:*
>>>>>>>>> I've added you to the Admin, PMC, Committers, and ASF Members
>> roles. I
>>>>>>>>> believe you don't need them to edit or close and JIRAs. I had
>>>>> requested
>>>>>>>>> anyone be able to open, edit, or close JIRAs, so if that's not the
>>>>> case,
>>>>>>>> it
>>>>>>>>> would be good to know.
>>>>>>>>>
>>>>>>>>> *GitHub:*
>>>>>>>>> Can you try merging a PR? That would be an indication that you have
>>>>> the
>>>>>>>>> necc perms.
>>>>>>>>>
>>>>>>>>> *Other Questions*:
>>>>>>>>> Q1:"I understand that the process for making changes now I'm a
>>>>> committer
>>>>>>>> is
>>>>>>>>> the same as before: I should open a PR+Jira and get it approved by
>>>>>>>> another
>>>>>>>>> committer. Is this correct?"
>>>>>>>>> A1: You are correct!
>>>>>>>>>
>>>>>>>>> Hope this helps!
>>>>>>>>> -s
>>>>>>>>>
>>>>>>>>> P.S.
>>>>>>>>> BTW, I'll be in London from tomorrow (landing at noon) till the
>>>>> following
>>>>>>>>> Friday -- I co-chair QCon London and usually find myself there
>> around
>>>>>>>> this
>>>>>>>>> time every year. Feel free to drop me a line if you happen to be in
>>>>> the
>>>>>>>>> area.
>>>>>>>>>
>>>>>>>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Everyone!
>>>>>>>>>>
>>>>>>>>>> Thanks for inviting me to join the Airflow PPMC!
>>>>>>>>>>
>>>>>>>>>> An introduction: I live and work in London, I'm currently working
>> for
>>>>>>>> the
>>>>>>>>>> data group of a large advertising company, though I will be going
>> on
>>>>>>>>>> paternity leave for 3 months any day now as my wife is pregnant
>> with
>>>>> our
>>>>>>>>>> first child. (Eeee!)
>>>>>>>>>>
>>>>>>>>>> I have some questions :)
>>>>>>>>>>
>>>>>>>>>> How to I merge PRs? From the outside it appears that the merge
>>>>> happens
>>>>>>>> in
>>>>>>>>>> an apache repo and is somehow automatically replicated into
>> github.
>>>>> Is
>>>>>>>>>> there a guide on the workflow to do this? What credentials do I
>> use
>>>>> for
>>>>>>>>>> apache git?
>>>>>>>>>>
>>>>>>>>>> Is the branching process for releases or it is it a loose
>> convention
>>>>> up
>>>>>>>> to
>>>>>>>>>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test
>>>>>>>> etc.) If
>>>>>>>>>> we wanted to release a 1.9.1 with some fixes what might the
>> process
>>>>> be?
>>>>>>>>>>
>>>>>>>>>> Can someone grant my Jira user (ashb) permission to edit/close
>>>>> tickets?
>>>>>>>>>>
>>>>>>>>>> Ditto for github (ashb)?
>>>>>>>>>>
>>>>>>>>>> I understand that the process for making changes now I'm a
>> committer
>>>>> is
>>>>>>>>>> the same as before: I should open a PR+Jira and get it approved by
>>>>>>>> another
>>>>>>>>>> committer. Is this correct?
>>>>>>>>>>
>>>>>>>>>> Is there anything else I should know but don't know about to ask?
>> :)
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> Ash
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>
>>
Re: Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a
New Committer) guide?
Posted by "Driesprong, Fokko" <fo...@driesprong.frl>.
Are we moving to Gitbox? I would really like that. I see a lot of other
project moving to Gitbox at the moment (Flink, Parquet). How's your
schedule Ash? ;)
Cheers, Fokko
2018-03-09 18:53 GMT+01:00 Bolke de Bruin <bd...@gmail.com>:
> I would love to be able to close PRs on GitHub, but personally I’m quite
> ok with JIRA. GitHub issues tend to get messy imho. I also like that it is
> clear from the subject of Pr what the associated issues was, since we moved
> history became a lot cleaner and changelogs are now easy to generate.
>
> My 2cents
>
> B.
>
> Verstuurd vanaf mijn iPad
>
> > Op 9 mrt. 2018 om 18:01 heeft Ash Berlin-Taylor <as...@firemirror.com>
> het volgende geschreven:
> >
> > That sounds like it is at worth me at least coming up a proposal for us
> to vote on then..
> >
> > One thing that might help with the "target version" is multiple Github
> Projects[1]: -- that, or labels, are the only way for a github issue to be
> in "two" groups at the same time.
> >
> > I'll see what I can do, but make zero promises due to imminent
> baby-driven "sleep" schedule ;)
> >
> > [1]: https://help.github.com/articles/about-project-boards/
> >
> >
> >> On 9 Mar 2018, at 16:10, Maxime Beauchemin <ma...@gmail.com>
> wrote:
> >>
> >> We use Gitbox and no Jira for Apache Superset and are happy with it.
> >>
> >> One downside is around the current release management tooling for
> Airflow
> >> has bindings with Jira and the "target version" field.
> >>
> >> Max
> >>
> >> On Thu, Mar 8, 2018 at 6:31 AM, Ash Berlin-Taylor <
> >> ash_airflowlist@firemirror.com> wrote:
> >>
> >>> I've done a bit of digging and there's an Apache "project" called
> >>> gitbox[1] that, if we choose to go that way lets us use Github more
> >>> "natively".
> >>>
> >>> The BookKeeper project migrated to using Github exclusively lsat Jun[2]
> >>> and from the looks of their Github repo are still using this approach,
> and
> >>> their Jira is read only. Their proposal on the migration was
> >>> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> >>> BP-9+-+Github+issues+for+Issue+Tracking
> >>>
> >>> I think there are three ways we could go:
> >>>
> >>> 1. Nothing changes, we stay as we are and commit to the ASF git repo.
> >>> 2. Move to Gitbox and commit directly to githb, keep issues in Jira.
> >>> 3. Do as BookKeeper did and move to using Github Issues as well as
> Gitub
> >>> for the repo.
> >>>
> >>> Is there interest from anyone else in 2 or 3, if so I will attempt to
> draw
> >>> up a more detailed proposal.
> >>>
> >>> [1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv
> >>> [2]: http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/
> 201706.mbox/%
> >>> 3CCAO2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%40mail.gmail.com
> %3E
> >>>
> >>>
> >>>> On 6 Mar 2018, at 09:57, Ash Berlin-Taylor
> <ash_airflowlist@firemirror.
> >>> com> wrote:
> >>>>
> >>>> Ah that would explain why I don't have a button :)
> >>>>
> >>>> Is this Apache policy, or is it possible for committers to be granted
> >>> permission to do this? Having this permission would also let us click
> the
> >>> "rerun tests" button in Travis which would be nice.
> >>>>
> >>>> Is it worth opening an INFRA ticket asking for this, or is it not
> >>> possible?
> >>>>
> >>>> -ash
> >>>>
> >>>>> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl>
> >>> wrote:
> >>>>>
> >>>>> Hi Ash,
> >>>>>
> >>>>> As a committer we don't have any rights on the Github itself. The
> Github
> >>>>> repo is just a sync of the apache repo. Unfortunately, therefore we
> >>> don't
> >>>>> have the right to close any PR.
> >>>>>
> >>>>> Cheers, Fokko
> >>>>>
> >>>>> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <
> >>> ash_airflowlist@firemirror.com>
> >>>>> :
> >>>>>
> >>>>>> I've merged two PRs now, and the second one seemed to be better
> >>> (though I
> >>>>>> did have some trouble with the tool not merging properly and I
> needed
> >>> to
> >>>>>> manually coax git. Hmm)
> >>>>>>
> >>>>>> Jira: I _think_ that previously I could only comment on Jira issues.
> >>> With
> >>>>>> the new permissions I can now do more (as those of you subscribed to
> >>> the
> >>>>>> commit list will see) -- I started going through old Jira tickets
> and
> >>>>>> closing ones that are no longer an issue or that were fixed+merged
> but
> >>> not
> >>>>>> closed.
> >>>>>>
> >>>>>> Github: I don't have a button to close PRs in Github - Is that
> >>> expected?
> >>>>>>
> >>>>>> -ash
> >>>>>>
> >>>>>>
> >>>>>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
> >>>>>>>
> >>>>>>> Hi Ash,
> >>>>>>> Welcome aboard.
> >>>>>>>
> >>>>>>> Firstly, I'm moving this conversation over to the dev list -- the
> >>> first
> >>>>>>> lesson we all learned at the insistence of the incubator mentors
> was
> >>> to
> >>>>>> use
> >>>>>>> the private list for voting and discussion on PMC matters. They
> >>> require
> >>>>>>> that all information-oriented discussions be routed to the
> dev-list.
> >>>>>>>
> >>>>>>> *Merging PRs:*
> >>>>>>> To merge a PR, you can use a very handy tool written by @jlowin
> >>>>>>> <https://github.com/jlowin> : https://github.com/apache/
> >>>>>>> incubator-airflow/blob/master/dev/airflow-pr
> >>>>>>>
> >>>>>>> It's pretty self-explanatory. Essentially, you follow the
> >>> instructions in
> >>>>>>> the tool -- the result is that the PR will be merged to Apache
> >>>>>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git>
> and
> >>> then
> >>>>>>> synced (mirrored) to https://github.com/apache/incubator-airflow.
> The
> >>>>>>> Apache mirror runs on apache infrastructure and is the source of
> truth
> >>>>>>> (rules of apache). The mirror <https://github.com/apache/
> >>>>>> incubator-airflow>
> >>>>>>> is what we all see.. there can sometimes be a delay of a minute
> before
> >>>>>> the
> >>>>>>> PR you merged shows up in the commit history on git hub, but it's
> >>> usually
> >>>>>>> under 10 seconds.
> >>>>>>>
> >>>>>>> We document the tool on the Committer Guide
> >>>>>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/
> >>> Committers%27+Guide
> >>>>>>> .
> >>>>>>>
> >>>>>>> *Releases:*
> >>>>>>> As I haven't done a release yet, I'll defer to Bolke and Chris who
> >>> most
> >>>>>>> recently did releases to point you to documentation.
> >>>>>>>
> >>>>>>> *Jira Role:*
> >>>>>>> I've added you to the Admin, PMC, Committers, and ASF Members
> roles. I
> >>>>>>> believe you don't need them to edit or close and JIRAs. I had
> >>> requested
> >>>>>>> anyone be able to open, edit, or close JIRAs, so if that's not the
> >>> case,
> >>>>>> it
> >>>>>>> would be good to know.
> >>>>>>>
> >>>>>>> *GitHub:*
> >>>>>>> Can you try merging a PR? That would be an indication that you have
> >>> the
> >>>>>>> necc perms.
> >>>>>>>
> >>>>>>> *Other Questions*:
> >>>>>>> Q1:"I understand that the process for making changes now I'm a
> >>> committer
> >>>>>> is
> >>>>>>> the same as before: I should open a PR+Jira and get it approved by
> >>>>>> another
> >>>>>>> committer. Is this correct?"
> >>>>>>> A1: You are correct!
> >>>>>>>
> >>>>>>> Hope this helps!
> >>>>>>> -s
> >>>>>>>
> >>>>>>> P.S.
> >>>>>>> BTW, I'll be in London from tomorrow (landing at noon) till the
> >>> following
> >>>>>>> Friday -- I co-chair QCon London and usually find myself there
> around
> >>>>>> this
> >>>>>>> time every year. Feel free to drop me a line if you happen to be in
> >>> the
> >>>>>>> area.
> >>>>>>>
> >>>>>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org>
> >>>>>> wrote:
> >>>>>>>
> >>>>>>>> Hi Everyone!
> >>>>>>>>
> >>>>>>>> Thanks for inviting me to join the Airflow PPMC!
> >>>>>>>>
> >>>>>>>> An introduction: I live and work in London, I'm currently working
> for
> >>>>>> the
> >>>>>>>> data group of a large advertising company, though I will be going
> on
> >>>>>>>> paternity leave for 3 months any day now as my wife is pregnant
> with
> >>> our
> >>>>>>>> first child. (Eeee!)
> >>>>>>>>
> >>>>>>>> I have some questions :)
> >>>>>>>>
> >>>>>>>> How to I merge PRs? From the outside it appears that the merge
> >>> happens
> >>>>>> in
> >>>>>>>> an apache repo and is somehow automatically replicated into
> github.
> >>> Is
> >>>>>>>> there a guide on the workflow to do this? What credentials do I
> use
> >>> for
> >>>>>>>> apache git?
> >>>>>>>>
> >>>>>>>> Is the branching process for releases or it is it a loose
> convention
> >>> up
> >>>>>> to
> >>>>>>>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test
> >>>>>> etc.) If
> >>>>>>>> we wanted to release a 1.9.1 with some fixes what might the
> process
> >>> be?
> >>>>>>>>
> >>>>>>>> Can someone grant my Jira user (ashb) permission to edit/close
> >>> tickets?
> >>>>>>>>
> >>>>>>>> Ditto for github (ashb)?
> >>>>>>>>
> >>>>>>>> I understand that the process for making changes now I'm a
> committer
> >>> is
> >>>>>>>> the same as before: I should open a PR+Jira and get it approved by
> >>>>>> another
> >>>>>>>> committer. Is this correct?
> >>>>>>>>
> >>>>>>>> Is there anything else I should know but don't know about to ask?
> :)
> >>>>>>>>
> >>>>>>>> Thanks,
> >>>>>>>> Ash
> >>>>>>
> >>>>>>
> >>>>
> >>>
> >>>
> >
>
Re: Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a New Committer) guide?
Posted by Bolke de Bruin <bd...@gmail.com>.
I would love to be able to close PRs on GitHub, but personally I’m quite ok with JIRA. GitHub issues tend to get messy imho. I also like that it is clear from the subject of Pr what the associated issues was, since we moved history became a lot cleaner and changelogs are now easy to generate.
My 2cents
B.
Verstuurd vanaf mijn iPad
> Op 9 mrt. 2018 om 18:01 heeft Ash Berlin-Taylor <as...@firemirror.com> het volgende geschreven:
>
> That sounds like it is at worth me at least coming up a proposal for us to vote on then..
>
> One thing that might help with the "target version" is multiple Github Projects[1]: -- that, or labels, are the only way for a github issue to be in "two" groups at the same time.
>
> I'll see what I can do, but make zero promises due to imminent baby-driven "sleep" schedule ;)
>
> [1]: https://help.github.com/articles/about-project-boards/
>
>
>> On 9 Mar 2018, at 16:10, Maxime Beauchemin <ma...@gmail.com> wrote:
>>
>> We use Gitbox and no Jira for Apache Superset and are happy with it.
>>
>> One downside is around the current release management tooling for Airflow
>> has bindings with Jira and the "target version" field.
>>
>> Max
>>
>> On Thu, Mar 8, 2018 at 6:31 AM, Ash Berlin-Taylor <
>> ash_airflowlist@firemirror.com> wrote:
>>
>>> I've done a bit of digging and there's an Apache "project" called
>>> gitbox[1] that, if we choose to go that way lets us use Github more
>>> "natively".
>>>
>>> The BookKeeper project migrated to using Github exclusively lsat Jun[2]
>>> and from the looks of their Github repo are still using this approach, and
>>> their Jira is read only. Their proposal on the migration was
>>> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
>>> BP-9+-+Github+issues+for+Issue+Tracking
>>>
>>> I think there are three ways we could go:
>>>
>>> 1. Nothing changes, we stay as we are and commit to the ASF git repo.
>>> 2. Move to Gitbox and commit directly to githb, keep issues in Jira.
>>> 3. Do as BookKeeper did and move to using Github Issues as well as Gitub
>>> for the repo.
>>>
>>> Is there interest from anyone else in 2 or 3, if so I will attempt to draw
>>> up a more detailed proposal.
>>>
>>> [1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv
>>> [2]: http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/201706.mbox/%
>>> 3CCAO2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%40mail.gmail.com%3E
>>>
>>>
>>>> On 6 Mar 2018, at 09:57, Ash Berlin-Taylor <ash_airflowlist@firemirror.
>>> com> wrote:
>>>>
>>>> Ah that would explain why I don't have a button :)
>>>>
>>>> Is this Apache policy, or is it possible for committers to be granted
>>> permission to do this? Having this permission would also let us click the
>>> "rerun tests" button in Travis which would be nice.
>>>>
>>>> Is it worth opening an INFRA ticket asking for this, or is it not
>>> possible?
>>>>
>>>> -ash
>>>>
>>>>> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl>
>>> wrote:
>>>>>
>>>>> Hi Ash,
>>>>>
>>>>> As a committer we don't have any rights on the Github itself. The Github
>>>>> repo is just a sync of the apache repo. Unfortunately, therefore we
>>> don't
>>>>> have the right to close any PR.
>>>>>
>>>>> Cheers, Fokko
>>>>>
>>>>> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <
>>> ash_airflowlist@firemirror.com>
>>>>> :
>>>>>
>>>>>> I've merged two PRs now, and the second one seemed to be better
>>> (though I
>>>>>> did have some trouble with the tool not merging properly and I needed
>>> to
>>>>>> manually coax git. Hmm)
>>>>>>
>>>>>> Jira: I _think_ that previously I could only comment on Jira issues.
>>> With
>>>>>> the new permissions I can now do more (as those of you subscribed to
>>> the
>>>>>> commit list will see) -- I started going through old Jira tickets and
>>>>>> closing ones that are no longer an issue or that were fixed+merged but
>>> not
>>>>>> closed.
>>>>>>
>>>>>> Github: I don't have a button to close PRs in Github - Is that
>>> expected?
>>>>>>
>>>>>> -ash
>>>>>>
>>>>>>
>>>>>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
>>>>>>>
>>>>>>> Hi Ash,
>>>>>>> Welcome aboard.
>>>>>>>
>>>>>>> Firstly, I'm moving this conversation over to the dev list -- the
>>> first
>>>>>>> lesson we all learned at the insistence of the incubator mentors was
>>> to
>>>>>> use
>>>>>>> the private list for voting and discussion on PMC matters. They
>>> require
>>>>>>> that all information-oriented discussions be routed to the dev-list.
>>>>>>>
>>>>>>> *Merging PRs:*
>>>>>>> To merge a PR, you can use a very handy tool written by @jlowin
>>>>>>> <https://github.com/jlowin> : https://github.com/apache/
>>>>>>> incubator-airflow/blob/master/dev/airflow-pr
>>>>>>>
>>>>>>> It's pretty self-explanatory. Essentially, you follow the
>>> instructions in
>>>>>>> the tool -- the result is that the PR will be merged to Apache
>>>>>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and
>>> then
>>>>>>> synced (mirrored) to https://github.com/apache/incubator-airflow. The
>>>>>>> Apache mirror runs on apache infrastructure and is the source of truth
>>>>>>> (rules of apache). The mirror <https://github.com/apache/
>>>>>> incubator-airflow>
>>>>>>> is what we all see.. there can sometimes be a delay of a minute before
>>>>>> the
>>>>>>> PR you merged shows up in the commit history on git hub, but it's
>>> usually
>>>>>>> under 10 seconds.
>>>>>>>
>>>>>>> We document the tool on the Committer Guide
>>>>>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/
>>> Committers%27+Guide
>>>>>>> .
>>>>>>>
>>>>>>> *Releases:*
>>>>>>> As I haven't done a release yet, I'll defer to Bolke and Chris who
>>> most
>>>>>>> recently did releases to point you to documentation.
>>>>>>>
>>>>>>> *Jira Role:*
>>>>>>> I've added you to the Admin, PMC, Committers, and ASF Members roles. I
>>>>>>> believe you don't need them to edit or close and JIRAs. I had
>>> requested
>>>>>>> anyone be able to open, edit, or close JIRAs, so if that's not the
>>> case,
>>>>>> it
>>>>>>> would be good to know.
>>>>>>>
>>>>>>> *GitHub:*
>>>>>>> Can you try merging a PR? That would be an indication that you have
>>> the
>>>>>>> necc perms.
>>>>>>>
>>>>>>> *Other Questions*:
>>>>>>> Q1:"I understand that the process for making changes now I'm a
>>> committer
>>>>>> is
>>>>>>> the same as before: I should open a PR+Jira and get it approved by
>>>>>> another
>>>>>>> committer. Is this correct?"
>>>>>>> A1: You are correct!
>>>>>>>
>>>>>>> Hope this helps!
>>>>>>> -s
>>>>>>>
>>>>>>> P.S.
>>>>>>> BTW, I'll be in London from tomorrow (landing at noon) till the
>>> following
>>>>>>> Friday -- I co-chair QCon London and usually find myself there around
>>>>>> this
>>>>>>> time every year. Feel free to drop me a line if you happen to be in
>>> the
>>>>>>> area.
>>>>>>>
>>>>>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org>
>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi Everyone!
>>>>>>>>
>>>>>>>> Thanks for inviting me to join the Airflow PPMC!
>>>>>>>>
>>>>>>>> An introduction: I live and work in London, I'm currently working for
>>>>>> the
>>>>>>>> data group of a large advertising company, though I will be going on
>>>>>>>> paternity leave for 3 months any day now as my wife is pregnant with
>>> our
>>>>>>>> first child. (Eeee!)
>>>>>>>>
>>>>>>>> I have some questions :)
>>>>>>>>
>>>>>>>> How to I merge PRs? From the outside it appears that the merge
>>> happens
>>>>>> in
>>>>>>>> an apache repo and is somehow automatically replicated into github.
>>> Is
>>>>>>>> there a guide on the workflow to do this? What credentials do I use
>>> for
>>>>>>>> apache git?
>>>>>>>>
>>>>>>>> Is the branching process for releases or it is it a loose convention
>>> up
>>>>>> to
>>>>>>>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test
>>>>>> etc.) If
>>>>>>>> we wanted to release a 1.9.1 with some fixes what might the process
>>> be?
>>>>>>>>
>>>>>>>> Can someone grant my Jira user (ashb) permission to edit/close
>>> tickets?
>>>>>>>>
>>>>>>>> Ditto for github (ashb)?
>>>>>>>>
>>>>>>>> I understand that the process for making changes now I'm a committer
>>> is
>>>>>>>> the same as before: I should open a PR+Jira and get it approved by
>>>>>> another
>>>>>>>> committer. Is this correct?
>>>>>>>>
>>>>>>>> Is there anything else I should know but don't know about to ask? :)
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Ash
>>>>>>
>>>>>>
>>>>
>>>
>>>
>
Re: Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a
New Committer) guide?
Posted by Ash Berlin-Taylor <as...@firemirror.com>.
That sounds like it is at worth me at least coming up a proposal for us to vote on then..
One thing that might help with the "target version" is multiple Github Projects[1]: -- that, or labels, are the only way for a github issue to be in "two" groups at the same time.
I'll see what I can do, but make zero promises due to imminent baby-driven "sleep" schedule ;)
[1]: https://help.github.com/articles/about-project-boards/
> On 9 Mar 2018, at 16:10, Maxime Beauchemin <ma...@gmail.com> wrote:
>
> We use Gitbox and no Jira for Apache Superset and are happy with it.
>
> One downside is around the current release management tooling for Airflow
> has bindings with Jira and the "target version" field.
>
> Max
>
> On Thu, Mar 8, 2018 at 6:31 AM, Ash Berlin-Taylor <
> ash_airflowlist@firemirror.com> wrote:
>
>> I've done a bit of digging and there's an Apache "project" called
>> gitbox[1] that, if we choose to go that way lets us use Github more
>> "natively".
>>
>> The BookKeeper project migrated to using Github exclusively lsat Jun[2]
>> and from the looks of their Github repo are still using this approach, and
>> their Jira is read only. Their proposal on the migration was
>> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
>> BP-9+-+Github+issues+for+Issue+Tracking
>>
>> I think there are three ways we could go:
>>
>> 1. Nothing changes, we stay as we are and commit to the ASF git repo.
>> 2. Move to Gitbox and commit directly to githb, keep issues in Jira.
>> 3. Do as BookKeeper did and move to using Github Issues as well as Gitub
>> for the repo.
>>
>> Is there interest from anyone else in 2 or 3, if so I will attempt to draw
>> up a more detailed proposal.
>>
>> [1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv
>> [2]: http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/201706.mbox/%
>> 3CCAO2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%40mail.gmail.com%3E
>>
>>
>>> On 6 Mar 2018, at 09:57, Ash Berlin-Taylor <ash_airflowlist@firemirror.
>> com> wrote:
>>>
>>> Ah that would explain why I don't have a button :)
>>>
>>> Is this Apache policy, or is it possible for committers to be granted
>> permission to do this? Having this permission would also let us click the
>> "rerun tests" button in Travis which would be nice.
>>>
>>> Is it worth opening an INFRA ticket asking for this, or is it not
>> possible?
>>>
>>> -ash
>>>
>>>> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl>
>> wrote:
>>>>
>>>> Hi Ash,
>>>>
>>>> As a committer we don't have any rights on the Github itself. The Github
>>>> repo is just a sync of the apache repo. Unfortunately, therefore we
>> don't
>>>> have the right to close any PR.
>>>>
>>>> Cheers, Fokko
>>>>
>>>> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <
>> ash_airflowlist@firemirror.com>
>>>> :
>>>>
>>>>> I've merged two PRs now, and the second one seemed to be better
>> (though I
>>>>> did have some trouble with the tool not merging properly and I needed
>> to
>>>>> manually coax git. Hmm)
>>>>>
>>>>> Jira: I _think_ that previously I could only comment on Jira issues.
>> With
>>>>> the new permissions I can now do more (as those of you subscribed to
>> the
>>>>> commit list will see) -- I started going through old Jira tickets and
>>>>> closing ones that are no longer an issue or that were fixed+merged but
>> not
>>>>> closed.
>>>>>
>>>>> Github: I don't have a button to close PRs in Github - Is that
>> expected?
>>>>>
>>>>> -ash
>>>>>
>>>>>
>>>>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
>>>>>>
>>>>>> Hi Ash,
>>>>>> Welcome aboard.
>>>>>>
>>>>>> Firstly, I'm moving this conversation over to the dev list -- the
>> first
>>>>>> lesson we all learned at the insistence of the incubator mentors was
>> to
>>>>> use
>>>>>> the private list for voting and discussion on PMC matters. They
>> require
>>>>>> that all information-oriented discussions be routed to the dev-list.
>>>>>>
>>>>>> *Merging PRs:*
>>>>>> To merge a PR, you can use a very handy tool written by @jlowin
>>>>>> <https://github.com/jlowin> : https://github.com/apache/
>>>>>> incubator-airflow/blob/master/dev/airflow-pr
>>>>>>
>>>>>> It's pretty self-explanatory. Essentially, you follow the
>> instructions in
>>>>>> the tool -- the result is that the PR will be merged to Apache
>>>>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and
>> then
>>>>>> synced (mirrored) to https://github.com/apache/incubator-airflow. The
>>>>>> Apache mirror runs on apache infrastructure and is the source of truth
>>>>>> (rules of apache). The mirror <https://github.com/apache/
>>>>> incubator-airflow>
>>>>>> is what we all see.. there can sometimes be a delay of a minute before
>>>>> the
>>>>>> PR you merged shows up in the commit history on git hub, but it's
>> usually
>>>>>> under 10 seconds.
>>>>>>
>>>>>> We document the tool on the Committer Guide
>>>>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/
>> Committers%27+Guide
>>>>>> .
>>>>>>
>>>>>> *Releases:*
>>>>>> As I haven't done a release yet, I'll defer to Bolke and Chris who
>> most
>>>>>> recently did releases to point you to documentation.
>>>>>>
>>>>>> *Jira Role:*
>>>>>> I've added you to the Admin, PMC, Committers, and ASF Members roles. I
>>>>>> believe you don't need them to edit or close and JIRAs. I had
>> requested
>>>>>> anyone be able to open, edit, or close JIRAs, so if that's not the
>> case,
>>>>> it
>>>>>> would be good to know.
>>>>>>
>>>>>> *GitHub:*
>>>>>> Can you try merging a PR? That would be an indication that you have
>> the
>>>>>> necc perms.
>>>>>>
>>>>>> *Other Questions*:
>>>>>> Q1:"I understand that the process for making changes now I'm a
>> committer
>>>>> is
>>>>>> the same as before: I should open a PR+Jira and get it approved by
>>>>> another
>>>>>> committer. Is this correct?"
>>>>>> A1: You are correct!
>>>>>>
>>>>>> Hope this helps!
>>>>>> -s
>>>>>>
>>>>>> P.S.
>>>>>> BTW, I'll be in London from tomorrow (landing at noon) till the
>> following
>>>>>> Friday -- I co-chair QCon London and usually find myself there around
>>>>> this
>>>>>> time every year. Feel free to drop me a line if you happen to be in
>> the
>>>>>> area.
>>>>>>
>>>>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org>
>>>>> wrote:
>>>>>>
>>>>>>> Hi Everyone!
>>>>>>>
>>>>>>> Thanks for inviting me to join the Airflow PPMC!
>>>>>>>
>>>>>>> An introduction: I live and work in London, I'm currently working for
>>>>> the
>>>>>>> data group of a large advertising company, though I will be going on
>>>>>>> paternity leave for 3 months any day now as my wife is pregnant with
>> our
>>>>>>> first child. (Eeee!)
>>>>>>>
>>>>>>> I have some questions :)
>>>>>>>
>>>>>>> How to I merge PRs? From the outside it appears that the merge
>> happens
>>>>> in
>>>>>>> an apache repo and is somehow automatically replicated into github.
>> Is
>>>>>>> there a guide on the workflow to do this? What credentials do I use
>> for
>>>>>>> apache git?
>>>>>>>
>>>>>>> Is the branching process for releases or it is it a loose convention
>> up
>>>>> to
>>>>>>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test
>>>>> etc.) If
>>>>>>> we wanted to release a 1.9.1 with some fixes what might the process
>> be?
>>>>>>>
>>>>>>> Can someone grant my Jira user (ashb) permission to edit/close
>> tickets?
>>>>>>>
>>>>>>> Ditto for github (ashb)?
>>>>>>>
>>>>>>> I understand that the process for making changes now I'm a committer
>> is
>>>>>>> the same as before: I should open a PR+Jira and get it approved by
>>>>> another
>>>>>>> committer. Is this correct?
>>>>>>>
>>>>>>> Is there anything else I should know but don't know about to ask? :)
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Ash
>>>>>
>>>>>
>>>
>>
>>
Re: Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a
New Committer) guide?
Posted by Maxime Beauchemin <ma...@gmail.com>.
We use Gitbox and no Jira for Apache Superset and are happy with it.
One downside is around the current release management tooling for Airflow
has bindings with Jira and the "target version" field.
Max
On Thu, Mar 8, 2018 at 6:31 AM, Ash Berlin-Taylor <
ash_airflowlist@firemirror.com> wrote:
> I've done a bit of digging and there's an Apache "project" called
> gitbox[1] that, if we choose to go that way lets us use Github more
> "natively".
>
> The BookKeeper project migrated to using Github exclusively lsat Jun[2]
> and from the looks of their Github repo are still using this approach, and
> their Jira is read only. Their proposal on the migration was
> https://cwiki.apache.org/confluence/display/BOOKKEEPER/
> BP-9+-+Github+issues+for+Issue+Tracking
>
> I think there are three ways we could go:
>
> 1. Nothing changes, we stay as we are and commit to the ASF git repo.
> 2. Move to Gitbox and commit directly to githb, keep issues in Jira.
> 3. Do as BookKeeper did and move to using Github Issues as well as Gitub
> for the repo.
>
> Is there interest from anyone else in 2 or 3, if so I will attempt to draw
> up a more detailed proposal.
>
> [1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv
> [2]: http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/201706.mbox/%
> 3CCAO2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%40mail.gmail.com%3E
>
>
> > On 6 Mar 2018, at 09:57, Ash Berlin-Taylor <ash_airflowlist@firemirror.
> com> wrote:
> >
> > Ah that would explain why I don't have a button :)
> >
> > Is this Apache policy, or is it possible for committers to be granted
> permission to do this? Having this permission would also let us click the
> "rerun tests" button in Travis which would be nice.
> >
> > Is it worth opening an INFRA ticket asking for this, or is it not
> possible?
> >
> > -ash
> >
> >> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl>
> wrote:
> >>
> >> Hi Ash,
> >>
> >> As a committer we don't have any rights on the Github itself. The Github
> >> repo is just a sync of the apache repo. Unfortunately, therefore we
> don't
> >> have the right to close any PR.
> >>
> >> Cheers, Fokko
> >>
> >> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <
> ash_airflowlist@firemirror.com>
> >> :
> >>
> >>> I've merged two PRs now, and the second one seemed to be better
> (though I
> >>> did have some trouble with the tool not merging properly and I needed
> to
> >>> manually coax git. Hmm)
> >>>
> >>> Jira: I _think_ that previously I could only comment on Jira issues.
> With
> >>> the new permissions I can now do more (as those of you subscribed to
> the
> >>> commit list will see) -- I started going through old Jira tickets and
> >>> closing ones that are no longer an issue or that were fixed+merged but
> not
> >>> closed.
> >>>
> >>> Github: I don't have a button to close PRs in Github - Is that
> expected?
> >>>
> >>> -ash
> >>>
> >>>
> >>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
> >>>>
> >>>> Hi Ash,
> >>>> Welcome aboard.
> >>>>
> >>>> Firstly, I'm moving this conversation over to the dev list -- the
> first
> >>>> lesson we all learned at the insistence of the incubator mentors was
> to
> >>> use
> >>>> the private list for voting and discussion on PMC matters. They
> require
> >>>> that all information-oriented discussions be routed to the dev-list.
> >>>>
> >>>> *Merging PRs:*
> >>>> To merge a PR, you can use a very handy tool written by @jlowin
> >>>> <https://github.com/jlowin> : https://github.com/apache/
> >>>> incubator-airflow/blob/master/dev/airflow-pr
> >>>>
> >>>> It's pretty self-explanatory. Essentially, you follow the
> instructions in
> >>>> the tool -- the result is that the PR will be merged to Apache
> >>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and
> then
> >>>> synced (mirrored) to https://github.com/apache/incubator-airflow. The
> >>>> Apache mirror runs on apache infrastructure and is the source of truth
> >>>> (rules of apache). The mirror <https://github.com/apache/
> >>> incubator-airflow>
> >>>> is what we all see.. there can sometimes be a delay of a minute before
> >>> the
> >>>> PR you merged shows up in the commit history on git hub, but it's
> usually
> >>>> under 10 seconds.
> >>>>
> >>>> We document the tool on the Committer Guide
> >>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/
> Committers%27+Guide
> >>>> .
> >>>>
> >>>> *Releases:*
> >>>> As I haven't done a release yet, I'll defer to Bolke and Chris who
> most
> >>>> recently did releases to point you to documentation.
> >>>>
> >>>> *Jira Role:*
> >>>> I've added you to the Admin, PMC, Committers, and ASF Members roles. I
> >>>> believe you don't need them to edit or close and JIRAs. I had
> requested
> >>>> anyone be able to open, edit, or close JIRAs, so if that's not the
> case,
> >>> it
> >>>> would be good to know.
> >>>>
> >>>> *GitHub:*
> >>>> Can you try merging a PR? That would be an indication that you have
> the
> >>>> necc perms.
> >>>>
> >>>> *Other Questions*:
> >>>> Q1:"I understand that the process for making changes now I'm a
> committer
> >>> is
> >>>> the same as before: I should open a PR+Jira and get it approved by
> >>> another
> >>>> committer. Is this correct?"
> >>>> A1: You are correct!
> >>>>
> >>>> Hope this helps!
> >>>> -s
> >>>>
> >>>> P.S.
> >>>> BTW, I'll be in London from tomorrow (landing at noon) till the
> following
> >>>> Friday -- I co-chair QCon London and usually find myself there around
> >>> this
> >>>> time every year. Feel free to drop me a line if you happen to be in
> the
> >>>> area.
> >>>>
> >>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org>
> >>> wrote:
> >>>>
> >>>>> Hi Everyone!
> >>>>>
> >>>>> Thanks for inviting me to join the Airflow PPMC!
> >>>>>
> >>>>> An introduction: I live and work in London, I'm currently working for
> >>> the
> >>>>> data group of a large advertising company, though I will be going on
> >>>>> paternity leave for 3 months any day now as my wife is pregnant with
> our
> >>>>> first child. (Eeee!)
> >>>>>
> >>>>> I have some questions :)
> >>>>>
> >>>>> How to I merge PRs? From the outside it appears that the merge
> happens
> >>> in
> >>>>> an apache repo and is somehow automatically replicated into github.
> Is
> >>>>> there a guide on the workflow to do this? What credentials do I use
> for
> >>>>> apache git?
> >>>>>
> >>>>> Is the branching process for releases or it is it a loose convention
> up
> >>> to
> >>>>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test
> >>> etc.) If
> >>>>> we wanted to release a 1.9.1 with some fixes what might the process
> be?
> >>>>>
> >>>>> Can someone grant my Jira user (ashb) permission to edit/close
> tickets?
> >>>>>
> >>>>> Ditto for github (ashb)?
> >>>>>
> >>>>> I understand that the process for making changes now I'm a committer
> is
> >>>>> the same as before: I should open a PR+Jira and get it approved by
> >>> another
> >>>>> committer. Is this correct?
> >>>>>
> >>>>> Is there anything else I should know but don't know about to ask? :)
> >>>>>
> >>>>> Thanks,
> >>>>> Ash
> >>>
> >>>
> >
>
>
Moving to Github? Re: Merging PRs, closing Jira tickets (a.k.a New
Committer) guide?
Posted by Ash Berlin-Taylor <as...@firemirror.com>.
I've done a bit of digging and there's an Apache "project" called gitbox[1] that, if we choose to go that way lets us use Github more "natively".
The BookKeeper project migrated to using Github exclusively lsat Jun[2] and from the looks of their Github repo are still using this approach, and their Jira is read only. Their proposal on the migration was https://cwiki.apache.org/confluence/display/BOOKKEEPER/BP-9+-+Github+issues+for+Issue+Tracking
I think there are three ways we could go:
1. Nothing changes, we stay as we are and commit to the ASF git repo.
2. Move to Gitbox and commit directly to githb, keep issues in Jira.
3. Do as BookKeeper did and move to using Github Issues as well as Gitub for the repo.
Is there interest from anyone else in 2 or 3, if so I will attempt to draw up a more detailed proposal.
[1]: https://lists.apache.org/thread.html/Znkiyqnxqzryecv
[2]: http://mail-archives.apache.org/mod_mbox/bookkeeper-dev/201706.mbox/%3CCAO2yDybRq2VUM1JYo_6VT_H8Ca7Lu8af6H-2CZKQzYT6xYGU-g%40mail.gmail.com%3E
> On 6 Mar 2018, at 09:57, Ash Berlin-Taylor <as...@firemirror.com> wrote:
>
> Ah that would explain why I don't have a button :)
>
> Is this Apache policy, or is it possible for committers to be granted permission to do this? Having this permission would also let us click the "rerun tests" button in Travis which would be nice.
>
> Is it worth opening an INFRA ticket asking for this, or is it not possible?
>
> -ash
>
>> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl> wrote:
>>
>> Hi Ash,
>>
>> As a committer we don't have any rights on the Github itself. The Github
>> repo is just a sync of the apache repo. Unfortunately, therefore we don't
>> have the right to close any PR.
>>
>> Cheers, Fokko
>>
>> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <as...@firemirror.com>
>> :
>>
>>> I've merged two PRs now, and the second one seemed to be better (though I
>>> did have some trouble with the tool not merging properly and I needed to
>>> manually coax git. Hmm)
>>>
>>> Jira: I _think_ that previously I could only comment on Jira issues. With
>>> the new permissions I can now do more (as those of you subscribed to the
>>> commit list will see) -- I started going through old Jira tickets and
>>> closing ones that are no longer an issue or that were fixed+merged but not
>>> closed.
>>>
>>> Github: I don't have a button to close PRs in Github - Is that expected?
>>>
>>> -ash
>>>
>>>
>>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
>>>>
>>>> Hi Ash,
>>>> Welcome aboard.
>>>>
>>>> Firstly, I'm moving this conversation over to the dev list -- the first
>>>> lesson we all learned at the insistence of the incubator mentors was to
>>> use
>>>> the private list for voting and discussion on PMC matters. They require
>>>> that all information-oriented discussions be routed to the dev-list.
>>>>
>>>> *Merging PRs:*
>>>> To merge a PR, you can use a very handy tool written by @jlowin
>>>> <https://github.com/jlowin> : https://github.com/apache/
>>>> incubator-airflow/blob/master/dev/airflow-pr
>>>>
>>>> It's pretty self-explanatory. Essentially, you follow the instructions in
>>>> the tool -- the result is that the PR will be merged to Apache
>>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and then
>>>> synced (mirrored) to https://github.com/apache/incubator-airflow. The
>>>> Apache mirror runs on apache infrastructure and is the source of truth
>>>> (rules of apache). The mirror <https://github.com/apache/
>>> incubator-airflow>
>>>> is what we all see.. there can sometimes be a delay of a minute before
>>> the
>>>> PR you merged shows up in the commit history on git hub, but it's usually
>>>> under 10 seconds.
>>>>
>>>> We document the tool on the Committer Guide
>>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/Committers%27+Guide
>>>> .
>>>>
>>>> *Releases:*
>>>> As I haven't done a release yet, I'll defer to Bolke and Chris who most
>>>> recently did releases to point you to documentation.
>>>>
>>>> *Jira Role:*
>>>> I've added you to the Admin, PMC, Committers, and ASF Members roles. I
>>>> believe you don't need them to edit or close and JIRAs. I had requested
>>>> anyone be able to open, edit, or close JIRAs, so if that's not the case,
>>> it
>>>> would be good to know.
>>>>
>>>> *GitHub:*
>>>> Can you try merging a PR? That would be an indication that you have the
>>>> necc perms.
>>>>
>>>> *Other Questions*:
>>>> Q1:"I understand that the process for making changes now I'm a committer
>>> is
>>>> the same as before: I should open a PR+Jira and get it approved by
>>> another
>>>> committer. Is this correct?"
>>>> A1: You are correct!
>>>>
>>>> Hope this helps!
>>>> -s
>>>>
>>>> P.S.
>>>> BTW, I'll be in London from tomorrow (landing at noon) till the following
>>>> Friday -- I co-chair QCon London and usually find myself there around
>>> this
>>>> time every year. Feel free to drop me a line if you happen to be in the
>>>> area.
>>>>
>>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org>
>>> wrote:
>>>>
>>>>> Hi Everyone!
>>>>>
>>>>> Thanks for inviting me to join the Airflow PPMC!
>>>>>
>>>>> An introduction: I live and work in London, I'm currently working for
>>> the
>>>>> data group of a large advertising company, though I will be going on
>>>>> paternity leave for 3 months any day now as my wife is pregnant with our
>>>>> first child. (Eeee!)
>>>>>
>>>>> I have some questions :)
>>>>>
>>>>> How to I merge PRs? From the outside it appears that the merge happens
>>> in
>>>>> an apache repo and is somehow automatically replicated into github. Is
>>>>> there a guide on the workflow to do this? What credentials do I use for
>>>>> apache git?
>>>>>
>>>>> Is the branching process for releases or it is it a loose convention up
>>> to
>>>>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test
>>> etc.) If
>>>>> we wanted to release a 1.9.1 with some fixes what might the process be?
>>>>>
>>>>> Can someone grant my Jira user (ashb) permission to edit/close tickets?
>>>>>
>>>>> Ditto for github (ashb)?
>>>>>
>>>>> I understand that the process for making changes now I'm a committer is
>>>>> the same as before: I should open a PR+Jira and get it approved by
>>> another
>>>>> committer. Is this correct?
>>>>>
>>>>> Is there anything else I should know but don't know about to ask? :)
>>>>>
>>>>> Thanks,
>>>>> Ash
>>>
>>>
>
Re: Merging PRs, closing Jira tickets (a.k.a New Committer) guide?
Posted by Ash Berlin-Taylor <as...@firemirror.com>.
Ah that would explain why I don't have a button :)
Is this Apache policy, or is it possible for committers to be granted permission to do this? Having this permission would also let us click the "rerun tests" button in Travis which would be nice.
Is it worth opening an INFRA ticket asking for this, or is it not possible?
-ash
> On 6 Mar 2018, at 08:25, Driesprong, Fokko <fo...@driesprong.frl> wrote:
>
> Hi Ash,
>
> As a committer we don't have any rights on the Github itself. The Github
> repo is just a sync of the apache repo. Unfortunately, therefore we don't
> have the right to close any PR.
>
> Cheers, Fokko
>
> 2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <as...@firemirror.com>
> :
>
>> I've merged two PRs now, and the second one seemed to be better (though I
>> did have some trouble with the tool not merging properly and I needed to
>> manually coax git. Hmm)
>>
>> Jira: I _think_ that previously I could only comment on Jira issues. With
>> the new permissions I can now do more (as those of you subscribed to the
>> commit list will see) -- I started going through old Jira tickets and
>> closing ones that are no longer an issue or that were fixed+merged but not
>> closed.
>>
>> Github: I don't have a button to close PRs in Github - Is that expected?
>>
>> -ash
>>
>>
>>> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
>>>
>>> Hi Ash,
>>> Welcome aboard.
>>>
>>> Firstly, I'm moving this conversation over to the dev list -- the first
>>> lesson we all learned at the insistence of the incubator mentors was to
>> use
>>> the private list for voting and discussion on PMC matters. They require
>>> that all information-oriented discussions be routed to the dev-list.
>>>
>>> *Merging PRs:*
>>> To merge a PR, you can use a very handy tool written by @jlowin
>>> <https://github.com/jlowin> : https://github.com/apache/
>>> incubator-airflow/blob/master/dev/airflow-pr
>>>
>>> It's pretty self-explanatory. Essentially, you follow the instructions in
>>> the tool -- the result is that the PR will be merged to Apache
>>> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and then
>>> synced (mirrored) to https://github.com/apache/incubator-airflow. The
>>> Apache mirror runs on apache infrastructure and is the source of truth
>>> (rules of apache). The mirror <https://github.com/apache/
>> incubator-airflow>
>>> is what we all see.. there can sometimes be a delay of a minute before
>> the
>>> PR you merged shows up in the commit history on git hub, but it's usually
>>> under 10 seconds.
>>>
>>> We document the tool on the Committer Guide
>>> <https://cwiki.apache.org/confluence/display/AIRFLOW/Committers%27+Guide
>>> .
>>>
>>> *Releases:*
>>> As I haven't done a release yet, I'll defer to Bolke and Chris who most
>>> recently did releases to point you to documentation.
>>>
>>> *Jira Role:*
>>> I've added you to the Admin, PMC, Committers, and ASF Members roles. I
>>> believe you don't need them to edit or close and JIRAs. I had requested
>>> anyone be able to open, edit, or close JIRAs, so if that's not the case,
>> it
>>> would be good to know.
>>>
>>> *GitHub:*
>>> Can you try merging a PR? That would be an indication that you have the
>>> necc perms.
>>>
>>> *Other Questions*:
>>> Q1:"I understand that the process for making changes now I'm a committer
>> is
>>> the same as before: I should open a PR+Jira and get it approved by
>> another
>>> committer. Is this correct?"
>>> A1: You are correct!
>>>
>>> Hope this helps!
>>> -s
>>>
>>> P.S.
>>> BTW, I'll be in London from tomorrow (landing at noon) till the following
>>> Friday -- I co-chair QCon London and usually find myself there around
>> this
>>> time every year. Feel free to drop me a line if you happen to be in the
>>> area.
>>>
>>> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org>
>> wrote:
>>>
>>>> Hi Everyone!
>>>>
>>>> Thanks for inviting me to join the Airflow PPMC!
>>>>
>>>> An introduction: I live and work in London, I'm currently working for
>> the
>>>> data group of a large advertising company, though I will be going on
>>>> paternity leave for 3 months any day now as my wife is pregnant with our
>>>> first child. (Eeee!)
>>>>
>>>> I have some questions :)
>>>>
>>>> How to I merge PRs? From the outside it appears that the merge happens
>> in
>>>> an apache repo and is somehow automatically replicated into github. Is
>>>> there a guide on the workflow to do this? What credentials do I use for
>>>> apache git?
>>>>
>>>> Is the branching process for releases or it is it a loose convention up
>> to
>>>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test
>> etc.) If
>>>> we wanted to release a 1.9.1 with some fixes what might the process be?
>>>>
>>>> Can someone grant my Jira user (ashb) permission to edit/close tickets?
>>>>
>>>> Ditto for github (ashb)?
>>>>
>>>> I understand that the process for making changes now I'm a committer is
>>>> the same as before: I should open a PR+Jira and get it approved by
>> another
>>>> committer. Is this correct?
>>>>
>>>> Is there anything else I should know but don't know about to ask? :)
>>>>
>>>> Thanks,
>>>> Ash
>>
>>
Re: Merging PRs, closing Jira tickets (a.k.a New Committer) guide?
Posted by "Driesprong, Fokko" <fo...@driesprong.frl>.
Hi Ash,
As a committer we don't have any rights on the Github itself. The Github
repo is just a sync of the apache repo. Unfortunately, therefore we don't
have the right to close any PR.
Cheers, Fokko
2018-03-06 0:49 GMT+01:00 Ash Berlin-Taylor <as...@firemirror.com>
:
> I've merged two PRs now, and the second one seemed to be better (though I
> did have some trouble with the tool not merging properly and I needed to
> manually coax git. Hmm)
>
> Jira: I _think_ that previously I could only comment on Jira issues. With
> the new permissions I can now do more (as those of you subscribed to the
> commit list will see) -- I started going through old Jira tickets and
> closing ones that are no longer an issue or that were fixed+merged but not
> closed.
>
> Github: I don't have a button to close PRs in Github - Is that expected?
>
> -ash
>
>
> > On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
> >
> > Hi Ash,
> > Welcome aboard.
> >
> > Firstly, I'm moving this conversation over to the dev list -- the first
> > lesson we all learned at the insistence of the incubator mentors was to
> use
> > the private list for voting and discussion on PMC matters. They require
> > that all information-oriented discussions be routed to the dev-list.
> >
> > *Merging PRs:*
> > To merge a PR, you can use a very handy tool written by @jlowin
> > <https://github.com/jlowin> : https://github.com/apache/
> > incubator-airflow/blob/master/dev/airflow-pr
> >
> > It's pretty self-explanatory. Essentially, you follow the instructions in
> > the tool -- the result is that the PR will be merged to Apache
> > <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and then
> > synced (mirrored) to https://github.com/apache/incubator-airflow. The
> > Apache mirror runs on apache infrastructure and is the source of truth
> > (rules of apache). The mirror <https://github.com/apache/
> incubator-airflow>
> > is what we all see.. there can sometimes be a delay of a minute before
> the
> > PR you merged shows up in the commit history on git hub, but it's usually
> > under 10 seconds.
> >
> > We document the tool on the Committer Guide
> > <https://cwiki.apache.org/confluence/display/AIRFLOW/Committers%27+Guide
> >.
> >
> > *Releases:*
> > As I haven't done a release yet, I'll defer to Bolke and Chris who most
> > recently did releases to point you to documentation.
> >
> > *Jira Role:*
> > I've added you to the Admin, PMC, Committers, and ASF Members roles. I
> > believe you don't need them to edit or close and JIRAs. I had requested
> > anyone be able to open, edit, or close JIRAs, so if that's not the case,
> it
> > would be good to know.
> >
> > *GitHub:*
> > Can you try merging a PR? That would be an indication that you have the
> > necc perms.
> >
> > *Other Questions*:
> > Q1:"I understand that the process for making changes now I'm a committer
> is
> > the same as before: I should open a PR+Jira and get it approved by
> another
> > committer. Is this correct?"
> > A1: You are correct!
> >
> > Hope this helps!
> > -s
> >
> > P.S.
> > BTW, I'll be in London from tomorrow (landing at noon) till the following
> > Friday -- I co-chair QCon London and usually find myself there around
> this
> > time every year. Feel free to drop me a line if you happen to be in the
> > area.
> >
> > On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org>
> wrote:
> >
> >> Hi Everyone!
> >>
> >> Thanks for inviting me to join the Airflow PPMC!
> >>
> >> An introduction: I live and work in London, I'm currently working for
> the
> >> data group of a large advertising company, though I will be going on
> >> paternity leave for 3 months any day now as my wife is pregnant with our
> >> first child. (Eeee!)
> >>
> >> I have some questions :)
> >>
> >> How to I merge PRs? From the outside it appears that the merge happens
> in
> >> an apache repo and is somehow automatically replicated into github. Is
> >> there a guide on the workflow to do this? What credentials do I use for
> >> apache git?
> >>
> >> Is the branching process for releases or it is it a loose convention up
> to
> >> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test
> etc.) If
> >> we wanted to release a 1.9.1 with some fixes what might the process be?
> >>
> >> Can someone grant my Jira user (ashb) permission to edit/close tickets?
> >>
> >> Ditto for github (ashb)?
> >>
> >> I understand that the process for making changes now I'm a committer is
> >> the same as before: I should open a PR+Jira and get it approved by
> another
> >> committer. Is this correct?
> >>
> >> Is there anything else I should know but don't know about to ask? :)
> >>
> >> Thanks,
> >> Ash
>
>
Re: Merging PRs, closing Jira tickets (a.k.a New Committer) guide?
Posted by Ash Berlin-Taylor <as...@firemirror.com>.
I've merged two PRs now, and the second one seemed to be better (though I did have some trouble with the tool not merging properly and I needed to manually coax git. Hmm)
Jira: I _think_ that previously I could only comment on Jira issues. With the new permissions I can now do more (as those of you subscribed to the commit list will see) -- I started going through old Jira tickets and closing ones that are no longer an issue or that were fixed+merged but not closed.
Github: I don't have a button to close PRs in Github - Is that expected?
-ash
> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
>
> Hi Ash,
> Welcome aboard.
>
> Firstly, I'm moving this conversation over to the dev list -- the first
> lesson we all learned at the insistence of the incubator mentors was to use
> the private list for voting and discussion on PMC matters. They require
> that all information-oriented discussions be routed to the dev-list.
>
> *Merging PRs:*
> To merge a PR, you can use a very handy tool written by @jlowin
> <https://github.com/jlowin> : https://github.com/apache/
> incubator-airflow/blob/master/dev/airflow-pr
>
> It's pretty self-explanatory. Essentially, you follow the instructions in
> the tool -- the result is that the PR will be merged to Apache
> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and then
> synced (mirrored) to https://github.com/apache/incubator-airflow. The
> Apache mirror runs on apache infrastructure and is the source of truth
> (rules of apache). The mirror <https://github.com/apache/incubator-airflow>
> is what we all see.. there can sometimes be a delay of a minute before the
> PR you merged shows up in the commit history on git hub, but it's usually
> under 10 seconds.
>
> We document the tool on the Committer Guide
> <https://cwiki.apache.org/confluence/display/AIRFLOW/Committers%27+Guide>.
>
> *Releases:*
> As I haven't done a release yet, I'll defer to Bolke and Chris who most
> recently did releases to point you to documentation.
>
> *Jira Role:*
> I've added you to the Admin, PMC, Committers, and ASF Members roles. I
> believe you don't need them to edit or close and JIRAs. I had requested
> anyone be able to open, edit, or close JIRAs, so if that's not the case, it
> would be good to know.
>
> *GitHub:*
> Can you try merging a PR? That would be an indication that you have the
> necc perms.
>
> *Other Questions*:
> Q1:"I understand that the process for making changes now I'm a committer is
> the same as before: I should open a PR+Jira and get it approved by another
> committer. Is this correct?"
> A1: You are correct!
>
> Hope this helps!
> -s
>
> P.S.
> BTW, I'll be in London from tomorrow (landing at noon) till the following
> Friday -- I co-chair QCon London and usually find myself there around this
> time every year. Feel free to drop me a line if you happen to be in the
> area.
>
> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org> wrote:
>
>> Hi Everyone!
>>
>> Thanks for inviting me to join the Airflow PPMC!
>>
>> An introduction: I live and work in London, I'm currently working for the
>> data group of a large advertising company, though I will be going on
>> paternity leave for 3 months any day now as my wife is pregnant with our
>> first child. (Eeee!)
>>
>> I have some questions :)
>>
>> How to I merge PRs? From the outside it appears that the merge happens in
>> an apache repo and is somehow automatically replicated into github. Is
>> there a guide on the workflow to do this? What credentials do I use for
>> apache git?
>>
>> Is the branching process for releases or it is it a loose convention up to
>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test etc.) If
>> we wanted to release a 1.9.1 with some fixes what might the process be?
>>
>> Can someone grant my Jira user (ashb) permission to edit/close tickets?
>>
>> Ditto for github (ashb)?
>>
>> I understand that the process for making changes now I'm a committer is
>> the same as before: I should open a PR+Jira and get it approved by another
>> committer. Is this correct?
>>
>> Is there anything else I should know but don't know about to ask? :)
>>
>> Thanks,
>> Ash
Re: Merging PRs, closing Jira tickets (a.k.a New Committer) guide?
Posted by Chris Riccomini <cr...@apache.org>.
Done!
On Sat, Mar 10, 2018 at 6:14 AM, Ash Berlin-Taylor <
ash_airflowlist@firemirror.com> wrote:
> Could someone add my Confluence user (ashb) to the space as well please? I
> can't seem to edit/create pages right now.
>
> Thanks,
> Ash
>
>
> > On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
> >
> > Hi Ash,
> > Welcome aboard.
> >
> > Firstly, I'm moving this conversation over to the dev list -- the first
> > lesson we all learned at the insistence of the incubator mentors was to
> use
> > the private list for voting and discussion on PMC matters. They require
> > that all information-oriented discussions be routed to the dev-list.
> >
> > *Merging PRs:*
> > To merge a PR, you can use a very handy tool written by @jlowin
> > <https://github.com/jlowin> : https://github.com/apache/
> > incubator-airflow/blob/master/dev/airflow-pr
> >
> > It's pretty self-explanatory. Essentially, you follow the instructions in
> > the tool -- the result is that the PR will be merged to Apache
> > <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and then
> > synced (mirrored) to https://github.com/apache/incubator-airflow. The
> > Apache mirror runs on apache infrastructure and is the source of truth
> > (rules of apache). The mirror <https://github.com/apache/
> incubator-airflow>
> > is what we all see.. there can sometimes be a delay of a minute before
> the
> > PR you merged shows up in the commit history on git hub, but it's usually
> > under 10 seconds.
> >
> > We document the tool on the Committer Guide
> > <https://cwiki.apache.org/confluence/display/AIRFLOW/Committers%27+Guide
> >.
> >
> > *Releases:*
> > As I haven't done a release yet, I'll defer to Bolke and Chris who most
> > recently did releases to point you to documentation.
> >
> > *Jira Role:*
> > I've added you to the Admin, PMC, Committers, and ASF Members roles. I
> > believe you don't need them to edit or close and JIRAs. I had requested
> > anyone be able to open, edit, or close JIRAs, so if that's not the case,
> it
> > would be good to know.
> >
> > *GitHub:*
> > Can you try merging a PR? That would be an indication that you have the
> > necc perms.
> >
> > *Other Questions*:
> > Q1:"I understand that the process for making changes now I'm a committer
> is
> > the same as before: I should open a PR+Jira and get it approved by
> another
> > committer. Is this correct?"
> > A1: You are correct!
> >
> > Hope this helps!
> > -s
> >
> > P.S.
> > BTW, I'll be in London from tomorrow (landing at noon) till the following
> > Friday -- I co-chair QCon London and usually find myself there around
> this
> > time every year. Feel free to drop me a line if you happen to be in the
> > area.
> >
> > On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org>
> wrote:
> >
> >> Hi Everyone!
> >>
> >> Thanks for inviting me to join the Airflow PPMC!
> >>
> >> An introduction: I live and work in London, I'm currently working for
> the
> >> data group of a large advertising company, though I will be going on
> >> paternity leave for 3 months any day now as my wife is pregnant with our
> >> first child. (Eeee!)
> >>
> >> I have some questions :)
> >>
> >> How to I merge PRs? From the outside it appears that the merge happens
> in
> >> an apache repo and is somehow automatically replicated into github. Is
> >> there a guide on the workflow to do this? What credentials do I use for
> >> apache git?
> >>
> >> Is the branching process for releases or it is it a loose convention up
> to
> >> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test
> etc.) If
> >> we wanted to release a 1.9.1 with some fixes what might the process be?
> >>
> >> Can someone grant my Jira user (ashb) permission to edit/close tickets?
> >>
> >> Ditto for github (ashb)?
> >>
> >> I understand that the process for making changes now I'm a committer is
> >> the same as before: I should open a PR+Jira and get it approved by
> another
> >> committer. Is this correct?
> >>
> >> Is there anything else I should know but don't know about to ask? :)
> >>
> >> Thanks,
> >> Ash
>
>
Re: Merging PRs, closing Jira tickets (a.k.a New Committer) guide?
Posted by Ash Berlin-Taylor <as...@firemirror.com>.
Could someone add my Confluence user (ashb) to the space as well please? I can't seem to edit/create pages right now.
Thanks,
Ash
> On 4 Mar 2018, at 00:59, Sid Anand <sa...@apache.org> wrote:
>
> Hi Ash,
> Welcome aboard.
>
> Firstly, I'm moving this conversation over to the dev list -- the first
> lesson we all learned at the insistence of the incubator mentors was to use
> the private list for voting and discussion on PMC matters. They require
> that all information-oriented discussions be routed to the dev-list.
>
> *Merging PRs:*
> To merge a PR, you can use a very handy tool written by @jlowin
> <https://github.com/jlowin> : https://github.com/apache/
> incubator-airflow/blob/master/dev/airflow-pr
>
> It's pretty self-explanatory. Essentially, you follow the instructions in
> the tool -- the result is that the PR will be merged to Apache
> <https://git-wip-us.apache.org/repos/asf/incubator-airflow.git> and then
> synced (mirrored) to https://github.com/apache/incubator-airflow. The
> Apache mirror runs on apache infrastructure and is the source of truth
> (rules of apache). The mirror <https://github.com/apache/incubator-airflow>
> is what we all see.. there can sometimes be a delay of a minute before the
> PR you merged shows up in the commit history on git hub, but it's usually
> under 10 seconds.
>
> We document the tool on the Committer Guide
> <https://cwiki.apache.org/confluence/display/AIRFLOW/Committers%27+Guide>.
>
> *Releases:*
> As I haven't done a release yet, I'll defer to Bolke and Chris who most
> recently did releases to point you to documentation.
>
> *Jira Role:*
> I've added you to the Admin, PMC, Committers, and ASF Members roles. I
> believe you don't need them to edit or close and JIRAs. I had requested
> anyone be able to open, edit, or close JIRAs, so if that's not the case, it
> would be good to know.
>
> *GitHub:*
> Can you try merging a PR? That would be an indication that you have the
> necc perms.
>
> *Other Questions*:
> Q1:"I understand that the process for making changes now I'm a committer is
> the same as before: I should open a PR+Jira and get it approved by another
> committer. Is this correct?"
> A1: You are correct!
>
> Hope this helps!
> -s
>
> P.S.
> BTW, I'll be in London from tomorrow (landing at noon) till the following
> Friday -- I co-chair QCon London and usually find myself there around this
> time every year. Feel free to drop me a line if you happen to be in the
> area.
>
> On Sat, Mar 3, 2018 at 5:06 AM, Ash Berlin-Taylor <as...@apache.org> wrote:
>
>> Hi Everyone!
>>
>> Thanks for inviting me to join the Airflow PPMC!
>>
>> An introduction: I live and work in London, I'm currently working for the
>> data group of a large advertising company, though I will be going on
>> paternity leave for 3 months any day now as my wife is pregnant with our
>> first child. (Eeee!)
>>
>> I have some questions :)
>>
>> How to I merge PRs? From the outside it appears that the merge happens in
>> an apache repo and is somehow automatically replicated into github. Is
>> there a guide on the workflow to do this? What credentials do I use for
>> apache git?
>>
>> Is the branching process for releases or it is it a loose convention up to
>> the Release Manager for that release? (i.e. v1-9-stable, v1-9-test etc.) If
>> we wanted to release a 1.9.1 with some fixes what might the process be?
>>
>> Can someone grant my Jira user (ashb) permission to edit/close tickets?
>>
>> Ditto for github (ashb)?
>>
>> I understand that the process for making changes now I'm a committer is
>> the same as before: I should open a PR+Jira and get it approved by another
>> committer. Is this correct?
>>
>> Is there anything else I should know but don't know about to ask? :)
>>
>> Thanks,
>> Ash