You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/14 07:11:20 UTC
[GitHub] [flink] godfreyhe opened a new pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
godfreyhe opened a new pull request #14637:
URL: https://github.com/apache/flink/pull/14637
## What is the purpose of the change
*Separate the implementation of sink nodes, including StreamExecSink, BatchExecSink, StreamExecLegacySink, BatchExecLegacySink*
## Brief change log
- *Introduce StreamPhysicalSink, and make StreamExecSink only extended from ExecNode*
- *Introduce BatchPhysicalSink, and make BatchExecSink only extended from ExecNode*
- *Introduce StreamPhysicalLegacySink, and make StreamExecLegacySink only extended from ExecNode*
- *Introduce BatchPhysicalLegacySink, and make BatchExecLegacySink only extended from ExecNode*
- *BatchCommonSubGraphBasedOptimizer should also consider Sink node*
## Verifying this change
This change is a refactoring rework covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 239ef8b6247ed788b421aa0e65921dd1fa490842 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063)
* 8e20c81e5253a8b6a8ab9efb929e6413a97fce70 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
}, {
"hash" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211",
"triggerID" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2db6f3e6c725c09b24e919ea6cc45537be86d35 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #14637:
URL: https://github.com/apache/flink/pull/14637#discussion_r559471925
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java
##########
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.common;
+
+import org.apache.flink.api.common.io.OutputFormat;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.api.java.typeutils.InputTypeConfigurable;
+import org.apache.flink.runtime.state.KeyGroupRangeAssignment;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.sink.OutputFormatSinkFunction;
+import org.apache.flink.streaming.api.functions.sink.SinkFunction;
+import org.apache.flink.streaming.api.operators.SimpleOperatorFactory;
+import org.apache.flink.streaming.api.transformations.LegacySinkTransformation;
+import org.apache.flink.streaming.api.transformations.PartitionTransformation;
+import org.apache.flink.streaming.runtime.partitioner.KeyGroupStreamPartitioner;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.api.config.ExecutionConfigOptions;
+import org.apache.flink.table.catalog.CatalogTable;
+import org.apache.flink.table.connector.ChangelogMode;
+import org.apache.flink.table.connector.ParallelismProvider;
+import org.apache.flink.table.connector.sink.DataStreamSinkProvider;
+import org.apache.flink.table.connector.sink.DynamicTableSink;
+import org.apache.flink.table.connector.sink.OutputFormatProvider;
+import org.apache.flink.table.connector.sink.SinkFunctionProvider;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.utils.KeySelectorUtil;
+import org.apache.flink.table.planner.sinks.TableSinkUtils;
+import org.apache.flink.table.runtime.connector.sink.SinkRuntimeProviderContext;
+import org.apache.flink.table.runtime.keyselector.RowDataKeySelector;
+import org.apache.flink.table.runtime.operators.sink.SinkNotNullEnforcer;
+import org.apache.flink.table.runtime.operators.sink.SinkOperator;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.table.utils.TableSchemaUtils;
+import org.apache.flink.types.RowKind;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+/**
+ * Base {@link ExecNode} to write data to an external sink defined by a {@link DynamicTableSink}.
+ */
+public abstract class CommonExecSink extends ExecNodeBase<Object> {
+ protected final List<String> qualifiedName;
+ private final CatalogTable catalogTable;
+ private final DynamicTableSink tableSink;
+ private final ChangelogMode changelogMode;
+ private final boolean isBounded;
+
+ public CommonExecSink(
+ List<String> qualifiedName,
+ CatalogTable catalogTable,
+ DynamicTableSink tableSink,
+ ChangelogMode changelogMode,
Review comment:
it may be better to use inputChangeLogMode here, because we may need to tell table sink the changelog mode again when rebuild the exec node.
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java
##########
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.common;
+
+import org.apache.flink.api.common.io.OutputFormat;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.api.java.typeutils.InputTypeConfigurable;
+import org.apache.flink.runtime.state.KeyGroupRangeAssignment;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.sink.OutputFormatSinkFunction;
+import org.apache.flink.streaming.api.functions.sink.SinkFunction;
+import org.apache.flink.streaming.api.operators.SimpleOperatorFactory;
+import org.apache.flink.streaming.api.transformations.LegacySinkTransformation;
+import org.apache.flink.streaming.api.transformations.PartitionTransformation;
+import org.apache.flink.streaming.runtime.partitioner.KeyGroupStreamPartitioner;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.api.config.ExecutionConfigOptions;
+import org.apache.flink.table.catalog.CatalogTable;
+import org.apache.flink.table.connector.ChangelogMode;
+import org.apache.flink.table.connector.ParallelismProvider;
+import org.apache.flink.table.connector.sink.DataStreamSinkProvider;
+import org.apache.flink.table.connector.sink.DynamicTableSink;
+import org.apache.flink.table.connector.sink.OutputFormatProvider;
+import org.apache.flink.table.connector.sink.SinkFunctionProvider;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.utils.KeySelectorUtil;
+import org.apache.flink.table.planner.sinks.TableSinkUtils;
+import org.apache.flink.table.runtime.connector.sink.SinkRuntimeProviderContext;
+import org.apache.flink.table.runtime.keyselector.RowDataKeySelector;
+import org.apache.flink.table.runtime.operators.sink.SinkNotNullEnforcer;
+import org.apache.flink.table.runtime.operators.sink.SinkOperator;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.table.utils.TableSchemaUtils;
+import org.apache.flink.types.RowKind;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+/**
+ * Base {@link ExecNode} to write data to an external sink defined by a {@link DynamicTableSink}.
+ */
+public abstract class CommonExecSink extends ExecNodeBase<Object> {
+ protected final List<String> qualifiedName;
+ private final CatalogTable catalogTable;
Review comment:
the catalog table here is not necessary, just TableSchema needed? tableSchema + tableSink to describe a table sink.
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java
##########
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.common;
+
+import org.apache.flink.api.common.io.OutputFormat;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.api.java.typeutils.InputTypeConfigurable;
+import org.apache.flink.runtime.state.KeyGroupRangeAssignment;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
+import org.apache.flink.streaming.api.functions.sink.OutputFormatSinkFunction;
+import org.apache.flink.streaming.api.functions.sink.SinkFunction;
+import org.apache.flink.streaming.api.operators.SimpleOperatorFactory;
+import org.apache.flink.streaming.api.transformations.LegacySinkTransformation;
+import org.apache.flink.streaming.api.transformations.PartitionTransformation;
+import org.apache.flink.streaming.runtime.partitioner.KeyGroupStreamPartitioner;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.api.config.ExecutionConfigOptions;
+import org.apache.flink.table.catalog.CatalogTable;
+import org.apache.flink.table.connector.ChangelogMode;
+import org.apache.flink.table.connector.ParallelismProvider;
+import org.apache.flink.table.connector.sink.DataStreamSinkProvider;
+import org.apache.flink.table.connector.sink.DynamicTableSink;
+import org.apache.flink.table.connector.sink.OutputFormatProvider;
+import org.apache.flink.table.connector.sink.SinkFunctionProvider;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.utils.KeySelectorUtil;
+import org.apache.flink.table.planner.sinks.TableSinkUtils;
+import org.apache.flink.table.runtime.connector.sink.SinkRuntimeProviderContext;
+import org.apache.flink.table.runtime.keyselector.RowDataKeySelector;
+import org.apache.flink.table.runtime.operators.sink.SinkNotNullEnforcer;
+import org.apache.flink.table.runtime.operators.sink.SinkOperator;
+import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.table.utils.TableSchemaUtils;
+import org.apache.flink.types.RowKind;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+/**
+ * Base {@link ExecNode} to write data to an external sink defined by a {@link DynamicTableSink}.
+ */
+public abstract class CommonExecSink extends ExecNodeBase<Object> {
+ protected final List<String> qualifiedName;
+ private final CatalogTable catalogTable;
+ private final DynamicTableSink tableSink;
+ private final ChangelogMode changelogMode;
+ private final boolean isBounded;
+
+ public CommonExecSink(
+ List<String> qualifiedName,
+ CatalogTable catalogTable,
+ DynamicTableSink tableSink,
+ ChangelogMode changelogMode,
+ boolean isBounded,
+ ExecEdge inputEdge,
+ LogicalType outputType,
+ String description) {
+ super(Collections.singletonList(inputEdge), outputType, description);
+ this.tableSink = tableSink;
+ this.qualifiedName = qualifiedName;
+ this.catalogTable = catalogTable;
+ this.changelogMode = changelogMode;
+ this.isBounded = isBounded;
+ }
+
+ protected Transformation<Object> createSinkTransformation(
+ StreamExecutionEnvironment env,
+ TableConfig tableConfig,
+ Transformation<RowData> inputTransform,
+ int rowtimeFieldIndex) {
+ final DynamicTableSink.SinkRuntimeProvider runtimeProvider =
+ tableSink.getSinkRuntimeProvider(new SinkRuntimeProviderContext(isBounded));
+
+ final ExecutionConfigOptions.NotNullEnforcer notNullEnforcer =
+ tableConfig
+ .getConfiguration()
+ .get(ExecutionConfigOptions.TABLE_EXEC_SINK_NOT_NULL_ENFORCER);
+ final int[] notNullFieldIndices = TableSinkUtils.getNotNullFieldIndices(catalogTable);
+ final String[] fieldNames =
+ ((RowType) catalogTable.getSchema().toPhysicalRowDataType().getLogicalType())
+ .getFieldNames()
+ .toArray(new String[0]);
+ final SinkNotNullEnforcer enforcer =
+ new SinkNotNullEnforcer(notNullEnforcer, notNullFieldIndices, fieldNames);
+ final InternalTypeInfo<RowData> inputTypeInfo =
+ InternalTypeInfo.of(getInputNodes().get(0).getOutputType());
+
+ if (runtimeProvider instanceof DataStreamSinkProvider) {
+ if (runtimeProvider instanceof ParallelismProvider) {
+ throw new TableException(
+ "`DataStreamSinkProvider` is not allowed to work with"
+ + " `ParallelismProvider`, "
+ + "please see document of `ParallelismProvider`");
+ } else {
+ final DataStream<RowData> dataStream =
+ new DataStream<>(env, inputTransform).filter(enforcer);
+ final DataStreamSinkProvider provider = (DataStreamSinkProvider) runtimeProvider;
+ return provider.consumeDataStream(dataStream).getTransformation();
+ }
+ } else {
+ final SinkFunction<RowData> sinkFunction;
+ if (runtimeProvider instanceof SinkFunctionProvider) {
+ sinkFunction = ((SinkFunctionProvider) runtimeProvider).createSinkFunction();
+ } else if (runtimeProvider instanceof OutputFormatProvider) {
+ OutputFormat<RowData> outputFormat =
+ ((OutputFormatProvider) runtimeProvider).createOutputFormat();
+ sinkFunction = new OutputFormatSinkFunction<>(outputFormat);
+ } else {
+ throw new TableException("This should not happen.");
+ }
+
+ if (sinkFunction instanceof InputTypeConfigurable) {
+ ((InputTypeConfigurable) sinkFunction).setInputType(inputTypeInfo, env.getConfig());
+ }
+
+ final SinkOperator operator =
+ new SinkOperator(env.clean(sinkFunction), rowtimeFieldIndex, enforcer);
Review comment:
add check that runtimeProvider implements ParallelismProvider, assert in scala
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028)
* afd1a28c76fbfc06338673821228f041812618cb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afd1a28c76fbfc06338673821228f041812618cb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036)
* 239ef8b6247ed788b421aa0e65921dd1fa490842 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759975866
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d (Thu Jan 14 07:13:31 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e6f8afb27e427f04a3336e643476f57c482cc6e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e20c81e5253a8b6a8ab9efb929e6413a97fce70 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085)
* 6400000270670c3ce146147fa7f0fd0f7305d8aa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
}, {
"hash" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211",
"triggerID" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"triggerType" : "PUSH"
}, {
"hash" : "e02d849c359db923aa91235d9756f055cb44c362",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12223",
"triggerID" : "e02d849c359db923aa91235d9756f055cb44c362",
"triggerType" : "PUSH"
}, {
"hash" : "95974173ac12fccb8dbbd2c80a06546a5d04372d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12240",
"triggerID" : "95974173ac12fccb8dbbd2c80a06546a5d04372d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e02d849c359db923aa91235d9756f055cb44c362 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12223)
* 95974173ac12fccb8dbbd2c80a06546a5d04372d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12240)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
}, {
"hash" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211",
"triggerID" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"triggerType" : "PUSH"
}, {
"hash" : "e02d849c359db923aa91235d9756f055cb44c362",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e02d849c359db923aa91235d9756f055cb44c362",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2db6f3e6c725c09b24e919ea6cc45537be86d35 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211)
* e02d849c359db923aa91235d9756f055cb44c362 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 239ef8b6247ed788b421aa0e65921dd1fa490842 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
}, {
"hash" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e6f8afb27e427f04a3336e643476f57c482cc6e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180)
* 5e0f4982e094db9168e2f32e604776a7a40e0849 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206)
* f2db6f3e6c725c09b24e919ea6cc45537be86d35 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
}, {
"hash" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211",
"triggerID" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"triggerType" : "PUSH"
}, {
"hash" : "e02d849c359db923aa91235d9756f055cb44c362",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12223",
"triggerID" : "e02d849c359db923aa91235d9756f055cb44c362",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2db6f3e6c725c09b24e919ea6cc45537be86d35 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211)
* e02d849c359db923aa91235d9756f055cb44c362 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12223)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6400000270670c3ce146147fa7f0fd0f7305d8aa Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e6f8afb27e427f04a3336e643476f57c482cc6e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180)
* 5e0f4982e094db9168e2f32e604776a7a40e0849 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
}, {
"hash" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211",
"triggerID" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e0f4982e094db9168e2f32e604776a7a40e0849 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206)
* f2db6f3e6c725c09b24e919ea6cc45537be86d35 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028)
* afd1a28c76fbfc06338673821228f041812618cb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-762216663
Thanks for the review @wenlong88 , I have updated the pr based on comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759975866
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 95974173ac12fccb8dbbd2c80a06546a5d04372d (Fri May 28 07:11:02 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 239ef8b6247ed788b421aa0e65921dd1fa490842 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063)
* 8e20c81e5253a8b6a8ab9efb929e6413a97fce70 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afd1a28c76fbfc06338673821228f041812618cb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
}, {
"hash" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211",
"triggerID" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e6f8afb27e427f04a3336e643476f57c482cc6e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180)
* 5e0f4982e094db9168e2f32e604776a7a40e0849 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206)
* f2db6f3e6c725c09b24e919ea6cc45537be86d35 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #14637:
URL: https://github.com/apache/flink/pull/14637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6400000270670c3ce146147fa7f0fd0f7305d8aa Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094)
* 2e6f8afb27e427f04a3336e643476f57c482cc6e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8e20c81e5253a8b6a8ab9efb929e6413a97fce70 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085)
* 6400000270670c3ce146147fa7f0fd0f7305d8aa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* afd1a28c76fbfc06338673821228f041812618cb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036)
* 239ef8b6247ed788b421aa0e65921dd1fa490842 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wenlong88 commented on a change in pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
wenlong88 commented on a change in pull request #14637:
URL: https://github.com/apache/flink/pull/14637#discussion_r559890485
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLegacySink.java
##########
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.common;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.datastream.DataStreamSink;
+import org.apache.flink.streaming.api.transformations.OneInputTransformation;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.codegen.CodeGenUtils;
+import org.apache.flink.table.planner.codegen.CodeGeneratorContext;
+import org.apache.flink.table.planner.codegen.SinkCodeGenerator;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.sinks.DataStreamTableSink;
+import org.apache.flink.table.planner.sinks.TableSinkUtils;
+import org.apache.flink.table.runtime.operators.CodeGenOperatorFactory;
+import org.apache.flink.table.sinks.AppendStreamTableSink;
+import org.apache.flink.table.sinks.RetractStreamTableSink;
+import org.apache.flink.table.sinks.StreamTableSink;
+import org.apache.flink.table.sinks.TableSink;
+import org.apache.flink.table.sinks.UpsertStreamTableSink;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+
+import javax.annotation.Nullable;
+
+import java.util.Collections;
+
+/**
+ * Base {@link ExecNode} to to write data into an external sink defined by a {@link TableSink}.
+ *
+ * @param <T> The return type of the {@link TableSink}.
+ */
+public abstract class CommonExecLegacySink<T> extends ExecNodeBase<Object> {
+ protected final TableSink<T> tableSink;
+ protected final @Nullable String[] upsertKeys;
+ protected final boolean needRetraction;
+
+ public CommonExecLegacySink(
+ TableSink<T> tableSink,
+ @Nullable String[] upsertKeys,
+ boolean needRetraction,
+ ExecEdge inputEdge,
+ LogicalType outputType,
+ String description) {
+ super(Collections.singletonList(inputEdge), outputType, description);
+ this.tableSink = tableSink;
+ this.upsertKeys = upsertKeys;
+ this.needRetraction = needRetraction;
+ }
+
+ @SuppressWarnings("unchecked")
+ @Override
+ protected Transformation<Object> translateToPlanInternal(PlannerBase planner) {
+ if (tableSink instanceof StreamTableSink) {
+ final Transformation<T> transform;
+ if (tableSink instanceof RetractStreamTableSink) {
+ transform = translateToTransformation(planner, true);
+ } else if (tableSink instanceof UpsertStreamTableSink) {
+ UpsertStreamTableSink<T> upsertSink = (UpsertStreamTableSink<T>) tableSink;
+ final boolean isAppendOnlyTable = !needRetraction;
+ upsertSink.setIsAppendOnly(isAppendOnlyTable);
+ if (upsertKeys != null) {
+ upsertSink.setKeyFields(upsertKeys);
+ } else {
+ if (isAppendOnlyTable) {
+ upsertSink.setKeyFields(null);
+ } else {
+ throw new TableException(
+ "UpsertStreamTableSink requires that Table has a full primary keys if it is updated.");
+ }
+ }
+
+ transform = translateToTransformation(planner, true);
+ } else if (tableSink instanceof AppendStreamTableSink) {
+ // verify table is an insert-only (append-only) table
+ if (needRetraction) {
+ throw new TableException(
+ "AppendStreamTableSink requires that Table has only insert changes.");
+ }
+ transform = translateToTransformation(planner, false);
+ } else {
+ throw new TableException(
+ "Stream Tables can only be emitted by AppendStreamTableSink, "
+ + "RetractStreamTableSink, or UpsertStreamTableSink.");
+ }
+
+ final DataStream<T> dataStream = new DataStream<T>(planner.getExecEnv(), transform);
+ final DataStreamSink<?> dsSink =
+ ((StreamTableSink<T>) tableSink).consumeDataStream(dataStream);
+ if (dsSink == null) {
+ throw new TableException(
+ String.format(
+ "The StreamTableSink#consumeDataStream(DataStream) must be implemented "
+ + "and return the sink transformation DataStreamSink. "
+ + "However, %s doesn't implement this method.",
+ tableSink.getClass().getCanonicalName()));
+ }
+ return dsSink.getTransformation();
+ } else if (tableSink instanceof DataStreamTableSink) {
+ // In case of table to DataStream through
+ // StreamTableEnvironment#toAppendStream/toRetractStream,
+ // we insert a DataStreamTableSink that wraps the given DataStream as a LogicalSink. It
+ // is no real table sink, so we just need translate its input to Transformation.
+ return (Transformation<Object>)
+ translateToTransformation(
+ planner, ((DataStreamTableSink<T>) tableSink).withChangeFlag());
+ } else {
+ throw new TableException(
+ String.format(
+ "Only Support StreamTableSink! However %s is not a StreamTableSink.",
+ tableSink.getClass().getCanonicalName()));
+ }
+ }
+
+ /**
+ * Translates {@link TableSink} into a {@link Transformation}.
+ *
+ * @param withChangeFlag Set to true to emit records with change flags.
+ * @return The {@link Transformation} that corresponds to the translated {@link TableSink}.
+ */
+ protected abstract Transformation<T> translateToTransformation(
Review comment:
how about we just make the abstract interface which just returns the converted inputRowType, like: createActualSinkInputType. the name and logic is a bit of confusing here.
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLegacySink.java
##########
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.common;
+
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.streaming.api.datastream.DataStream;
+import org.apache.flink.streaming.api.datastream.DataStreamSink;
+import org.apache.flink.streaming.api.transformations.OneInputTransformation;
+import org.apache.flink.table.api.TableConfig;
+import org.apache.flink.table.api.TableException;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.codegen.CodeGenUtils;
+import org.apache.flink.table.planner.codegen.CodeGeneratorContext;
+import org.apache.flink.table.planner.codegen.SinkCodeGenerator;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecEdge;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNode;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.sinks.DataStreamTableSink;
+import org.apache.flink.table.planner.sinks.TableSinkUtils;
+import org.apache.flink.table.runtime.operators.CodeGenOperatorFactory;
+import org.apache.flink.table.sinks.AppendStreamTableSink;
+import org.apache.flink.table.sinks.RetractStreamTableSink;
+import org.apache.flink.table.sinks.StreamTableSink;
+import org.apache.flink.table.sinks.TableSink;
+import org.apache.flink.table.sinks.UpsertStreamTableSink;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+
+import javax.annotation.Nullable;
+
+import java.util.Collections;
+
+/**
+ * Base {@link ExecNode} to to write data into an external sink defined by a {@link TableSink}.
+ *
+ * @param <T> The return type of the {@link TableSink}.
+ */
+public abstract class CommonExecLegacySink<T> extends ExecNodeBase<Object> {
+ protected final TableSink<T> tableSink;
+ protected final @Nullable String[] upsertKeys;
+ protected final boolean needRetraction;
+
+ public CommonExecLegacySink(
+ TableSink<T> tableSink,
+ @Nullable String[] upsertKeys,
+ boolean needRetraction,
+ ExecEdge inputEdge,
+ LogicalType outputType,
+ String description) {
+ super(Collections.singletonList(inputEdge), outputType, description);
+ this.tableSink = tableSink;
+ this.upsertKeys = upsertKeys;
+ this.needRetraction = needRetraction;
+ }
+
+ @SuppressWarnings("unchecked")
+ @Override
+ protected Transformation<Object> translateToPlanInternal(PlannerBase planner) {
+ if (tableSink instanceof StreamTableSink) {
+ final Transformation<T> transform;
+ if (tableSink instanceof RetractStreamTableSink) {
+ transform = translateToTransformation(planner, true);
+ } else if (tableSink instanceof UpsertStreamTableSink) {
+ UpsertStreamTableSink<T> upsertSink = (UpsertStreamTableSink<T>) tableSink;
+ final boolean isAppendOnlyTable = !needRetraction;
+ upsertSink.setIsAppendOnly(isAppendOnlyTable);
+ if (upsertKeys != null) {
+ upsertSink.setKeyFields(upsertKeys);
+ } else {
+ if (isAppendOnlyTable) {
+ upsertSink.setKeyFields(null);
+ } else {
+ throw new TableException(
+ "UpsertStreamTableSink requires that Table has a full primary keys if it is updated.");
+ }
+ }
+
+ transform = translateToTransformation(planner, true);
+ } else if (tableSink instanceof AppendStreamTableSink) {
+ // verify table is an insert-only (append-only) table
+ if (needRetraction) {
+ throw new TableException(
+ "AppendStreamTableSink requires that Table has only insert changes.");
+ }
+ transform = translateToTransformation(planner, false);
+ } else {
+ throw new TableException(
+ "Stream Tables can only be emitted by AppendStreamTableSink, "
+ + "RetractStreamTableSink, or UpsertStreamTableSink.");
+ }
+
+ final DataStream<T> dataStream = new DataStream<T>(planner.getExecEnv(), transform);
+ final DataStreamSink<?> dsSink =
+ ((StreamTableSink<T>) tableSink).consumeDataStream(dataStream);
+ if (dsSink == null) {
+ throw new TableException(
+ String.format(
+ "The StreamTableSink#consumeDataStream(DataStream) must be implemented "
+ + "and return the sink transformation DataStreamSink. "
+ + "However, %s doesn't implement this method.",
+ tableSink.getClass().getCanonicalName()));
+ }
+ return dsSink.getTransformation();
+ } else if (tableSink instanceof DataStreamTableSink) {
+ // In case of table to DataStream through
+ // StreamTableEnvironment#toAppendStream/toRetractStream,
+ // we insert a DataStreamTableSink that wraps the given DataStream as a LogicalSink. It
+ // is no real table sink, so we just need translate its input to Transformation.
+ return (Transformation<Object>)
+ translateToTransformation(
+ planner, ((DataStreamTableSink<T>) tableSink).withChangeFlag());
+ } else {
+ throw new TableException(
+ String.format(
+ "Only Support StreamTableSink! However %s is not a StreamTableSink.",
+ tableSink.getClass().getCanonicalName()));
+ }
+ }
+
+ /**
+ * Translates {@link TableSink} into a {@link Transformation}.
+ *
+ * @param withChangeFlag Set to true to emit records with change flags.
+ * @return The {@link Transformation} that corresponds to the translated {@link TableSink}.
+ */
+ protected abstract Transformation<T> translateToTransformation(
+ PlannerBase planner, boolean withChangeFlag);
+
+ @SuppressWarnings("unchecked")
+ protected Transformation<T> createSinkTransformation(
Review comment:
rename to: createSinkInputTransformation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6400000270670c3ce146147fa7f0fd0f7305d8aa Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094)
* 2e6f8afb27e427f04a3336e643476f57c482cc6e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2e6f8afb27e427f04a3336e643476f57c482cc6e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180)
* 5e0f4982e094db9168e2f32e604776a7a40e0849 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
}, {
"hash" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211",
"triggerID" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"triggerType" : "PUSH"
}, {
"hash" : "e02d849c359db923aa91235d9756f055cb44c362",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12223",
"triggerID" : "e02d849c359db923aa91235d9756f055cb44c362",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e02d849c359db923aa91235d9756f055cb44c362 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12223)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14637: [FLINK-20949][table-planner-blink] Separate the implementation of sink nodes
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14637:
URL: https://github.com/apache/flink/pull/14637#issuecomment-759980085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12028",
"triggerID" : "8b2bf9a0a0d1c74ea4a6d1712dccb415dcd34a4d",
"triggerType" : "PUSH"
}, {
"hash" : "afd1a28c76fbfc06338673821228f041812618cb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12036",
"triggerID" : "afd1a28c76fbfc06338673821228f041812618cb",
"triggerType" : "PUSH"
}, {
"hash" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12063",
"triggerID" : "239ef8b6247ed788b421aa0e65921dd1fa490842",
"triggerType" : "PUSH"
}, {
"hash" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12085",
"triggerID" : "8e20c81e5253a8b6a8ab9efb929e6413a97fce70",
"triggerType" : "PUSH"
}, {
"hash" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12094",
"triggerID" : "6400000270670c3ce146147fa7f0fd0f7305d8aa",
"triggerType" : "PUSH"
}, {
"hash" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12180",
"triggerID" : "2e6f8afb27e427f04a3336e643476f57c482cc6e",
"triggerType" : "PUSH"
}, {
"hash" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12206",
"triggerID" : "5e0f4982e094db9168e2f32e604776a7a40e0849",
"triggerType" : "PUSH"
}, {
"hash" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12211",
"triggerID" : "f2db6f3e6c725c09b24e919ea6cc45537be86d35",
"triggerType" : "PUSH"
}, {
"hash" : "e02d849c359db923aa91235d9756f055cb44c362",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12223",
"triggerID" : "e02d849c359db923aa91235d9756f055cb44c362",
"triggerType" : "PUSH"
}, {
"hash" : "95974173ac12fccb8dbbd2c80a06546a5d04372d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "95974173ac12fccb8dbbd2c80a06546a5d04372d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e02d849c359db923aa91235d9756f055cb44c362 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12223)
* 95974173ac12fccb8dbbd2c80a06546a5d04372d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org