[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #203: [FLINK-28437] Document Engine Matrix and Build page

[GitBox <gi...@apache.org>]

tsreaper commented on code in PR #203:
URL: https://github.com/apache/flink-table-store/pull/203#discussion_r915685924


##########
docs/content/docs/development/write-table.md:
##########
@@ -186,9 +186,8 @@ The following parameters determine when to stop writing:
 ## Memory
 
 There are three main places in the Table Store's sink writer that take up memory:
-- MemTable's write buffer, which is individually occupied by each partition, each
-  bucket, and this memory value can be adjustable by the `write-buffer-size`
-  option (default 64 MB).
+- MemTable's write buffer, which is shared and preempted by all writers of a single Task,
+  this memory value can be adjustable by the `write-buffer-size` option.

Review Comment:
   single Task, this memory... -> single task. This memory...
   
   be adjustable -> be adjusted



##########
docs/content/docs/development/write-table.md:
##########
@@ -186,9 +186,8 @@ The following parameters determine when to stop writing:
 ## Memory
 
 There are three main places in the Table Store's sink writer that take up memory:
-- MemTable's write buffer, which is individually occupied by each partition, each
-  bucket, and this memory value can be adjustable by the `write-buffer-size`
-  option (default 64 MB).
+- MemTable's write buffer, which is shared and preempted by all writers of a single Task,
+  this memory value can be adjustable by the `write-buffer-size` option.
 - The memory consumed by compaction for reading files, it can be adjusted by the
   `num-sorted-run.compaction-trigger` option to change the maximum number of files to be merged.
-- The memory consumed by writing file, which is not adjustable.
+- The memory consumed by writing columnar(ORC) file, which is not adjustable.

Review Comment:
   columnar (ORC)



##########
docs/content/docs/engines/build.md:
##########
@@ -0,0 +1,63 @@
+---
+title: "Build"
+weight: 2
+type: docs
+aliases:
+- /engines/build.html
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Build

Review Comment:
   Build from Source



##########
docs/content/docs/engines/build.md:
##########
@@ -0,0 +1,63 @@
+---
+title: "Build"
+weight: 2
+type: docs
+aliases:
+- /engines/build.html
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Build
+
+In order to build Table Store engine jars you need the source code.

Review Comment:
   Remove this line.



##########
docs/content/docs/engines/build.md:
##########
@@ -0,0 +1,63 @@
+---
+title: "Build"
+weight: 2
+type: docs
+aliases:
+- /engines/build.html
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Build
+
+In order to build Table Store engine jars you need the source code.
+
+To clone from git, enter:
+
+```bash
+git clone {{< github_repo >}}
+```
+
+The simplest way of building Table Store is by running:
+
+```bash
+mvn clean install -DskipTests
+```
+
+## Flink 1.15
+
+You can find Flink 1.15 bundled jar in `./flink-table-store-dist/target/flink-table-store-dist-{{< version >}}.jar`.
+
+## Hive
+
+You can find Hive bundled jar in `./flink-table-store-hive/flink-table-store-hive-connector/target/flink-table-store-hive-connector-{{< version >}}.jar`.
+
+## Spark
+
+You can find Spark bundled jar in `./flink-table-store-spark/target/flink-table-store-spark-{{< version >}}.jar`.

Review Comment:
   No need. Documentations of each engine already contain this information.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org