You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/28 21:20:53 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4128: Make arrow_json::ReaderBuilder method names consistent

tustvold commented on code in PR #4128:
URL: https://github.com/apache/arrow-rs/pull/4128#discussion_r1180827476


##########
arrow-json/src/reader/mod.rs:
##########
@@ -193,8 +193,16 @@ impl ReaderBuilder {
         Self { batch_size, ..self }
     }
 
-    /// Sets if the decoder should coerce primitive values (bool and number) into string when the Schema's column is Utf8 or LargeUtf8.
+    /// Sets if the decoder should coerce primitive values (bool and number) into string
+    /// when the Schema's column is Utf8 or LargeUtf8.
+    #[deprecated(note = "Use with_coerce_primitive")]

Review Comment:
   I personally think the git history is more useful for this, but if you feel strongly...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org