You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2022/05/12 17:20:27 UTC

[groovy] branch danielsun/lab-indy-20220512 updated (48f8e95112 -> aad0129a4a)

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a change to branch danielsun/lab-indy-20220512
in repository https://gitbox.apache.org/repos/asf/groovy.git


 discard 48f8e95112 Remove guards for receiver and parameter
     new aad0129a4a Avoid unnecessary guards for receiver and parameter

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (48f8e95112)
            \
             N -- N -- N   refs/heads/danielsun/lab-indy-20220512 (aad0129a4a)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../org/codehaus/groovy/vmplugin/v8/Selector.java  | 48 +++++++++++-----------
 1 file changed, 25 insertions(+), 23 deletions(-)


[groovy] 01/01: Avoid unnecessary guards for receiver and parameter

Posted by su...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch danielsun/lab-indy-20220512
in repository https://gitbox.apache.org/repos/asf/groovy.git

commit aad0129a4a298da61d9fc96bb5cae93d1f1d3b35
Author: Daniel Sun <su...@apache.org>
AuthorDate: Fri May 13 01:13:23 2022 +0800

    Avoid unnecessary guards for receiver and parameter
---
 src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java b/src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java
index 3301c18225..dadeb8d1bb 100644
--- a/src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java
+++ b/src/main/java/org/codehaus/groovy/vmplugin/v8/Selector.java
@@ -934,7 +934,8 @@ public abstract class Selector {
                 } else {
                     Class<?> argClass = arg.getClass();
                     if (paramType.isPrimitive()) continue;
-                    //if (Modifier.isFinal(argClass.getModifiers()) && TypeHelper.argumentClassIsParameterClass(argClass,pt[i])) continue;
+                    if (Modifier.isFinal(paramType.getModifiers()) && TypeHelper.argumentClassIsParameterClass(argClass, paramType))
+                        continue;
                     test = SAME_CLASS.
                             bindTo(argClass).
                             asType(MethodType.methodType(boolean.class, paramType));