[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15352: Update azure connection documentation

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #15352:
URL: https://github.com/apache/airflow/pull/15352#discussion_r612840132



##########
File path: airflow/providers/microsoft/azure/hooks/azure_container_volume.py
##########
@@ -27,6 +27,11 @@ class AzureContainerVolumeHook(BaseHook):
 
     :param wasb_conn_id: connection id of a Azure storage account of
         which file shares should be mounted
+
+        .. seealso::
+            See the docs for information on how to setup this connection:
+            :ref:`howto/connection:wasp`

Review comment:
       ```suggestion
               :ref:`howto/connection:wasb`
   ```

##########
File path: airflow/providers/microsoft/azure/hooks/azure_fileshare.py
##########
@@ -31,6 +31,11 @@ class AzureFileShareHook(BaseHook):
     passed to the `FileService()` constructor.
 
     :param wasb_conn_id: Reference to the wasb connection.
+
+        .. seealso::
+            See the docs for information on how to setup this connection:
+            :ref:`howto/connection:wasp`

Review comment:
       ```suggestion
               :ref:`howto/connection:wasb`
   ```

##########
File path: docs/apache-airflow-providers-microsoft-azure/connections/wasp.rst
##########
@@ -0,0 +1,84 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+ ..   http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
+
+

Review comment:
       We should rename this file to wasb.rst? and make other corrections in different places




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org