You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by bu...@apache.org on 2010/11/05 13:59:25 UTC

DO NOT REPLY [Bug 50221] New: Renaming elements in the tree does not resize label

https://issues.apache.org/bugzilla/show_bug.cgi?id=50221

           Summary: Renaming elements in the tree does not resize label
           Product: JMeter
           Version: 2.4
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Main
        AssignedTo: notifications@jakarta.apache.org
        ReportedBy: jens_0@hotmail.com


Often, when test elements are renamed, their label in the test tree does not
resize: When the name is longer than before, it is displayed with "...", if the
name is shorter than before, it the blue selection box is too large.

This can be fixed by expanding or collapsing the element, in case it has
children.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 50221] Renaming elements in the tree does not resize label

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50221

jens_0@hotmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #4 from jens_0@hotmail.com 2011-07-20 09:09:08 UTC ---
I get null pointer exceptions sometimes when opening large test plans at the
start of JMeter.

This solved the problem:

JMeterTreeNode.java:
    /** {@inheritDoc} */
    public void nameChanged() {
+       if (treeModel != null) {
            treeModel.nodeChanged(this);
+        }
    }

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 50221] Renaming elements in the tree does not resize label

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50221

Milamber <mi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Milamber <mi...@apache.org> 2011-07-20 22:13:50 UTC ---
Thanks for your comment.

Sebb have correct this since few month.

http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeNode.java?r1=1066798&r2=1066797&pathrev=1066798

http://svn.apache.org/viewvc?view=revision&revision=1066798

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 50221] Renaming elements in the tree does not resize label

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50221

--- Comment #2 from jens_0@hotmail.com 2011-02-02 11:00:34 EST ---
The method JMeterTreeNode.nameChanged() is never called but fixes this.

It needs to be called on the right moment, probably on the node that just is
left when changing the focus. The only events that I found are raised too late:
They are applied on the node that is switched to, but if you switch back to the
node with short label "..." then it helps:
JMeterTreeListener.mouseclicked:
    getCurrentNode().nameChanged();

So this only solves it halfway. It can't be that difficult?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 50221] Renaming elements in the tree does not resize label

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50221

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Sebb <se...@apache.org> 2011-02-02 11:30:45 EST ---
Thanks for that insight - I have found the place in GuiPackage where the GUI
fields are saved when changing node. Adding a call to nameChanged() seems to
fix the issue:

URL: http://svn.apache.org/viewvc?rev=1066517&view=rev
Log:
Bug 50221 - Renaming elements in the tree does not resize label

Modified:
   jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/GuiPackage.java
   jakarta/jmeter/trunk/xdocs/changes.xml

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


DO NOT REPLY [Bug 50221] Renaming elements in the tree does not resize label

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50221

--- Comment #1 from Sebb <se...@apache.org> 2010-11-05 10:59:53 EDT ---
Or by disabling and re-enabling the element...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org