You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/22 07:14:52 UTC
[GitHub] [flink] wanglijie95 opened a new pull request, #20341: [FLINK-28640][runtime] Allow BlocklistDeclarativeSlotPool to accept duplicate slot offers
wanglijie95 opened a new pull request, #20341:
URL: https://github.com/apache/flink/pull/20341
## What is the purpose of the change
BlocklistDeclarativeSlotPool should accept a duplicate (already accepted) slot, even if it's from a currently blocked task manager. Because the slot may already be assigned to an execution, rejecting it will cause a task failover.
## Verifying this change
`BlocklistDeclarativeSlotPoolTest#testOfferDuplicateSlots`
`BlocklistDeclarativeSlotPoolTest#testRegisterDuplicateSlots`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
- The serializers: (**no**)
- The runtime per-record code paths (performance sensitive): (**no**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (**no**)
- The S3 file system connector: (**no**)
## Documentation
- Does this pull request introduce a new feature? (**no**)
- If yes, how is the feature documented? (**not applicable**)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20341: [FLINK-28640][runtime] Let BlocklistDeclarativeSlotPool accept duplicate slot offers
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20341:
URL: https://github.com/apache/flink/pull/20341#issuecomment-1192272975
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8180de5d8cd2940a1a46e0a84364d71746d1a135",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8180de5d8cd2940a1a46e0a84364d71746d1a135",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8180de5d8cd2940a1a46e0a84364d71746d1a135 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #20341: [FLINK-28640][runtime] Let BlocklistDeclarativeSlotPool accept duplicate slot offers
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on PR #20341:
URL: https://github.com/apache/flink/pull/20341#issuecomment-1192544056
Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk closed pull request #20341: [FLINK-28640][runtime] Let BlocklistDeclarativeSlotPool accept duplicate slot offers
Posted by GitBox <gi...@apache.org>.
zhuzhurk closed pull request #20341: [FLINK-28640][runtime] Let BlocklistDeclarativeSlotPool accept duplicate slot offers
URL: https://github.com/apache/flink/pull/20341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a diff in pull request #20341: [FLINK-28640][runtime] Let BlocklistDeclarativeSlotPool accept duplicate slot offers
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on code in PR #20341:
URL: https://github.com/apache/flink/pull/20341#discussion_r927412543
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/BlocklistDeclarativeSlotPool.java:
##########
@@ -90,11 +90,29 @@ public Collection<SlotOffer> registerSlots(
if (!isBlockedTaskManager(taskManagerLocation.getResourceID())) {
return super.registerSlots(slots, taskManagerLocation, taskManagerGateway, currentTime);
} else {
- LOG.debug("Reject slots {} from a blocked TaskManager {}.", slots, taskManagerLocation);
- return Collections.emptySet();
+ LOG.debug(
Review Comment:
Maybe move the log to `internalOfferSlotsFromBlockedTaskManager` and also log about the accepted/reject slots?
e.g. Received 3 slots from a blocked TaskManager XXX, 1 was accepted before: [A], 2 was rejected: [B,C].
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wanglijie95 commented on a diff in pull request #20341: [FLINK-28640][runtime] Let BlocklistDeclarativeSlotPool accept duplicate slot offers
Posted by GitBox <gi...@apache.org>.
wanglijie95 commented on code in PR #20341:
URL: https://github.com/apache/flink/pull/20341#discussion_r927479130
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/BlocklistDeclarativeSlotPool.java:
##########
@@ -90,11 +90,29 @@ public Collection<SlotOffer> registerSlots(
if (!isBlockedTaskManager(taskManagerLocation.getResourceID())) {
return super.registerSlots(slots, taskManagerLocation, taskManagerGateway, currentTime);
} else {
- LOG.debug("Reject slots {} from a blocked TaskManager {}.", slots, taskManagerLocation);
- return Collections.emptySet();
+ LOG.debug(
Review Comment:
Agree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org