You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/23 19:25:32 UTC
[GitHub] [tvm] antinucleon commented on a change in pull request #7153: [RUNTIME] Add libbacktrace for backtraces with line numbers
antinucleon commented on a change in pull request #7153:
URL: https://github.com/apache/tvm/pull/7153#discussion_r548161528
##########
File path: cmake/modules/Libbacktrace.cmake
##########
@@ -0,0 +1,18 @@
+include(ExternalProject)
+
+ExternalProject_Add(project_libbacktrace
+ PREFIX libbacktrace
+ SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/libbacktrace"
+ CONFIGURE_COMMAND "${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/libbacktrace/configure" "--prefix=${CMAKE_CURRENT_BINARY_DIR}/libbacktrace"
+ INSTALL_DIR "${CMAKE_CURRENT_BINARY_DIR}/libbacktrace"
+ BUILD_COMMAND make
Review comment:
This is unacceptable.
##########
File path: cmake/modules/Libbacktrace.cmake
##########
@@ -0,0 +1,18 @@
+include(ExternalProject)
+
+ExternalProject_Add(project_libbacktrace
+ PREFIX libbacktrace
+ SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/libbacktrace"
+ CONFIGURE_COMMAND "${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/libbacktrace/configure" "--prefix=${CMAKE_CURRENT_BINARY_DIR}/libbacktrace"
+ INSTALL_DIR "${CMAKE_CURRENT_BINARY_DIR}/libbacktrace"
+ BUILD_COMMAND make
+ INSTALL_COMMAND make install
Review comment:
Question: How cmake generate for Windows with this command?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org