You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Matthias J. Sax (JIRA)" <ji...@apache.org> on 2018/02/16 00:20:05 UTC

[jira] [Updated] (KAFKA-5660) Don't throw TopologyBuilderException during runtime

     [ https://issues.apache.org/jira/browse/KAFKA-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias J. Sax updated KAFKA-5660:
-----------------------------------
    Description: 
{{TopologyBuilderException}} is a pre-runtime exception that should only be thrown beforeĀ {{KafkaStreams#start()}} is called.

However, we do throw {{TopologyBuilderException}} within
 - `SourceNodeFactory#getTopics`
 - `ProcessorContextImpl#getStateStore`
 - `StreamPartitionAssignor#prepareTopic `

(and maybe somewhere else: we should double check if there are other places in the code like those).

We should replace those exception with either {{StreamsException}} or with a new exception type.

  was:
{{TopologyBuilderException}} is a pre-runtime exception that should only be thrown {{KafkaStreams#start()}} is called.

However, we do throw {{TopologyBuilderException}} within

- `SourceNodeFactory#getTopics`
- `ProcessorContextImpl#getStateStore`
- `StreamPartitionAssignor#prepareTopic `

(and maybe somewhere else: we should double check if there are other places in the code like those).

We should replace those exception with either {{StreamsException}} or with a new exception type.


> Don't throw TopologyBuilderException during runtime
> ---------------------------------------------------
>
>                 Key: KAFKA-5660
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5660
>             Project: Kafka
>          Issue Type: Task
>          Components: streams
>    Affects Versions: 0.11.0.0
>            Reporter: Matthias J. Sax
>            Assignee: Nick Afshartous
>            Priority: Major
>
> {{TopologyBuilderException}} is a pre-runtime exception that should only be thrown beforeĀ {{KafkaStreams#start()}} is called.
> However, we do throw {{TopologyBuilderException}} within
>  - `SourceNodeFactory#getTopics`
>  - `ProcessorContextImpl#getStateStore`
>  - `StreamPartitionAssignor#prepareTopic `
> (and maybe somewhere else: we should double check if there are other places in the code like those).
> We should replace those exception with either {{StreamsException}} or with a new exception type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)