[jira] [Commented] (FLINK-10304) Remove deprecated AbstractYarnClusterDescriptor field

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607314#comment-16607314 ] 

ASF GitHub Bot commented on FLINK-10304:
----------------------------------------

TisonKun opened a new pull request #6673: [FLINK-10304] [client] Remove deprecated AbstractYarnClusterDescriptor field
URL: https://github.com/apache/flink/pull/6673
 
 
   ## Brief change log
   
   Remove deprecated AbstractYarnClusterDescriptor field
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `FlinkYarnSessionCliTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers:(no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove deprecated AbstractYarnClusterDescriptor field
> -----------------------------------------------------
>
>                 Key: FLINK-10304
>                 URL: https://issues.apache.org/jira/browse/FLINK-10304
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client, YARN
>    Affects Versions: 1.7.0
>            Reporter: 陈梓立
>            Assignee: 陈梓立
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> Depend on [~trohrmann@apache.org]'s [commit|https://github.com/apache/flink/commit/6356128865bff7463bf03185d18b129ed3633bc2], {{AbstractYarnClusterDescriptor}} should not care whether it is in DETACHED mode.
> After digging I found the main usages of it are
> 1. {{FlinkYarnSessionCli#run}}, this can be resolved by checking whether {{allOptions}} has {{DETACHED_OPTION}} locally.
> 2. when AbstractYarnClusterDescriptor start a AM, it sets {{appMasterEnv.put(YarnConfigKeys.ENV_DETACHED, String.valueOf(detached));}}. At this point it seems that YarnClusterDescriptor should know whether or not it is in detached mode.
> If usage 2 is irrelevant now, we can get rid of deprecated method in FLIP-6 codebase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)