[GitHub] [storm] krichter722 commented on a change in pull request #3062: STORM-3447: jms: fix all checkstyle warnings

[GitBox <gi...@apache.org>]

krichter722 commented on a change in pull request #3062: STORM-3447: jms: fix all checkstyle warnings
URL: https://github.com/apache/storm/pull/3062#discussion_r300474633
 
 

 ##########
 File path: external/storm-jms/src/main/java/org/apache/storm/jms/trident/TridentJmsSpout.java
 ##########
 @@ -193,7 +185,7 @@ public Fields getOutputFields() {
         private final long rotateTimeMillis;
         private final int maxBatchSize;
         private final String name;
-        private final Logger LOG = LoggerFactory.getLogger(JmsEmitter.class);
+        private final Logger log = LoggerFactory.getLogger(JmsEmitter.class);
 
 Review comment:
   Then the surrounding private class JmsEmitter would need to be static as well. That'd mean touching more than just style. The private class is longer than the surrounding class though, so it could be moved up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services