You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/16 11:34:00 UTC
[GitHub] [incubator-kvrocks] git-hulk opened a new pull request, #1000: Increase the read/write timeout of tests in large value scenario
git-hulk opened a new pull request, #1000:
URL: https://github.com/apache/incubator-kvrocks/pull/1000
Resolves #999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #1000: Increase the read/write timeout of tests in large value scenario
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #1000:
URL: https://github.com/apache/incubator-kvrocks/pull/1000#discussion_r996432977
##########
tests/gocase/integration/replication/replication_test.go:
##########
@@ -204,7 +204,10 @@ func TestReplicationWithLimitSpeed(t *testing.T) {
"rocksdb.target_file_size_base": "1",
})
defer master.Close()
- masterClient := master.NewClient()
+ masterClient := master.NewClientWithOption(&redis.Options{
+ ReadTimeout: 10 * time.Second,
+ WriteTimeout: 10 * time.Second,
Review Comment:
```suggestion
```
`WriteTimeout` is default to `ReadTimeout`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1000: Increase the read/write timeout of tests in large value scenario
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1000:
URL: https://github.com/apache/incubator-kvrocks/pull/1000#issuecomment-1279959601
> I just notice that it's the 1000th issue/PR, lol.
😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1000: Increase the read/write timeout of tests in large value scenario
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1000:
URL: https://github.com/apache/incubator-kvrocks/pull/1000#issuecomment-1279956033
> Please reformat code :)
Done, I saw the lint error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #1000: Increase the read/write timeout of tests in large value scenario
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #1000:
URL: https://github.com/apache/incubator-kvrocks/pull/1000#issuecomment-1279955917
Please reformat code :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #1000: Increase the read/write timeout of tests in large value scenario
Posted by GitBox <gi...@apache.org>.
git-hulk merged PR #1000:
URL: https://github.com/apache/incubator-kvrocks/pull/1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org