You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2022/08/12 17:09:18 UTC

[GitHub] [cxf] reta commented on a diff in pull request #981: CXF-8750: only add trailing slash if necessary when locating webjars …

reta commented on code in PR #981:
URL: https://github.com/apache/cxf/pull/981#discussion_r944657369


##########
rt/rs/description-swagger-ui/src/main/java/org/apache/cxf/jaxrs/swagger/ui/OsgiSwaggerUiResolver.java:
##########
@@ -32,18 +31,24 @@ public class OsgiSwaggerUiResolver extends SwaggerUiResolver {
     };
     
     private final Class<? extends Annotation> annotationBundle;
+    private FrameworkUtilWrapper frameworkUtilWrapper;

Review Comment:
   I believe the the introduction of the wrapper is for testability reasons? I would suggest to go with integration tests instead, it would also help to catch any changes in Karaf (I could help with that). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org