You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "hughhhh (GitHub)" <gi...@apache.org> on 2018/08/27 03:08:07 UTC

[GitHub] [incubator-superset] hughhhh opened pull request #5738: remove unneeded commented console.log

Remove unused lines

[ Full content available at: https://github.com/apache/incubator-superset/pull/5738 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5738: remove unneeded commented console.log

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=h1) Report
> Merging [#5738](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52b99dff7838868ff721c8a22081092f24bee3ef?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5738/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master    #5738   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files         361      361           
  Lines       23001    23001           
  Branches     2559     2559           
=======================================
  Hits        14580    14580           
  Misses       8406     8406           
  Partials       15       15
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=footer). Last update [52b99df...88b4533](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5738 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5738: remove unneeded commented console.log

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=h1) Report
> Merging [#5738](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52b99dff7838868ff721c8a22081092f24bee3ef?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5738/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master    #5738   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files         361      361           
  Lines       23001    23001           
  Branches     2559     2559           
=======================================
  Hits        14580    14580           
  Misses       8406     8406           
  Partials       15       15
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=footer). Last update [52b99df...88b4533](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5738 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] mistercrunch closed pull request #5738: remove unneeded commented console.log

Posted by "mistercrunch (GitHub)" <gi...@apache.org>.
[ pull request closed by mistercrunch ]

[ Full content available at: https://github.com/apache/incubator-superset/pull/5738 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5738: remove unneeded commented console.log

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=h1) Report
> Merging [#5738](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52b99dff7838868ff721c8a22081092f24bee3ef?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5738/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master    #5738   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files         361      361           
  Lines       23001    23001           
  Branches     2559     2559           
=======================================
  Hits        14580    14580           
  Misses       8406     8406           
  Partials       15       15
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=footer). Last update [52b99df...88b4533](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5738 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] kristw commented on issue #5738: remove unneeded commented console.log

Posted by "kristw (GitHub)" <gi...@apache.org>.
Approved!

[ Full content available at: https://github.com/apache/incubator-superset/pull/5738 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5738: remove unneeded commented console.log

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=h1) Report
> Merging [#5738](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52b99dff7838868ff721c8a22081092f24bee3ef?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5738/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master    #5738   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files         361      361           
  Lines       23001    23001           
  Branches     2559     2559           
=======================================
  Hits        14580    14580           
  Misses       8406     8406           
  Partials       15       15
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=footer). Last update [52b99df...88b4533](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5738 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5738: remove unneeded commented console.log

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=h1) Report
> Merging [#5738](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52b99dff7838868ff721c8a22081092f24bee3ef?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5738/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master    #5738   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files         361      361           
  Lines       23001    23001           
  Branches     2559     2559           
=======================================
  Hits        14580    14580           
  Misses       8406     8406           
  Partials       15       15
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=footer). Last update [52b99df...88b4533](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5738 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #5738: remove unneeded commented console.log

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=h1) Report
> Merging [#5738](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/52b99dff7838868ff721c8a22081092f24bee3ef?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5738/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master    #5738   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files         361      361           
  Lines       23001    23001           
  Branches     2559     2559           
=======================================
  Hits        14580    14580           
  Misses       8406     8406           
  Partials       15       15
```



------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=footer). Last update [52b99df...88b4533](https://codecov.io/gh/apache/incubator-superset/pull/5738?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-superset/pull/5738 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org