You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Grant Smith (JIRA)" <de...@myfaces.apache.org> on 2006/11/15 19:17:38 UTC
[jira] Commented: (MYFACES-1491) Implement the Checkstyle plugin
[ http://issues.apache.org/jira/browse/MYFACES-1491?page=comments#action_12450140 ]
Grant Smith commented on MYFACES-1491:
--------------------------------------
Patch applied.
> Implement the Checkstyle plugin
> -------------------------------
>
> Key: MYFACES-1491
> URL: http://issues.apache.org/jira/browse/MYFACES-1491
> Project: MyFaces Core
> Issue Type: Improvement
> Components: build process
> Reporter: Paul Spencer
> Assigned To: Grant Smith
> Attachments: patch.txt
>
>
> As a followup to to MyFaces-1488, this is a requst to implement Maven's Checkstyle plugin to insure all source files contain the correct Apache License.
> Additional checks, i.e. modules, can be added in the future. This request is limited to checking for the Apache License
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (MYFACES-1491) Implement the Checkstyle plugin
Posted by Grant Smith <wo...@gmail.com>.
Curses.. I forgot to commit. OK, they're in now.
On 11/16/06, Paul Spencer <pa...@apache.org> wrote:
>
> Grant,
> I do not see the files added by the patch:
> maven\build-tools\src\main\resources\config\myfaces-checks.xml
> maven\build-tools\src\main\resources\config\myfaces-header.txt
>
> In addition the patch deleted:
> maven\build-tools\src\main\resources\org\apache\myfaces\checkstyle.xml
>
> Paul Spencer
>
> Grant Smith (JIRA) wrote:
> > [
> http://issues.apache.org/jira/browse/MYFACES-1491?page=comments#action_12450140]
> >
> > Grant Smith commented on MYFACES-1491:
> > --------------------------------------
> >
> > Patch applied.
> >
> >
> >>Implement the Checkstyle plugin
> >>-------------------------------
> >>
> >> Key: MYFACES-1491
> >> URL: http://issues.apache.org/jira/browse/MYFACES-1491
> >> Project: MyFaces Core
> >> Issue Type: Improvement
> >> Components: build process
> >> Reporter: Paul Spencer
> >> Assigned To: Grant Smith
> >> Attachments: patch.txt
> >>
> >>
> >>As a followup to to MyFaces-1488, this is a requst to implement Maven's
> Checkstyle plugin to insure all source files contain the correct Apache
> License.
> >>Additional checks, i.e. modules, can be added in the future. This
> request is limited to checking for the Apache License
> >
> >
>
>
--
Grant Smith
Re: [jira] Commented: (MYFACES-1491) Implement the Checkstyle plugin
Posted by Paul Spencer <pa...@apache.org>.
Grant,
I do not see the files added by the patch:
maven\build-tools\src\main\resources\config\myfaces-checks.xml
maven\build-tools\src\main\resources\config\myfaces-header.txt
In addition the patch deleted:
maven\build-tools\src\main\resources\org\apache\myfaces\checkstyle.xml
Paul Spencer
Grant Smith (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/MYFACES-1491?page=comments#action_12450140 ]
>
> Grant Smith commented on MYFACES-1491:
> --------------------------------------
>
> Patch applied.
>
>
>>Implement the Checkstyle plugin
>>-------------------------------
>>
>> Key: MYFACES-1491
>> URL: http://issues.apache.org/jira/browse/MYFACES-1491
>> Project: MyFaces Core
>> Issue Type: Improvement
>> Components: build process
>> Reporter: Paul Spencer
>> Assigned To: Grant Smith
>> Attachments: patch.txt
>>
>>
>>As a followup to to MyFaces-1488, this is a requst to implement Maven's Checkstyle plugin to insure all source files contain the correct Apache License.
>>Additional checks, i.e. modules, can be added in the future. This request is limited to checking for the Apache License
>
>