You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/01/25 11:52:10 UTC

Review Request 55926: Kafka Brokers go down after Wire Encryption

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55926/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-19661
    https://issues.apache.org/jira/browse/AMBARI-19661


Repository: ambari


Description
-------

Kafka Brokers go down after Wire Encryption.
2017-01-23 22:02:35,600] FATAL  (kafka.Kafka$)
java.lang.IllegalArgumentException: requirement failed: Missing required property 'truststore.path'
        at scala.Predef$.require(Predef.scala:233)
        at kafka.utils.VerifiableProperties.getString(VerifiableProperties.scala:177)
        at org.apache.hadoop.metrics2.sink.kafka.KafkaTimelineMetricsReporter.init(KafkaTimelineMetricsReporter.java:162)
        at kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:60)
        at kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:58)
        at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
        at scala.collection.mutable.WrappedArray.foreach(WrappedArray.scala:34)
        at kafka.metrics.KafkaMetricsReporter$.startReporters(KafkaMetricsReporter.scala:58)
        at kafka.server.KafkaServerStartable$.fromProps(KafkaServerStartable.scala:27)
        at kafka.Kafka$.main(Kafka.scala:58)
        at kafka.Kafka.main(Kafka.scala)'
We are looking for "truststore.path" and the property set is "kafka.timeline.metrics.truststore.path".


Diffs
-----

  ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java fef1f24 
  ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java c569d88 

Diff: https://reviews.apache.org/r/55926/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 55926: Kafka Brokers go down after Wire Encryption

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55926/#review162983
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Jan. 25, 2017, 11:52 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55926/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 11:52 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19661
>     https://issues.apache.org/jira/browse/AMBARI-19661
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Kafka Brokers go down after Wire Encryption.
> 2017-01-23 22:02:35,600] FATAL  (kafka.Kafka$)
> java.lang.IllegalArgumentException: requirement failed: Missing required property 'truststore.path'
>         at scala.Predef$.require(Predef.scala:233)
>         at kafka.utils.VerifiableProperties.getString(VerifiableProperties.scala:177)
>         at org.apache.hadoop.metrics2.sink.kafka.KafkaTimelineMetricsReporter.init(KafkaTimelineMetricsReporter.java:162)
>         at kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:60)
>         at kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:58)
>         at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
>         at scala.collection.mutable.WrappedArray.foreach(WrappedArray.scala:34)
>         at kafka.metrics.KafkaMetricsReporter$.startReporters(KafkaMetricsReporter.scala:58)
>         at kafka.server.KafkaServerStartable$.fromProps(KafkaServerStartable.scala:27)
>         at kafka.Kafka$.main(Kafka.scala:58)
>         at kafka.Kafka.main(Kafka.scala)'
> We are looking for "truststore.path" and the property set is "kafka.timeline.metrics.truststore.path".
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java fef1f24 
>   ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java c569d88 
> 
> Diff: https://reviews.apache.org/r/55926/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 55926: Kafka Brokers go down after Wire Encryption

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55926/#review162942
-----------------------------------------------------------


Ship it!




Ship It!

- Vitalyi Brodetskyi


On \u0421\u0456\u0447. 25, 2017, 11:52 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55926/
> -----------------------------------------------------------
> 
> (Updated \u0421\u0456\u0447. 25, 2017, 11:52 \u0434\u043e \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19661
>     https://issues.apache.org/jira/browse/AMBARI-19661
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Kafka Brokers go down after Wire Encryption.
> 2017-01-23 22:02:35,600] FATAL  (kafka.Kafka$)
> java.lang.IllegalArgumentException: requirement failed: Missing required property 'truststore.path'
>         at scala.Predef$.require(Predef.scala:233)
>         at kafka.utils.VerifiableProperties.getString(VerifiableProperties.scala:177)
>         at org.apache.hadoop.metrics2.sink.kafka.KafkaTimelineMetricsReporter.init(KafkaTimelineMetricsReporter.java:162)
>         at kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:60)
>         at kafka.metrics.KafkaMetricsReporter$$anonfun$startReporters$1.apply(KafkaMetricsReporter.scala:58)
>         at scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33)
>         at scala.collection.mutable.WrappedArray.foreach(WrappedArray.scala:34)
>         at kafka.metrics.KafkaMetricsReporter$.startReporters(KafkaMetricsReporter.scala:58)
>         at kafka.server.KafkaServerStartable$.fromProps(KafkaServerStartable.scala:27)
>         at kafka.Kafka$.main(Kafka.scala:58)
>         at kafka.Kafka.main(Kafka.scala)'
> We are looking for "truststore.path" and the property set is "kafka.timeline.metrics.truststore.path".
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java fef1f24 
>   ambari-metrics/ambari-metrics-kafka-sink/src/test/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporterTest.java c569d88 
> 
> Diff: https://reviews.apache.org/r/55926/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>