You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/01 11:11:48 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #2865: Fix usage of incorrect @Produces annotation
jamesnetherton opened a new pull request #2865:
URL: https://github.com/apache/camel-quarkus/pull/2865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #2865: Fix usage of incorrect @Produces annotation
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #2865:
URL: https://github.com/apache/camel-quarkus/pull/2865#issuecomment-872224399
> Looks good to me. One question however, @Unremovable are useless because this is managed by camel-quarkus-core ?
AFAIK - if the bean has an explicit name, it's unremovable. There is some logic in core that I think is supposed to make component beans unremovable, but I'm not sure if it's working. Hence how I stumbled on this issue while experimenting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #2865: Fix usage of incorrect @Produces annotation
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #2865:
URL: https://github.com/apache/camel-quarkus/pull/2865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2865: Fix usage of incorrect @Produces annotation
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2865:
URL: https://github.com/apache/camel-quarkus/pull/2865#issuecomment-876957323
Oh, I see it was `@javax.ws.rs.Produces`. I guess `@javax.enterprise.inject.Produces` would be correct but superfluous in this situation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #2865: Fix usage of incorrect @Produces annotation
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #2865:
URL: https://github.com/apache/camel-quarkus/pull/2865#issuecomment-872212926
Looks good to me. One question however, @Unremovable are useless because this is managed by camel-quarkus-core ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org