You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "ferruzzi (via GitHub)" <gi...@apache.org> on 2026/09/09 00:00:42 UTC

Re: [PR] Improve deadline diagnostics for null DagRun fields [airflow]

ferruzzi commented on code in PR #71767:
URL: https://github.com/apache/airflow/pull/71767#discussion_r3963352074


##########
airflow-core/src/airflow/serialization/definitions/deadline.py:
##########
@@ -373,10 +373,13 @@ def _fetch_from_db(column, *, session: Session, dag_id: str, run_id: str) -> dat
     """
     from airflow.models import DagRun
 

Review Comment:
   I may be missing it, but are there any tests actually running this change?  The only one I see that hits `_fetch_from_db` is `test_deadline_database_integration`, which mocks it out, so the change is skipped entirely.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org