You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/12 19:00:20 UTC

[GitHub] [beam] lostluck opened a new pull request #12553: [BEAM-9615] Add initial schema proto documentation.

lostluck opened a new pull request #12553:
URL: https://github.com/apache/beam/pull/12553


   Add some initial documentation to the schema protos, where the fields have implemented meanings and restrictions that weren't yet documented.
   
   Open for discussion.
   
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
   --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
   Java | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/i
 con)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](htt
 ps://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
   Python | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_
 Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_P
 ostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
   XLang | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website
   --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://ci-beam.apache.org/job/b
 eam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
   Portable | --- | [![Build Status](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   ![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12553: [BEAM-9615] Add initial schema proto documentation.

Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #12553:
URL: https://github.com/apache/beam/pull/12553#discussion_r472406668



##########
File path: model/pipeline/src/main/proto/schema.proto
##########
@@ -32,16 +32,27 @@ option java_package = "org.apache.beam.model.pipeline.v1";
 option java_outer_classname = "SchemaApi";
 
 message Schema {
+  // List of fields for this schema. Two fields may not share a name.
   repeated Field fields = 1;
+  // REQUIRED. An RFC 4122 UUID.
   string id = 2;
   repeated Option options = 3;
 }
 
 message Field {
+  // REQUIRED. Name of this field within the schema.
   string name = 1;
+  // OPTIONAL. Human readable description of this field, such as the query that generated it.
   string description = 2;
   FieldType type = 3;
+  
   int32 id = 4;
+   // OPTIONAL. The position of this field's data in the encoding.
+   // Either no fields in a given row are have encoding position populated,
+   // or all of them are. Used to support backwards compatibility with schema
+   // changes.
+   // Two schemas, one with encoding positions and one without, are equal
+   // if the fields when sorted by encoding position would otherwise be equal.

Review comment:
       
   ```suggestion
      // OPTIONAL. The position of this field's data when encoded, e.g. with beam:coder:row:v1.
      // Either no fields in a given row are have encoding position populated,
      // or all of them are. Used to support backwards compatibility with schema
      // changes.
      // If no fields have encoding position populated the order of encoding is the same as the order in the Schema.
   ```
   
   Added a reference to beam:coder:row:v1 and a note about default behavior. Removed the note about equality - the way equality is implemented in Java, two schemas are only equal if they are exactly the same. There are lower levels of compatibility though, like assignable, equivalent: https://github.com/apache/beam/blob/29ea00e7cbbb6387f6b0c6ee8b112802d1559851/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java#L340-L353

##########
File path: model/pipeline/src/main/proto/schema.proto
##########
@@ -97,7 +108,11 @@ message LogicalType {
 }
 
 message Option {
+  // REQUIRED. Identifier for the option.
   string name = 1;
+  // Optional type specifer for the structure of value.
+  // If not present, assumes no additional configuration is needed
+  // for this option.

Review comment:
       ```suggestion
     // for this option and value is ignored.
   ```

##########
File path: model/pipeline/src/main/proto/schema.proto
##########
@@ -97,7 +108,11 @@ message LogicalType {
 }
 
 message Option {
+  // REQUIRED. Identifier for the option.
   string name = 1;
+  // Optional type specifer for the structure of value.

Review comment:
       ```suggestion
     // OPTIONAL. Type specifer for the structure of value.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on a change in pull request #12553: [BEAM-9615] Add initial schema proto documentation.

Posted by GitBox <gi...@apache.org>.
lostluck commented on a change in pull request #12553:
URL: https://github.com/apache/beam/pull/12553#discussion_r488240030



##########
File path: model/pipeline/src/main/proto/schema.proto
##########
@@ -32,16 +32,27 @@ option java_package = "org.apache.beam.model.pipeline.v1";
 option java_outer_classname = "SchemaApi";
 
 message Schema {
+  // List of fields for this schema. Two fields may not share a name.
   repeated Field fields = 1;
+  // REQUIRED. An RFC 4122 UUID.
   string id = 2;
   repeated Option options = 3;
 }
 
 message Field {
+  // REQUIRED. Name of this field within the schema.
   string name = 1;
+  // OPTIONAL. Human readable description of this field, such as the query that generated it.
   string description = 2;
   FieldType type = 3;
+  
   int32 id = 4;
+   // OPTIONAL. The position of this field's data in the encoding.
+   // Either no fields in a given row are have encoding position populated,
+   // or all of them are. Used to support backwards compatibility with schema
+   // changes.
+   // Two schemas, one with encoding positions and one without, are equal
+   // if the fields when sorted by encoding position would otherwise be equal.

Review comment:
       Ack. There's nothing wrong with only using strict equivalence, rather than assignable equivalence. We do need to document which we're using at some point or all we'll be using is strict equivalence forever. Without a definition of assignable, we can't really use assignable equivalence at all.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #12553: [BEAM-9615] Add initial schema proto documentation.

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12553:
URL: https://github.com/apache/beam/pull/12553#issuecomment-692340545


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=h1) Report
   > Merging [#12553](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/e164d170eb6b5ec1dddd99f09e79dfb0147b84ae?el=desc) will **increase** coverage by `47.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12553/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12553       +/-   ##
   ===========================================
   + Coverage   34.47%   82.36%   +47.88%     
   ===========================================
     Files         684      450      -234     
     Lines       81483    53702    -27781     
     Branches     9180        0     -9180     
   ===========================================
   + Hits        28090    44230    +16140     
   + Misses      52972     9472    -43500     
   + Partials      421        0      -421     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [runners/interactive/testing/test\_cache\_manager.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL3Rlc3RfY2FjaGVfbWFuYWdlci5weQ==) | | |
   | [coders/slow\_coders\_test.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-Y29kZXJzL3Nsb3dfY29kZXJzX3Rlc3QucHk=) | | |
   | [examples/cookbook/filters\_test.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29va2Jvb2svZmlsdGVyc190ZXN0LnB5) | | |
   | [runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-cnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | | |
   | [examples/snippets/transforms/elementwise/filter.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9maWx0ZXIucHk=) | | |
   | [testing/synthetic\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-dGVzdGluZy9zeW50aGV0aWNfcGlwZWxpbmUucHk=) | | |
   | [...tests/streaming/group\_by\_key\_streaming\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-dGVzdGluZy9sb2FkX3Rlc3RzL3N0cmVhbWluZy9ncm91cF9ieV9rZXlfc3RyZWFtaW5nX3BpcGVsaW5lLnB5) | | |
   | [runners/portability/portable\_metrics.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-cnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9tZXRyaWNzLnB5) | | |
   | [testing/benchmarks/chicago\_taxi/process\_tfma.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-dGVzdGluZy9iZW5jaG1hcmtzL2NoaWNhZ29fdGF4aS9wcm9jZXNzX3RmbWEucHk=) | | |
   | [utils/urns.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-dXRpbHMvdXJucy5weQ==) | | |
   | ... and [1124 more](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=footer). Last update [f2192c6...b1a2916](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12553: [BEAM-9615] Add initial schema proto documentation.

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12553:
URL: https://github.com/apache/beam/pull/12553#issuecomment-692340545


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=h1) Report
   > Merging [#12553](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/e164d170eb6b5ec1dddd99f09e79dfb0147b84ae?el=desc) will **increase** coverage by `47.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12553/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12553       +/-   ##
   ===========================================
   + Coverage   34.47%   82.36%   +47.88%     
   ===========================================
     Files         684      450      -234     
     Lines       81483    53702    -27781     
     Branches     9180        0     -9180     
   ===========================================
   + Hits        28090    44230    +16140     
   + Misses      52972     9472    -43500     
   + Partials      421        0      -421     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [io/gcp/experimental/spannerio.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-aW8vZ2NwL2V4cGVyaW1lbnRhbC9zcGFubmVyaW8ucHk=) | | |
   | [io/mongodbio\_it\_test.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-aW8vbW9uZ29kYmlvX2l0X3Rlc3QucHk=) | | |
   | [transforms/ptransform.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy9wdHJhbnNmb3JtLnB5) | | |
   | [io/utils\_test.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-aW8vdXRpbHNfdGVzdC5weQ==) | | |
   | [examples/cookbook/mergecontacts.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29va2Jvb2svbWVyZ2Vjb250YWN0cy5weQ==) | | |
   | [examples/snippets/util\_test.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdXRpbF90ZXN0LnB5) | | |
   | [examples/cookbook/coders.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvY29va2Jvb2svY29kZXJzLnB5) | | |
   | [io/gcp/dicomio\_integration\_test.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-aW8vZ2NwL2RpY29taW9faW50ZWdyYXRpb25fdGVzdC5weQ==) | | |
   | [testing/benchmarks/nexmark/queries/query0.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-dGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvcXVlcmllcy9xdWVyeTAucHk=) | | |
   | [examples/snippets/transforms/aggregation/mean.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9tZWFuLnB5) | | |
   | ... and [1124 more](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=footer). Last update [f2192c6...b1a2916](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #12553: [BEAM-9615] Add initial schema proto documentation.

Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #12553:
URL: https://github.com/apache/beam/pull/12553#issuecomment-673053095


   R: @TheNeuralBit @reuvenlax 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck merged pull request #12553: [BEAM-9615] Add initial schema proto documentation.

Posted by GitBox <gi...@apache.org>.
lostluck merged pull request #12553:
URL: https://github.com/apache/beam/pull/12553


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12553: [BEAM-9615] Add initial schema proto documentation.

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12553:
URL: https://github.com/apache/beam/pull/12553#issuecomment-692340545


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=h1) Report
   > Merging [#12553](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/e164d170eb6b5ec1dddd99f09e79dfb0147b84ae?el=desc) will **increase** coverage by `47.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/12553/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12553       +/-   ##
   ===========================================
   + Coverage   34.47%   82.36%   +47.88%     
   ===========================================
     Files         684      450      -234     
     Lines       81483    53702    -27781     
     Branches     9180        0     -9180     
   ===========================================
   + Hits        28090    44230    +16140     
   + Misses      52972     9472    -43500     
   + Partials      421        0      -421     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [transforms/validate\_runner\_xlang\_test.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-dHJhbnNmb3Jtcy92YWxpZGF0ZV9ydW5uZXJfeGxhbmdfdGVzdC5weQ==) | | |
   | [runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-cnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==) | | |
   | [metrics/execution\_test.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-bWV0cmljcy9leGVjdXRpb25fdGVzdC5weQ==) | | |
   | [coders/coders\_test\_common.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-Y29kZXJzL2NvZGVyc190ZXN0X2NvbW1vbi5weQ==) | | |
   | [io/aws/clients/s3/boto3\_client.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-aW8vYXdzL2NsaWVudHMvczMvYm90bzNfY2xpZW50LnB5) | | |
   | [...s/snippets/transforms/aggregation/combineperkey.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-ZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9hZ2dyZWdhdGlvbi9jb21iaW5lcGVya2V5LnB5) | | |
   | [io/utils\_test.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-aW8vdXRpbHNfdGVzdC5weQ==) | | |
   | [runners/interactive/pipeline\_fragment.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-cnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9mcmFnbWVudC5weQ==) | | |
   | [testing/util.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-dGVzdGluZy91dGlsLnB5) | | |
   | [io/fileio\_test.py](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree#diff-aW8vZmlsZWlvX3Rlc3QucHk=) | | |
   | ... and [1124 more](https://codecov.io/gh/apache/beam/pull/12553/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=footer). Last update [f2192c6...b1a2916](https://codecov.io/gh/apache/beam/pull/12553?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lostluck commented on pull request #12553: [BEAM-9615] Add initial schema proto documentation.

Posted by GitBox <gi...@apache.org>.
lostluck commented on pull request #12553:
URL: https://github.com/apache/beam/pull/12553#issuecomment-692377165


   Retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] edited a comment on pull request #12553: [BEAM-9615] Add initial schema proto documentation.

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12553:
URL: https://github.com/apache/beam/pull/12553#issuecomment-692340545






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org