You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by jerrypeng <gi...@git.apache.org> on 2016/08/11 16:05:34 UTC
[GitHub] storm pull request #1621: [STORM-1766] - A better algorithm server rack sele...
GitHub user jerrypeng opened a pull request:
https://github.com/apache/storm/pull/1621
[STORM-1766] - A better algorithm server rack selection for RAS
Backport of #1398 to 1.x branch. I'm not sure this actually needs a PR, but since it's been a while since #1500 was merged, I'll put one anyways since the code went into 2.x a while ago
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jerrypeng/storm 1.x-STORM-1766
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1621.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1621
----
commit d50a2437923f2919fbee130b8e9e86a62a2d9f48
Author: Boyang Jerry Peng <je...@yahoo-inc.com>
Date: 2016-05-04T22:08:57Z
[STORM-1766] - A better algorithm server rack selection for RAS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1621: Backport to 1.x [STORM-1766] - A better algorithm ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1621
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1621: Backport to 1.x [STORM-1766] - A better algorithm ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1621#discussion_r74524961
--- Diff: storm-core/src/jvm/org/apache/storm/scheduler/Cluster.java ---
@@ -103,6 +103,9 @@ public Cluster(Cluster src) {
this.status.putAll(src.status);
this.topologyResources.putAll(src.topologyResources);
this.blackListedHosts.addAll(src.blackListedHosts);
+ if (src.networkTopography != null) {
--- End diff --
is this supposed to be == null. why are we creating new Map if there is one already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1621: Backport to 1.x [STORM-1766] - A better algorithm server ...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/1621
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1621: Backport to 1.x [STORM-1766] - A better algorithm server ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1621
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---