[GitHub] rymanluk commented on a change in pull request #457: nimble: Fix BCC initialization on LE Coded PHY

[gi...@git.apache.org]

rymanluk commented on a change in pull request #457: nimble: Fix BCC initialization on LE Coded PHY
URL: https://github.com/apache/mynewt-core/pull/457#discussion_r128977061
 
 

 ##########
 File path: hw/drivers/nimble/nrf52/src/ble_phy.c
 ##########
 @@ -544,8 +545,19 @@ ble_phy_rx_xcvr_setup(void)
     g_ble_phy_data.phy_rx_started = 0;
     g_ble_phy_data.phy_state = BLE_PHY_STATE_RX;
 
+    /*
+     * On Coded PHY there are CI and TERM1 fields before PDU starts so we need
+     * to take this into account when setting up BCC.
+     */
+    if (g_ble_phy_data.phy_cur_phy_mode == BLE_PHY_MODE_CODED_125KBPS ||
 
 Review comment:
   I think this should be guarded with BLE_LL_BT5_PHY_SUPPORTED flag.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services