You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2026/03/03 15:51:35 UTC
[PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
lordgamez opened a new pull request, #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128
All Github Actions workflows are run weekly to avoid regression. The workflow run results are visible on the status page hosted on Github Pages.
Status page example can be checked at: https://lordgamez.github.io/nifi-minifi-cpp/
https://issues.apache.org/jira/browse/MINIFICPP-2737
-----------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2931983127
##########
.github/workflows/verify-package.yml:
##########
@@ -11,16 +11,32 @@ on:
type: string
description: The id of the create-release-artifacts workflow to download artifacts from
required: true
-
+ workflow_run:
+ workflows: ["Create Release Artifacts"]
+ types:
+ - completed
+ branches: [main]
Review Comment:
When would this be triggered? I think we were talking about weekly runs, but I don't see the weekly scheduling here, so idk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2987822775
##########
.github/workflows/verify-package.yml:
##########
@@ -11,16 +11,32 @@ on:
type: string
description: The id of the create-release-artifacts workflow to download artifacts from
required: true
-
+ workflow_run:
+ workflows: ["Create Release Artifacts"]
+ types:
+ - completed
+ branches: [main]
Review Comment:
The trigger here is the `workflows: ["Create Release Artifacts"]` This job uses the artifacts created in the `Create Release Artifacts` job which is scheduled weekly, and after that finishes this one is started automatically and runs with the created artifacts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r3014652985
##########
.github/workflows/verify-package.yml:
##########
@@ -11,16 +11,32 @@ on:
type: string
description: The id of the create-release-artifacts workflow to download artifacts from
required: true
-
+ workflow_run:
+ workflows: ["Create Release Artifacts"]
+ types:
+ - completed
+ branches: [main]
env:
DOCKER_CMAKE_FLAGS: -DDOCKER_VERIFY_THREAD=3 -DUSE_SHARED_LIBS= -DSTRICT_GSL_CHECKS=AUDIT -DCI_BUILD=ON -DENABLE_AWS=ON -DENABLE_KAFKA=ON -DENABLE_MQTT=ON -DENABLE_AZURE=ON -DENABLE_SQL=ON \
-DENABLE_SPLUNK=ON -DENABLE_GCP=ON -DENABLE_OPC=ON -DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_KUBERNETES=ON -DENABLE_TEST_PROCESSORS=ON -DENABLE_PROMETHEUS=ON \
-DENABLE_ELASTICSEARCH=OFF -DENABLE_GRAFANA_LOKI=ON -DENABLE_COUCHBASE=ON -DDOCKER_BUILD_ONLY=ON
jobs:
+ check-artifacts-workflow:
+ name: "Check Create Release Artifacts status"
+ if: github.event_name == 'workflow_run'
+ runs-on: ubuntu-24.04
+ steps:
+ - name: Check workflow conclusion
+ if: github.event.workflow_run.conclusion != 'success'
+ run: |
+ echo "Create Release Artifacts workflow failed with conclusion: ${{ github.event.workflow_run.conclusion }}"
+ exit 1
docker-test-modular:
- name: "${{ matrix.platform.name }} (${{ matrix.arch }}) Modular${{ inputs.enable_fips && ' (FIPS Mode)' || '' }}"
+ name: "${{ matrix.platform.name }} (${{ matrix.arch }})${{ (github.event_name != 'workflow_dispatch' || inputs.enable_fips) && ' (FIPS Mode)' || '' }}"
Review Comment:
I think it's better to use workflow_dispatch here as we want to keep the same functionality for every event that is not workflow_dispatch if maybe other kind of events are added in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink closed pull request #2128: MINIFICPP-2737 Add weekly CI workflow runs and status page
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r3016304083
##########
docs/status/index.html:
##########
Review Comment:
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2918317399
##########
docs/status/index.html:
##########
Review Comment:
I checked and the default for Github Pages for github project pages is the /docs directory and the convention seems to be that the websites for projects are located there and their subdirectories. I moved the index.html to /docs/status to align with this convention as the main index.html is usually reserved for the project documentation page. This way the status page will be found at https://apache.github.io/nifi-minifi-cpp/status Updated in https://github.com/apache/nifi-minifi-cpp/pull/2128/commits/a4f5b8ab55482aab90a334a11d79343fe90a7894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2918317399
##########
docs/status/index.html:
##########
Review Comment:
I checked and the default for Github Pages for github project pages is the /docs directory and the convention seems to be that the websites for projects are located there and their subdirectories. I moved the index.html to /docs/status to align with this convention as the main index.html is usually reserved for the project documentation page. This way the status page will be found at https://apache.github.io/nifi-minifi-cpp/status
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2879084155
##########
.github/workflows/verify-package.yml:
##########
@@ -85,17 +97,19 @@ jobs:
if: failure()
uses: actions/upload-artifact@v4
with:
- name: ${{ matrix.platform.id }}_${{ matrix.arch }}_behavex_output${{ inputs.enable_fips && '_fips' || '' }}
+ name: ${{ matrix.platform.id }}_${{ matrix.arch }}_behavex_output${{ matrix.enable_fips && '_fips' || '' }}
path: build/behavex_output
docker-test-modular:
name: "${{ matrix.platform.name }} (${{ matrix.arch }}) Modular"
+ needs: [check-artifacts-workflow]
runs-on: ${{ matrix.arch == 'x86_64' && 'ubuntu-24.04' || 'ubuntu-24.04-arm' }}
timeout-minutes: 240
strategy:
fail-fast: false
matrix:
arch: [x86_64, aarch64]
+ enable_fips: [true]
Review Comment:
I think running workflow with both fips enabled and disabled can instantiate way too much jobs, so for automatic weekly runs running only fips enabled jobs should be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2879084155
##########
.github/workflows/verify-package.yml:
##########
@@ -85,17 +97,19 @@ jobs:
if: failure()
uses: actions/upload-artifact@v4
with:
- name: ${{ matrix.platform.id }}_${{ matrix.arch }}_behavex_output${{ inputs.enable_fips && '_fips' || '' }}
+ name: ${{ matrix.platform.id }}_${{ matrix.arch }}_behavex_output${{ matrix.enable_fips && '_fips' || '' }}
path: build/behavex_output
docker-test-modular:
name: "${{ matrix.platform.name }} (${{ matrix.arch }}) Modular"
+ needs: [check-artifacts-workflow]
runs-on: ${{ matrix.arch == 'x86_64' && 'ubuntu-24.04' || 'ubuntu-24.04-arm' }}
timeout-minutes: 240
strategy:
fail-fast: false
matrix:
arch: [x86_64, aarch64]
+ enable_fips: [true]
Review Comment:
Note: I think running workflow with both fips enabled and disabled can instantiate way too much jobs, so for automatic weekly runs running only fips enabled jobs should be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r3014728716
##########
docs/status/index.html:
##########
Review Comment:
Good idea, added the option in https://github.com/apache/nifi-minifi-cpp/pull/2128/commits/87651faf6abaf4f54f91bd8184d970c43d786d16 I made the light theme the default as it is usually the case on other webpages too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2917975376
##########
docs/index.html:
##########
Review Comment:
I'd move this file elsewhere, as a CI status page is not really documentation. Maybe etc/status_page, or github_scripts/status_page, or a new directory called ci/status_page
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2994060146
##########
docs/status/index.html:
##########
Review Comment:
Is it possible to add a dark mode/light mode switch button (it's OK to keep the default as dark)? I know I'm in a minority on this, but I find it difficult to read low-contrast text.
##########
README.md:
##########
@@ -15,7 +15,7 @@
[<img src="https://nifi.apache.org/assets/images/minifi/minifi-logo.svg" width="300" height="126" alt="Apache NiFi MiNiFi"/>](https://nifi.apache.org/minifi/)
-# Apache NiFi - MiNiFi - C++ [](https://github.com/apache/nifi-minifi-cpp/actions/workflows/ci.yml?query=workflow%3A%22MiNiFi-CPP+CI%22+branch%3Amain)
+# Apache NiFi - MiNiFi - C++ [](https://github.com/apache/nifi-minifi-cpp/actions/workflows/ci.yml?query=workflow%3A%22MiNiFi-CPP+CI%22+branch%3Amain)[](https://github.com/apache/nifi-minifi-cpp/actions/workflows/compiler-support.yml?query=branch%3Amain)[](https://github.com/apache/nifi-minifi-cpp/actions/workflows/memcheck_ci.yml?query=branch%3Amain)[](https://github.com/apache/nifi-minifi-cpp/actions/workflows/verify-package.yml?query=branch%3Amain)[](https://apache.github.io/nifi-minifi-cpp/status/)
Review Comment:
this will be a very long line; maybe move the badges to below the title, one badge per line?
##########
.github/workflows/verify-package.yml:
##########
@@ -11,16 +11,32 @@ on:
type: string
description: The id of the create-release-artifacts workflow to download artifacts from
required: true
-
+ workflow_run:
+ workflows: ["Create Release Artifacts"]
+ types:
+ - completed
+ branches: [main]
env:
DOCKER_CMAKE_FLAGS: -DDOCKER_VERIFY_THREAD=3 -DUSE_SHARED_LIBS= -DSTRICT_GSL_CHECKS=AUDIT -DCI_BUILD=ON -DENABLE_AWS=ON -DENABLE_KAFKA=ON -DENABLE_MQTT=ON -DENABLE_AZURE=ON -DENABLE_SQL=ON \
-DENABLE_SPLUNK=ON -DENABLE_GCP=ON -DENABLE_OPC=ON -DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_KUBERNETES=ON -DENABLE_TEST_PROCESSORS=ON -DENABLE_PROMETHEUS=ON \
-DENABLE_ELASTICSEARCH=OFF -DENABLE_GRAFANA_LOKI=ON -DENABLE_COUCHBASE=ON -DDOCKER_BUILD_ONLY=ON
jobs:
+ check-artifacts-workflow:
+ name: "Check Create Release Artifacts status"
+ if: github.event_name == 'workflow_run'
+ runs-on: ubuntu-24.04
+ steps:
+ - name: Check workflow conclusion
+ if: github.event.workflow_run.conclusion != 'success'
+ run: |
+ echo "Create Release Artifacts workflow failed with conclusion: ${{ github.event.workflow_run.conclusion }}"
+ exit 1
docker-test-modular:
- name: "${{ matrix.platform.name }} (${{ matrix.arch }}) Modular${{ inputs.enable_fips && ' (FIPS Mode)' || '' }}"
+ name: "${{ matrix.platform.name }} (${{ matrix.arch }})${{ (github.event_name != 'workflow_dispatch' || inputs.enable_fips) && ' (FIPS Mode)' || '' }}"
Review Comment:
nitpicking, but why not
```suggestion
name: "${{ matrix.platform.name }} (${{ matrix.arch }})${{ (github.event_name == 'workflow_run' || inputs.enable_fips) && ' (FIPS Mode)' || '' }}"
```
?
(also in lines 93 and 104)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2879230483
##########
.github/workflows/verify-package.yml:
##########
@@ -11,16 +11,31 @@ on:
type: string
description: The id of the create-release-artifacts workflow to download artifacts from
required: true
-
+ workflow_run:
+ workflows: ["Create Release Artifacts"]
+ types:
+ - completed
+ branches: [main]
env:
DOCKER_CMAKE_FLAGS: -DDOCKER_VERIFY_THREAD=3 -DUSE_SHARED_LIBS= -DSTRICT_GSL_CHECKS=AUDIT -DCI_BUILD=ON -DENABLE_AWS=ON -DENABLE_KAFKA=ON -DENABLE_MQTT=ON -DENABLE_AZURE=ON -DENABLE_SQL=ON \
-DENABLE_SPLUNK=ON -DENABLE_GCP=ON -DENABLE_OPC=ON -DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_KUBERNETES=ON -DENABLE_TEST_PROCESSORS=ON -DENABLE_PROMETHEUS=ON \
-DENABLE_ELASTICSEARCH=OFF -DENABLE_GRAFANA_LOKI=ON -DENABLE_COUCHBASE=ON -DDOCKER_BUILD_ONLY=ON
jobs:
+ check-artifacts-workflow:
+ name: "Check Create Release Artifacts status"
+ if: github.event_name == 'workflow_run'
+ runs-on: ubuntu-24.04
+ steps:
+ - name: Check workflow conclusion
+ if: github.event.workflow_run.conclusion != 'success'
+ run: |
+ echo "Create Release Artifacts workflow failed with conclusion: ${{ github.event.workflow_run.conclusion }}"
+ exit 1
docker-tests:
- name: "${{ matrix.platform.name }} (${{ matrix.arch }})${{ inputs.enable_fips && ' (FIPS Mode)' || '' }}"
+ name: "${{ matrix.platform.name }} (${{ matrix.arch }})${{ (github.event_name != 'workflow_dispatch' || inputs.enable_fips) && ' (FIPS Mode)' || '' }}"
Review Comment:
Note: I think running workflow with both fips enabled and disabled can instantiate way too much jobs, so for automatic weekly runs running only fips enabled jobs should be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2737 Add weekly CI workflow runs and status page [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #2128:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2128#discussion_r2879084155
##########
.github/workflows/verify-package.yml:
##########
@@ -85,17 +97,19 @@ jobs:
if: failure()
uses: actions/upload-artifact@v4
with:
- name: ${{ matrix.platform.id }}_${{ matrix.arch }}_behavex_output${{ inputs.enable_fips && '_fips' || '' }}
+ name: ${{ matrix.platform.id }}_${{ matrix.arch }}_behavex_output${{ matrix.enable_fips && '_fips' || '' }}
path: build/behavex_output
docker-test-modular:
name: "${{ matrix.platform.name }} (${{ matrix.arch }}) Modular"
+ needs: [check-artifacts-workflow]
runs-on: ${{ matrix.arch == 'x86_64' && 'ubuntu-24.04' || 'ubuntu-24.04-arm' }}
timeout-minutes: 240
strategy:
fail-fast: false
matrix:
arch: [x86_64, aarch64]
+ enable_fips: [true]
Review Comment:
Note: I think running workflow with both fips enabled and disabled can instantiate way too much jobs, so for automatic weekly runs running only fips enabled jobs should be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org