You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/11/09 17:46:46 UTC

Review Request 40088: Ambari Agent cannot talk to server if "test -w" command hangs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40088/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-13795
    https://issues.apache.org/jira/browse/AMBARI-13795


Repository: ambari


Description
-------

On a cluster cluster, the "test -w" command was hanging, and this was causing
Ambari Agent to hang:  
<https://github.com/apache/ambari/blob/trunk/ambari-
agent/src/main/python/ambari_agent/Hardware.py#L102>

We need to make sure that we are properly setting a timeout for this command.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/Hardware.py 36b4f4b 
  ambari-agent/src/main/python/ambari_agent/main.py fb5b4b1 
  ambari-agent/src/test/python/ambari_agent/TestMain.py 8c8d347 

Diff: https://reviews.apache.org/r/40088/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 40088: Ambari Agent cannot talk to server if "test -w" command hangs

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40088/#review105694
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 9, 2015, 6:46 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40088/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2015, 6:46 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-13795
>     https://issues.apache.org/jira/browse/AMBARI-13795
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On a cluster cluster, the "test -w" command was hanging, and this was causing
> Ambari Agent to hang:  
> <https://github.com/apache/ambari/blob/trunk/ambari-
> agent/src/main/python/ambari_agent/Hardware.py#L102>
> 
> We need to make sure that we are properly setting a timeout for this command.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/Hardware.py 36b4f4b 
>   ambari-agent/src/main/python/ambari_agent/main.py fb5b4b1 
>   ambari-agent/src/test/python/ambari_agent/TestMain.py 8c8d347 
> 
> Diff: https://reviews.apache.org/r/40088/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>