You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/05/15 18:02:01 UTC

Review Request 34274: Alerts: Expose Customizable Timeout Parameter For WEB Alerts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34274/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-11173
    https://issues.apache.org/jira/browse/AMBARI-11173


Repository: ambari


Description
-------

Add the ability to control the connection timeout values used by WEB and METRIC alerts.

{code:title="connection_timeout" : 5.0}
        "source": {
          "type": "METRIC",
          "uri": {
            "http": "{{hdfs-site/dfs.namenode.http-address}}",
            "https": "{{hdfs-site/dfs.namenode.https-address}}",
            "https_property": "{{hdfs-site/dfs.http.policy}}",
            "https_property_value": "HTTPS_ONLY",
            "connection_timeout" : 5.0,
...
{code}


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 33f7508 
  ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py a2e3326 
  ambari-agent/src/test/python/ambari_agent/TestAlerts.py af357bc 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java d4fb416 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/alerts.json 2f543ef 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json 5c4c06e 
  ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/alerts.json cd1bd73 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/alerts.json d10897a 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 9502e14 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json 78e5142 
  ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/alerts.json 4bfae15 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/alerts.json d6f569b 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json d25dd78 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HBASE/alerts.json 07a8cff 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/alerts.json c0b9b0b 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/alerts.json f13bb63 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/alerts.json fa1e20a 

Diff: https://reviews.apache.org/r/34274/diff/


Testing
-------

mvn clean test
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 135 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.640 s
[INFO] Finished at: 2015-05-15T11:59:08-04:00
[INFO] Final Memory: 12M/245M
[INFO] ------------------------------------------------------------------------


Thanks,

Jonathan Hurley


Re: Review Request 34274: Alerts: Expose Customizable Timeout Parameter For WEB Alerts

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34274/#review83936
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On May 15, 2015, 4:01 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34274/
> -----------------------------------------------------------
> 
> (Updated May 15, 2015, 4:01 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-11173
>     https://issues.apache.org/jira/browse/AMBARI-11173
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add the ability to control the connection timeout values used by WEB and METRIC alerts.
> 
> {code:title="connection_timeout" : 5.0}
>         "source": {
>           "type": "METRIC",
>           "uri": {
>             "http": "{{hdfs-site/dfs.namenode.http-address}}",
>             "https": "{{hdfs-site/dfs.namenode.https-address}}",
>             "https_property": "{{hdfs-site/dfs.http.policy}}",
>             "https_property_value": "HTTPS_ONLY",
>             "connection_timeout" : 5.0,
> ...
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py 33f7508 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py a2e3326 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py af357bc 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertUri.java d4fb416 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/alerts.json 2f543ef 
>   ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/alerts.json 5c4c06e 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/alerts.json cd1bd73 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/alerts.json d10897a 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 9502e14 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/alerts.json 78e5142 
>   ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/alerts.json 4bfae15 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/alerts.json d6f569b 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json d25dd78 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HBASE/alerts.json 07a8cff 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/alerts.json c0b9b0b 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/OOZIE/alerts.json f13bb63 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/alerts.json fa1e20a 
> 
> Diff: https://reviews.apache.org/r/34274/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 135 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15.640 s
> [INFO] Finished at: 2015-05-15T11:59:08-04:00
> [INFO] Final Memory: 12M/245M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>