Re: Review Request: Debianizing files for Mesos

[Charles Reiss <wo...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2850/
-----------------------------------------------------------

(Updated Sept. 24, 2012, 2 a.m.)


Review request for mesos.


Changes
-------

- don't disable usrlocal check;
- override locatstatedir to /etc for better Debian layout compliance;
- don't use mesos-daemon.sh wrapper from upstart so upstart can manage processes correctly;


Description
-------

This adds files sufficient to build a package for Ubuntu 11.10. Running

./debian/make_snapshot_changelog.sh && debuild -us -uc

should produce a .deb. It is currently necessary that 'java' and 'javac' be configured (as through update-alternatives) to be OpenJDK 7 for this to work.


The resulting package installs Mesos components into /usr, and uses python2.7 and OpenJDK 7. Upstart scripts are installed for mesos-master and mesos-slave along with an /etc/default/mesos to configure whether they run. These scripts invoke the installed mesos-deamon.sh.

Things still to be done to make more generally acceptable Debian packages:
- allow building against other JDKs and python versions, so this package can be built for other Debian-based distros (at least earlier versions of Ubuntu)
- package style violations:
  - add documentation on how to configure the given startup scripts
  - move deploy scripts default config file location to /etc and deploy scripts outside of /var
  - add manpages for executables
- fix changelog entries
- support using system versions of third_party libraries, JS libraries


This addresses bug MESOS-74.
    https://issues.apache.org/jira/browse/MESOS-74


Diffs (updated)
-----

  debian/compat PRE-CREATION 
  debian/control PRE-CREATION 
  debian/copyright PRE-CREATION 
  debian/make_snapshot_changelog.sh PRE-CREATION 
  debian/mesos.default PRE-CREATION 
  debian/mesos.mesos-master.upstart PRE-CREATION 
  debian/mesos.mesos-slave.upstart PRE-CREATION 
  debian/rules PRE-CREATION 
  debian/source/format PRE-CREATION 

Diff: https://reviews.apache.org/r/2850/diff/


Testing
-------


Thanks,

Charles Reiss