You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/06/11 19:01:27 UTC
Re: Review Request 70753: Templatized UPDATE_FRAMEWORK test helpers
over type of FrameworkInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70753/#review215808
-----------------------------------------------------------
Fix it, then Ship it!
Can you rebase this patch? I can't apply it to make the edits, even with a 3 way merge.
src/tests/master/update_framework_tests.cpp
Lines 104 (patched)
<https://reviews.apache.org/r/70753/#comment302689>
The next patch doesn't move it out of v1 and removes the TODO? Why is it here?
src/tests/master/update_framework_tests.cpp
Lines 146 (patched)
<https://reviews.apache.org/r/70753/#comment302691>
Probably we should stick to the existing naming convention of `TFrameworkInfo` , e.g.
https://github.com/apache/mesos/blob/1.8.0/src/tests/mesos.hpp#L508
src/tests/master/update_framework_tests.cpp
Line 170 (original), 174 (patched)
<https://reviews.apache.org/r/70753/#comment302693>
newline
src/tests/master/update_framework_tests.cpp
Lines 179 (patched)
<https://reviews.apache.org/r/70753/#comment302694>
ditto here
- Benjamin Mahler
On May 29, 2019, 6:30 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70753/
> -----------------------------------------------------------
>
> (Updated May 29, 2019, 6:30 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9793
> https://issues.apache.org/jira/browse/MESOS-9793
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch makes possible to use the same helper functions in tests of
> both V1 and V0 UPDATE_FRAMEWORK calls by templatizing them over type of
> FrameworkInfo.
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70753/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>