You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Rick McGuire (JIRA)" <de...@geronimo.apache.org> on 2006/03/20 15:26:58 UTC
[jira] Created: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Add GBeans for configuring NNTPTransport and NNTPStore access
-------------------------------------------------------------
Key: GERONIMO-1754
URL: http://issues.apache.org/jira/browse/GERONIMO-1754
Project: Geronimo
Type: New Feature
Components: mail
Versions: 1.2
Reporter: Rick McGuire
Attachments: GERONIMO-1754.patch
The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Rick McGuire (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=all ]
Rick McGuire updated GERONIMO-1754:
-----------------------------------
Attachment: GERONIMO-1754B.patch
Doh! I grabbed a version of the file from the wrong build. This is the one I meant to attach, which I've verified by applying the patch to a fresh checkout.
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch, GERONIMO-1754B.patch, GERONIMO-1754B.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=comments#action_12371094 ]
Jacek Laskowski commented on GERONIMO-1754:
-------------------------------------------
Committed revision 387218. Thanks Rick!
Some comments:
* The ASL header should contain 'Copyright 2006' rather than 'Copyright 2004' (fixed)
* Why do you use literal strings rathen than constants, e.g. mail.nntp.quitwait - it's less error-prone
Before I close the issue, please submit another patch with these constants in (or provide some explanation why it only adds unnecessary burden ;))
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Rick McGuire (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=comments#action_12371240 ]
Rick McGuire commented on GERONIMO-1754:
----------------------------------------
Some notes:
> * @version should be @version $Rev$ $Date$
Noted for the future.
> * I didn't think *.orig files should have been committed, too, should they?
No they shouldn't have. I don't see any .orig files in the patch. Where did they come from?
> * Copyright in the new files should be 2006
Grrr, forgot to change that in the last file I created. Sorry.
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch, GERONIMO-1754B.patch, GERONIMO-1754B.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Rick McGuire (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=all ]
Rick McGuire closed GERONIMO-1754:
----------------------------------
Resolution: Fixed
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Security: public(Regular issues)
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Assignee: Rick McGuire
> Attachments: GERONIMO-1754.patch, GERONIMO-1754B.patch, GERONIMO-1754B.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=comments#action_12371238 ]
Jacek Laskowski commented on GERONIMO-1754:
-------------------------------------------
Committed revision 387533. Thanks Rick!
Some notes:
* @version should be @version $Rev$ $Date$
* I didn't think *.orig files should have been committed, too, should they?
* Copyright in the new files should be 2006
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch, GERONIMO-1754B.patch, GERONIMO-1754B.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Rick McGuire (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=all ]
Rick McGuire updated GERONIMO-1754:
-----------------------------------
Attachment: GERONIMO-1754.patch
This get's applied to the Geronimo mail module.
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Rick McGuire (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=all ]
Rick McGuire updated GERONIMO-1754:
-----------------------------------
Attachment: GERONIMO-1754B.patch
A patch built on the already committed previous patch that replaces hard coded literal strings in the protocol GBeans with constants. This also adds an SMTPSTransportGBean to complete the set of GBean adaptors for all of the currently supported protocols.
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch, GERONIMO-1754B.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=comments#action_12371221 ]
Jacek Laskowski commented on GERONIMO-1754:
-------------------------------------------
I've got loads of errors during patching and am wondering how it went on your side? Any idea as to how to proceed?
$ svn status
? GERONIMO-1754B.patch
jlaskowski@JLASKOWSKI /cygdrive/c/oss/geronimo/modules/mail
$ svn info
Path: .
URL: https://svn.apache.org/repos/asf/geronimo/trunk/modules/mail
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 387517
Node Kind: directory
Schedule: normal
Last Changed Author: jlaskowski
Last Changed Rev: 387218
Last Changed Date: 2006-03-20 16:12:37 +0100 (Mon, 20 Mar 2006)
Properties Last Updated: 2005-11-23 09:29:08 +0100 (Wed, 23 Nov 2005)
jlaskowski@JLASKOWSKI /cygdrive/c/oss/geronimo/modules/mail
$ patch -p0 < GERONIMO-1754B.patch
(Stripping trailing CRs from patch.)
patching file src/test/org/apache/geronimo/mail/MailGBeanTest.java
Hunk #1 FAILED at 140.
Hunk #2 FAILED at 242.
Hunk #3 FAILED at 263.
3 out of 3 hunks FAILED -- saving rejects to file src/test/org/apache/geronimo/mail/MailGBeanTest.java.rej
(Stripping trailing CRs from patch.)
patching file src/test/org/apache/geronimo/mail/TestTransport.java
Reversed (or previously applied) patch detected! Assume -R? [n] y
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/geronimo/mail/IMAPStoreGBean.java
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/geronimo/mail/SMTPSTransportGBean.java
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/geronimo/mail/NNTPStoreGBean.java
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/geronimo/mail/NNTPTransportGBean.java
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/geronimo/mail/NNTPGBeanConstants.java
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/geronimo/mail/POP3StoreGBean.java
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/geronimo/mail/SMTPTransportGBean.java
(Stripping trailing CRs from patch.)
patching file src/java/org/apache/geronimo/mail/ProtocolGBean.java
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch, GERONIMO-1754B.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=all ]
Jacek Laskowski reassigned GERONIMO-1754:
-----------------------------------------
Assign To: Rick McGuire
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Assignee: Rick McGuire
> Attachments: GERONIMO-1754.patch, GERONIMO-1754B.patch, GERONIMO-1754B.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=comments#action_12371101 ]
Jacek Laskowski commented on GERONIMO-1754:
-------------------------------------------
If you don't mind, I'd love to apply the changes once done. Thanks!
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=comments#action_12372734 ]
Jacek Laskowski commented on GERONIMO-1754:
-------------------------------------------
Is there anything left before closing it?
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch, GERONIMO-1754B.patch, GERONIMO-1754B.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1754) Add GBeans for configuring
NNTPTransport and NNTPStore access
Posted by "Rick McGuire (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1754?page=comments#action_12371097 ]
Rick McGuire commented on GERONIMO-1754:
----------------------------------------
I essentially just copied what was done for the other transport/store GBeans, which also just used literals for those constants. It might make sense to use a common set between NNTPStore/NNTPTransport (maybe by placing them in an extra constants class). Should the rest of the GBeans redone also?
> Add GBeans for configuring NNTPTransport and NNTPStore access
> -------------------------------------------------------------
>
> Key: GERONIMO-1754
> URL: http://issues.apache.org/jira/browse/GERONIMO-1754
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.2
> Reporter: Rick McGuire
> Attachments: GERONIMO-1754.patch
>
> The Geronimo Mail support has GBeans for configuring each of the javamail protocols (SMTP, POP3, IMAP), but the Geronimo javamail implemenation now has support for nntp and nntp-post protocols, so additional GBeans are needed for the new protocols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira