[jira] Closed: (ADFFACES-9) Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java

["Adam Winer (JIRA)" <ad...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/ADFFACES-9?page=all ]
     
Adam Winer closed ADFFACES-9:
-----------------------------

    Resolution: Fixed

> Brittleness in RowKeySetImplTest.java and RowKeySetTreeImplTest.java
> --------------------------------------------------------------------
>
>          Key: ADFFACES-9
>          URL: http://issues.apache.org/jira/browse/ADFFACES-9
>      Project: MyFaces ADF-Faces
>         Type: Bug

>   Components: Build
>     Reporter: Ryan Williams
>     Assignee: Adam Winer
>     Priority: Minor
>  Attachments: test_patch.txt
>
> Some of the tests in RowKeySetImplTest.java and RowKeySetTreeImplTest.java are very brittle.  They check the the length in bytes of a serialized object against a hard-coded value.  I believe that this was intended as a sort of sanity check, but the tests fail for completely innocuous reasons, chief among them being a change in the packagename.  We encountered this problem when repackaging internally, when repackaging to org.apache, and will encounter it again once a project name is decided upon.  The tests should be changed so that they don't compare for equality with a particular value.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira