[GitHub] [arrow] ianmcook commented on a change in pull request #10896: ARROW-12959: [C++] Option for is_null(NaN) to evaluate to true

[GitBox <gi...@apache.org>]

ianmcook commented on a change in pull request #10896:
URL: https://github.com/apache/arrow/pull/10896#discussion_r686863423



##########
File path: cpp/src/arrow/compute/kernels/scalar_validity.cc
##########
@@ -76,11 +79,32 @@ struct IsInfOperator {
 
 struct IsNullOperator {
   static Status Call(KernelContext* ctx, const Scalar& in, Scalar* out) {
-    checked_cast<BooleanScalar*>(out)->value = !in.is_valid;
+    auto options = OptionsWrapper<NanNullOptions>::Get(ctx);
+    bool* out_value = &checked_cast<BooleanScalar*>(out)->value;
+    if (in.is_valid) {
+      switch (in.type->id()) {
+        case Type::FLOAT:
+          *out_value = options.nan_is_null &&
+                       std::isnan(internal::UnboxScalar<FloatType>::Unbox(in));
+          break;
+        case Type::DOUBLE:
+          *out_value = options.nan_is_null &&
+                       std::isnan(internal::UnboxScalar<DoubleType>::Unbox(in));
+          break;
+        default:
+          *out_value = false;
+      }
+    } else {
+      *out_value = true;
+    }
+
     return Status::OK();
   }
 
   static Status Call(KernelContext* ctx, const ArrayData& arr, ArrayData* out) {
+    // TODO: Is `options` needed for detect nulls? Which is the better way to
+    // handle is_null for ArrayData
+    auto options = OptionsWrapper<NanNullOptions>::Get(ctx);

Review comment:
       @Christian8491 when this PR is ready, the C++ code is all reviewed and approved, and the CI is all green, please let me know and I can push a commit that changes the R bindings to use this new option.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org