You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2023/06/05 18:17:30 UTC
[GitHub] [camel-k-runtime] claudio4j opened a new pull request, #1040: Add more capabilities and their dependencies
claudio4j opened a new pull request, #1040:
URL: https://github.com/apache/camel-k-runtime/pull/1040
Adds some capabilities present in camel-k and their dependencies.
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] claudio4j closed pull request #1040: Add more capabilities and their dependencies
Posted by "claudio4j (via GitHub)" <gi...@apache.org>.
claudio4j closed pull request #1040: Add more capabilities and their dependencies
URL: https://github.com/apache/camel-k-runtime/pull/1040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] squakez commented on pull request #1040: Add more capabilities and their dependencies
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #1040:
URL: https://github.com/apache/camel-k-runtime/pull/1040#issuecomment-1672750163
@claudio4j I think this work can be still used as a base for adding a new trait parameter in the catalog. Do you mind if I continue from here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] squakez commented on pull request #1040: Add more capabilities and their dependencies
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #1040:
URL: https://github.com/apache/camel-k-runtime/pull/1040#issuecomment-1672875031
Going deep in the development I realized that Camel K already mixes the concept of traits and capabilities. Ie, `cron` is a trait, but it also set it as https://github.com/apache/camel-k/blob/781d776a4a43627b6eaf55a6c38b43deed585f51/pkg/trait/cron.go#L187
I am merging this the way it is, after all it was inline with the actual Camel K design. Sorry for all this back and forth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] squakez merged pull request #1040: Add more capabilities and their dependencies
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #1040:
URL: https://github.com/apache/camel-k-runtime/pull/1040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org